Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Message-ID: <2d813b2fdf39756ebee087d97f9ee4b2965f4193.camel@redhat.com>
Subject: Re: [PATCH 5/6] drm/amdgpu/dm/mst: Report possible_crtcs
 incorrectly, for now
From:   Lyude Paul <lyude@redhat.com>
To:     Daniel Vetter <daniel@ffwll.ch>, Sean Paul <sean@poorly.run>
Cc:     amd-gfx@lists.freedesktop.org,
        Ville =?ISO-8859-1?Q?Syrj=E4l=E4?= 
        <ville.syrjala@linux.intel.com>,
        Harry Wentland <harry.wentland@amd.com>,
        Leo Li <sunpeng.li@amd.com>,
        Alex Deucher <alexander.deucher@amd.com>,
        Christian =?ISO-8859-1?Q?K=F6nig?= <christian.koenig@amd.com>,
        "David (ChunMing) Zhou" <David1.Zhou@amd.com>,
        David Airlie <airlied@linux.ie>,
        Nicholas Kazlauskas <nicholas.kazlauskas@amd.com>,
        David Francis <David.Francis@amd.com>,
        Mario Kleiner <mario.kleiner.de@gmail.com>,
        dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Date:   Fri, 11 Oct 2019 16:51:13 -0400
In-Reply-To: <20191009150155.GD16989@phenom.ffwll.local>
References: <20190926225122.31455-1-lyude@redhat.com>
         <20190926225122.31455-6-lyude@redhat.com>
         <20190927152741.GU218215@art_vandelay>
         <20191009150155.GD16989@phenom.ffwll.local>
Organization: Red Hat
User-Agent: Evolution 3.32.4 (3.32.4-1.fc30)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

a little late but: i915 does have this hack (or rather-possible_crtcs with =
MST
in i915 has been broken for a while and got fixed, but had to get reverted
because of this issue), it's where this originally came from.

On Wed, 2019-10-09 at 17:01 +0200, Daniel Vetter wrote:
> On Fri, Sep 27, 2019 at 11:27:41AM -0400, Sean Paul wrote:
> > On Thu, Sep 26, 2019 at 06:51:07PM -0400, Lyude Paul wrote:
> > > This commit is seperate from the previous one to make it easier to
> > > revert in the future. Basically, there's multiple userspace applicati=
ons
> > > that interpret possible_crtcs very wrong:
> > >=20
> > > https://gitlab.freedesktop.org/xorg/xserver/merge_requests/277
> > > https://gitlab.gnome.org/GNOME/mutter/issues/759
> > >=20
> > > While work is ongoing to fix these issues in userspace, we need to
> > > report ->possible_crtcs incorrectly for now in order to avoid
> > > introducing a regression in in userspace. Once these issues get fixed=
,
> > > this commit should be reverted.
> > >=20
> > > Signed-off-by: Lyude Paul <lyude@redhat.com>
> > > Cc: Ville Syrj=C3=A4l=C3=A4 <ville.syrjala@linux.intel.com>
> > > ---
> > >  drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 11 +++++++++++
> > >  1 file changed, 11 insertions(+)
> > >=20
> > > diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> > > b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> > > index b404f1ae6df7..fe8ac801d7a5 100644
> > > --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> > > +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> > > @@ -4807,6 +4807,17 @@ static int amdgpu_dm_crtc_init(struct
> > > amdgpu_display_manager *dm,
> > >  =09if (!acrtc->mst_encoder)
> > >  =09=09goto fail;
> > > =20
> > > +=09/*
> > > +=09 * FIXME: This is a hack to workaround the following issues:
> > > +=09 *
> > > +=09 * https://gitlab.gnome.org/GNOME/mutter/issues/759
> > > +=09 * https://gitlab.freedesktop.org/xorg/xserver/merge_requests/277
> > > +=09 *
> > > +=09 * One these issues are closed, this should be removed
> >=20
> > Even when these issues are closed, we'll still be introducing a regress=
ion
> > if we
> > revert this change. Time for actually_possible_crtcs? :)
> >=20
> > You also might want to briefly explain the u/s bug in case the links go
> > sour.
> >=20
> > > +=09 */
> > > +=09acrtc->mst_encoder->base.possible_crtcs =3D
> > > +=09=09amdgpu_dm_get_encoder_crtc_mask(dm->adev);
> >=20
> > Why don't we put this hack in amdgpu_dm_dp_create_fake_mst_encoder()?
>=20
> If we don't have the same hack for i915 mst I think we shouldn't merge
> this ... broken userspace is broken.
> -Daniel
--=20
Cheers,
=09Lyude Paul