Received: by 2002:a5b:505:0:0:0:0:0 with SMTP id o5csp1434664ybp; Fri, 11 Oct 2019 14:18:27 -0700 (PDT) X-Google-Smtp-Source: APXvYqwQdFY9r37PZ7Ip1UaBNtiqDlQEAkgZAGPkHXRhCMFabqaqIEq//zAFYpTbm+xO4Xc9xMXS X-Received: by 2002:aa7:df07:: with SMTP id c7mr15415623edy.110.1570828707486; Fri, 11 Oct 2019 14:18:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1570828707; cv=none; d=google.com; s=arc-20160816; b=rD9s01BGEchRkU71RKRTA4FNVGsjhwdYcGi0ftBwImVEgvmbHRhINfvVG67QDuVyno 2BB+GL0HfsdPTqSLROJddDe7JyObTMqE6lMB8MFiFoAxXNO10qaELxVUT/Fi+nTSWL1f 8yQQgSvFTVsQ2UX5iWxORAUKOahm78PkuGJs3R5r0FOAgpyC9sJsg77sJYFj7plusKXw HImsttzJwvqd4rl4TKCA+L6uc2TcQmnY+0OCOPmoV6jjSv6hWtqysn0B3cku/19SMUlz kx/DDiULP6i6E02xEN1PS4ghws9/5yWH/uxKkqstevhymFRgGwDslSa4cfw1xTKkRaTA YKlQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=LG3n9bP9kGhQ7SFk9OxCo0gPqdU2gHnkRjsbnMNvlpY=; b=GIUPMIZmAAR3LXxChP1xdRFZwcX0Mz3lOMiohunWk6apAHMPFedmQkyrJiQaYNs3NA oTY+kC3K9/YuMs/E3J2MdfWgtcFw64mdn7+9p64yB2EA3736UEEv1slNKs/ItLYxzhYU /cMhrXPaeVx6/61SS3nwz5WatrQGnsUQMR9CPQx4WQJRzt3TkKly+OzmQlShjY515WX3 m2lQWL4fcPCGilRMwVj31ZusKZEJktr4VIICitJQyK9ttjvY4b6O1IaTXAUs8bKhtYNY 0H37ipbnEDTREiVHNvgi6pUoOda0azhs9goa3wU5JJ4unsqJ4V7fPEQs4im9aVg+6EIq Hjzg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=dBJnWFOo; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 52si7155994edz.413.2019.10.11.14.18.03; Fri, 11 Oct 2019 14:18:27 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=dBJnWFOo; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728153AbfJKVRL (ORCPT + 99 others); Fri, 11 Oct 2019 17:17:11 -0400 Received: from mail-wm1-f67.google.com ([209.85.128.67]:36096 "EHLO mail-wm1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726843AbfJKVRL (ORCPT ); Fri, 11 Oct 2019 17:17:11 -0400 Received: by mail-wm1-f67.google.com with SMTP id m18so11432693wmc.1 for ; Fri, 11 Oct 2019 14:17:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=LG3n9bP9kGhQ7SFk9OxCo0gPqdU2gHnkRjsbnMNvlpY=; b=dBJnWFOoIb19dqOC0j3JvCCdRfPc4OHL3xsyrufrdm7gBPTGnMnrAJ7Th95lKJlV+3 wrMoLQWul2U+Cq1vwvMLQ202arVVEaOUx7L6I9ehm3vPeCkqa9MDuiaciVxs7PVAbT6R tOfegMjBnURzNKAMtrYiLB4ybuPKUXIq9PPnf56Isisv9H8gh6Mhmc1BG1Cnj5onhjgO MFDxSNzk2+sJpHb4zfDFjl+fszrvHf6aVQJubTaMYRCjeBEjf7gtB++7ZWK6n7ql0IEJ /VtPYb5cTW6aHS1MMuuxNNBmGqqhR30g3wQFGRz92BHUeTRqiCIFIy2eZUDbaThcs9/9 MHSQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=LG3n9bP9kGhQ7SFk9OxCo0gPqdU2gHnkRjsbnMNvlpY=; b=VJ9Je1pMJGLfSZKRKIYEG3ZghhaGdn8sM5UM7hi86dKN9Zq3D9YPdLAA0dDIo7OzTF ano/fJpWNZg/+jqlHleWisAHJaddvD/F92ryf6H2eH3FjW28XUq47jgc9vLJg4g8wrga 423L6p4Ha7/P63RtvOCGxD4jobMx/jbqczr00fxLKxM1QvOQIVJjnukkzvu7cZ4ZuxrF cDm26Z7pBFGZOnu9roMwp3GhrnsolFLAiXCapctuyX8Q3Z+fCNICuIwlQs/0k4LxyDUH cQbWWE+F4jHVIzTjVXxgl5OCOWnd1VDyrq2r4hDLKRFopBsK0ybEeNHgXBKEB2QkMLVf E4Aw== X-Gm-Message-State: APjAAAWgrYhrbl2Bf6cPPBLsHW3OM0R+HEBkNWsa3dEyUN3md3+cY7Le 0NVO+NXEM75OUUvn0QTbWV0uwHRCPSag4uw= X-Received: by 2002:a7b:c387:: with SMTP id s7mr4391784wmj.110.1570828628423; Fri, 11 Oct 2019 14:17:08 -0700 (PDT) Received: from ninjahub.lan (host-2-102-13-201.as13285.net. [2.102.13.201]) by smtp.googlemail.com with ESMTPSA id u2sm3265117wml.44.2019.10.11.14.17.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 11 Oct 2019 14:17:07 -0700 (PDT) From: Jules Irenge To: outreachy-kernel@googlegroups.com Cc: gregkh@linuxfoundation.org, eric@anholt.net, wahrenst@gmx.net, linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org, linux-arm-kernel@lists.infradead.org, linux-rpi-kernel@lists.infradead.org, daniela.mormocea@gmail.com, dave.stevenson@raspberrypi.org, hverkuil-cisco@xs4all.nl, mchehab+samsung@kernel.org, bcm-kernel-feedback-list@broadcom.com, sbranden@broadcom.com, rjui@broadcom.com, f.fainelli@gmail.com, Jules Irenge Subject: [PATCH] staging: vc04_services: fix warnings of lines should not end with open parenthesis Date: Fri, 11 Oct 2019 22:16:37 +0100 Message-Id: <20191011211637.19311-1-jbi.octave@gmail.com> X-Mailer: git-send-email 2.21.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fix warning of lines should not end with open parenthesis. Issue detected by checkpatch tool. Signed-off-by: Jules Irenge --- .../bcm2835-camera/bcm2835-camera.c | 38 ++++++++----------- 1 file changed, 16 insertions(+), 22 deletions(-) diff --git a/drivers/staging/vc04_services/bcm2835-camera/bcm2835-camera.c b/drivers/staging/vc04_services/bcm2835-camera/bcm2835-camera.c index d4d1e44b16b2..c7bb6e3f529c 100644 --- a/drivers/staging/vc04_services/bcm2835-camera/bcm2835-camera.c +++ b/drivers/staging/vc04_services/bcm2835-camera/bcm2835-camera.c @@ -337,9 +337,8 @@ static void buffer_cb(struct vchiq_mmal_instance *instance, if (is_capturing(dev)) { v4l2_dbg(1, bcm2835_v4l2_debug, &dev->v4l2_dev, "Grab another frame"); - vchiq_mmal_port_parameter_set( - instance, - dev->capture.camera_port, + vchiq_mmal_port_parameter_set(instance, + dev->capture.camera_port, MMAL_PARAMETER_CAPTURE, &dev->capture.frame_count, sizeof(dev->capture.frame_count)); @@ -392,9 +391,8 @@ static void buffer_cb(struct vchiq_mmal_instance *instance, is_capturing(dev)) { v4l2_dbg(1, bcm2835_v4l2_debug, &dev->v4l2_dev, "Grab another frame as buffer has EOS"); - vchiq_mmal_port_parameter_set( - instance, - dev->capture.camera_port, + vchiq_mmal_port_parameter_set(instance, + dev->capture.camera_port, MMAL_PARAMETER_CAPTURE, &dev->capture.frame_count, sizeof(dev->capture.frame_count)); @@ -1124,9 +1122,8 @@ static int mmal_setup_components(struct bm2835_mmal_dev *dev, dev->capture.timeperframe.numerator; ret = vchiq_mmal_port_set_format(dev->instance, preview_port); if (overlay_enabled) { - ret = vchiq_mmal_port_connect_tunnel( - dev->instance, - preview_port, + ret = vchiq_mmal_port_connect_tunnel(dev->instance, + preview_port, &dev->component[COMP_PREVIEW]->input[0]); if (!ret) ret = vchiq_mmal_port_enable(dev->instance, @@ -1154,9 +1151,8 @@ static int mmal_setup_components(struct bm2835_mmal_dev *dev, camera_port->recommended_buffer.num; ret = - vchiq_mmal_port_connect_tunnel( - dev->instance, - camera_port, + vchiq_mmal_port_connect_tunnel(dev->instance, + camera_port, &encode_component->input[0]); if (ret) { v4l2_dbg(1, bcm2835_v4l2_debug, @@ -1655,8 +1651,8 @@ static int mmal_init(struct bm2835_mmal_dev *dev) dev->capture.enc_level = V4L2_MPEG_VIDEO_H264_LEVEL_4_0; /* get the preview component ready */ - ret = vchiq_mmal_component_init( - dev->instance, "ril.video_render", + ret = vchiq_mmal_component_init(dev->instance, + "ril.video_render", &dev->component[COMP_PREVIEW]); if (ret < 0) goto unreg_camera; @@ -1669,8 +1665,8 @@ static int mmal_init(struct bm2835_mmal_dev *dev) } /* get the image encoder component ready */ - ret = vchiq_mmal_component_init( - dev->instance, "ril.image_encode", + ret = vchiq_mmal_component_init(dev->instance, + "ril.image_encode", &dev->component[COMP_IMAGE_ENCODE]); if (ret < 0) goto unreg_preview; @@ -1731,15 +1727,13 @@ static int mmal_init(struct bm2835_mmal_dev *dev) unreg_vid_encoder: pr_err("Cleanup: Destroy video encoder\n"); - vchiq_mmal_component_finalise( - dev->instance, - dev->component[COMP_VIDEO_ENCODE]); + vchiq_mmal_component_finalise(dev->instance, + dev->component[COMP_VIDEO_ENCODE]); unreg_image_encoder: pr_err("Cleanup: Destroy image encoder\n"); - vchiq_mmal_component_finalise( - dev->instance, - dev->component[COMP_IMAGE_ENCODE]); + vchiq_mmal_component_finalise(dev->instance, + dev->component[COMP_IMAGE_ENCODE]); unreg_preview: pr_err("Cleanup: Destroy video render\n"); -- 2.21.0