Received: by 2002:a5b:505:0:0:0:0:0 with SMTP id o5csp1508004ybp; Fri, 11 Oct 2019 15:38:41 -0700 (PDT) X-Google-Smtp-Source: APXvYqz7o7Iv/zyZE5NA73bS1pAMqVDXz3p4b+xlxBNZiCclLxoOJHBYXtyvVxXYkkb6clORfvT7 X-Received: by 2002:a50:98c6:: with SMTP id j64mr15906146edb.295.1570833521085; Fri, 11 Oct 2019 15:38:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1570833521; cv=none; d=google.com; s=arc-20160816; b=Dx5DBcKRE2b8buYG2hb5mmbhj06JQkUztLaT6lBfT/SBSKcxmf+BKAlhPMw4sATyXC MnxkP+6JMLkDOv6IHY0eoLeOgwU0wrhN6rWnPYNGNyqvbZ5KEEoDj/UJ7h/T8JzROza+ 3EtqJUFoALw05pIHIaHLfx16zPUgm2R8TsKoKWDQ1m38B4pVVAr+uxEoClzvUj7AaswD KjEqoPh63zW2op0a67IiL7jCRf/vzbvHOWU4T9GC9eZnpADRZXpYYVGcHU3r4LUxl2mu pNjvYukj3Rt2Boxk7mKmkCHHN8/XADard3hi5Tt4LaUgUtn/Jm864ZLm2r4o5Ccw6OCz QfvQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=iYAYC3wS5kKgW3tJiDPUFQyWjg/Hppq/ySaf6EhAiPM=; b=ewdf2DDWGW2vIZzU6M/sHrOVBFFVWIDwnQI4RYHxPTj25ukjuNPc5HCTp3xLgxlZVV ApOSpf/6l9DjUx/TZ81P/JfbVbpVqzkCpU2oPk+umrXHDYrxV4muAfA0suSixe4CbQgO RWmzoqh3HMPNWJgRMYI9RYporEuuOGX+e7PLLPV4iSy/5kP9dV5W4YlNrS0vDfXVtqB4 hKWNtFFwzeJXrk3hbfCF1Yam8qCFp1lSgmTR+EdzmlzZHVxtbye4ujwCPwQe7KSX+H47 /4l2jzN6VjAufmFo/mhieMvO4e0o3O3P2xL9iEaiWPAGnGsWVy59/OLyMJCOwmg/ijcU lhrA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b="NtE/nU2k"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id x19si6246405eje.336.2019.10.11.15.38.17; Fri, 11 Oct 2019 15:38:41 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b="NtE/nU2k"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729234AbfJKWLf (ORCPT + 99 others); Fri, 11 Oct 2019 18:11:35 -0400 Received: from mail-oi1-f194.google.com ([209.85.167.194]:44821 "EHLO mail-oi1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729124AbfJKWLf (ORCPT ); Fri, 11 Oct 2019 18:11:35 -0400 Received: by mail-oi1-f194.google.com with SMTP id w6so9251477oie.11 for ; Fri, 11 Oct 2019 15:11:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=iYAYC3wS5kKgW3tJiDPUFQyWjg/Hppq/ySaf6EhAiPM=; b=NtE/nU2k1zFWLS8Z4FDgsjYbX5WCZ1ArXUPUCPvpWV8kwc3Dh7NQ7req7s1attiFtP b0qhInWtI3gB+KYBMIPR+WGpEqpCAYvqUduOs2NcQLIyG32CJ36fZXgDO3nv0OKQxhiF D3iuM1mIQiITP0fwnHdSpg1rfXsR0RJmvmioSlsrfQ/oOz+T8y1y2pp/PAE4KpeNjLM7 wMAXjp+nPX3q2tJQ0GgWG/R/9ACmwDTDo3o6Bepti2xnthNrpeSksnTVn9MOWwC8b5NT 2FpmXC7KnJ+izV1W9YfFAFHWY1vRy7YTKsQHFuwpnrP8M9SNN4WPKSVFTOoE9VbCnvzR sFgA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=iYAYC3wS5kKgW3tJiDPUFQyWjg/Hppq/ySaf6EhAiPM=; b=etB2MJ/jNEJzIaG02/E0w1hpbBPXcMeaDnRQECkM6AomDvOaw1U7JD3i5rb3DQnlvf wxl6CmZDkuCMaTq4aQT5Vu3WNc3UF3Oi6aFceVKMNBrdULG15QJqBHhge1GFEiJhVEcV G0jj8hWa/Ho6a4e7NCAv0Mpk9g0V4owTsowZPblLZVpJmzdFkUp0iegbh0nfkq03/aLJ 4zCHTCIOS8sUMK+QR5MSpXvlm2GRVRDg/+0O16YZKkWHVU6rkDLi5AH5msWLnb9C6a7e KLUyzVEj6xrG/pvFQ+a06af23Xfbe+nO/2IvOw0GWy6hzUyHMDSDkshWMYtpQ7xWBcVU IWVw== X-Gm-Message-State: APjAAAUyyomG4InNUQs/H2fVwSXtjNo1Q/je5jwYHesN38WS4lc0Lomf 4Ix1qczEm01P74pRbNjxd/xxJGRr/vzu8vyQ0USlmg== X-Received: by 2002:aca:cd4d:: with SMTP id d74mr14539387oig.157.1570831894397; Fri, 11 Oct 2019 15:11:34 -0700 (PDT) MIME-Version: 1.0 References: <20190715191804.112933-1-hridya@google.com> In-Reply-To: From: Jann Horn Date: Sat, 12 Oct 2019 00:11:08 +0200 Message-ID: Subject: Re: [PATCH] binder: prevent transactions to context manager from its own process. To: Hridya Valsaraju , Todd Kjos Cc: Greg Kroah-Hartman , =?UTF-8?B?QXJ2ZSBIasO4bm5ldsOlZw==?= , Martijn Coenen , Joel Fernandes , Christian Brauner , "open list:ANDROID DRIVERS" , kernel list , kernel-team , syzbot+8b3c354d33c4ac78bfad@syzkaller.appspotmail.com Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Oct 11, 2019 at 11:59 PM Jann Horn wrote: > (I think you could also let A receive a handle > to itself and then transact with itself, but I haven't tested that.) Ignore this sentence, that's obviously wrong because same-binder_proc nodes will always show up as a binder, not a handle.