Received: by 2002:a5b:505:0:0:0:0:0 with SMTP id o5csp2173873ybp; Sat, 12 Oct 2019 05:34:03 -0700 (PDT) X-Google-Smtp-Source: APXvYqzMSh456GWZMVl9Nr7Cr06jlvFUviWv3IN4kKseaTlpiUKUKM2qVFhtWBVNFYXc15KAsyGl X-Received: by 2002:a50:8d8a:: with SMTP id r10mr18760183edh.302.1570883643766; Sat, 12 Oct 2019 05:34:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1570883643; cv=none; d=google.com; s=arc-20160816; b=acIplOnFku2Py6ArSDUBsfoOuFYZn7FEO+iHsvgsiQ8ZXWKUYpLKpsTjuaYb3SepzM xfi/RveqTIXCcxC4VmWLWObuy52gGCutnUsyx0d9uXd43T6MqfQ/gK+YEKmA9rzE6XUi DoBhMa+CQ8k3L0tjjeajPLUWWwVXzBNFTXOQCWufrgn/OoMNEKmxouBvDH4XZy072uZY 2M9vY/bA/l/yFebPKSbV5YiU5dBhGLoIpwNxumfPH2BkWzYLB9tQGcHYr55y4Rfgxq5t z+IY2NXNi8jj8nJfIHbMkL/Hp208Ult0/oZzQSVx3gtdkTb8in0e9N74vkyB1DpJ4L5V CW7A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=CUVTcUa5b8bKD7FsmBN2tFeSI1tiWWw4BFpLw9k7yCs=; b=0uScJUJFp6Q45N6fXzmInHKuihZJm9HjDrzTd/FyP0LMqow+goMaGwYBz8NrhkaB2K T15uGpcJNy7ivGpOeyEjb+NqNoSZncnEmGNEG67kxBktzWz1wq2qSUpqzqHxuRKwKbA/ 3hIHxSC35+mfJFtk5Yfc4wiRfk/0rP1bsC+NCdJNxJIFVx5nzRtMVcKSMXW7eWzpRpju mPRZqfsMaTV1f0MTasI5Tc38bQBCyZmcYT2IBLq4YW1ct201UJDHr1Q9+19Np8EhEA9u Ey+pdHWsM7txz39uzBe2Bjw8XKQIzsRVJSmTe4/KoobeH0C2PheTTujEksYgTbJg42/v yD6g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=ZEe0bJ+1; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id b16si7211643ejb.165.2019.10.12.05.33.26; Sat, 12 Oct 2019 05:34:03 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=ZEe0bJ+1; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728882AbfJLMb4 (ORCPT + 99 others); Sat, 12 Oct 2019 08:31:56 -0400 Received: from mail-pl1-f194.google.com ([209.85.214.194]:43388 "EHLO mail-pl1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726821AbfJLM34 (ORCPT ); Sat, 12 Oct 2019 08:29:56 -0400 Received: by mail-pl1-f194.google.com with SMTP id f21so5746362plj.10 for ; Sat, 12 Oct 2019 05:29:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=CUVTcUa5b8bKD7FsmBN2tFeSI1tiWWw4BFpLw9k7yCs=; b=ZEe0bJ+1FUWHAd7hQeuzlNX/YuaFs6XETmII7Fd2roFyVU7ZxUZYSJZhvRfCSh+oHF r8e8KobZ2Zq4aJTgsCnVidrK+K/dMHb5sBZjt10nA6Q9jNReWqzoN5bfqw4nUYd7fxQA Y1zLqclmF7IIT8xZCXLaBwjHUzcAUQXayGM1/rlc58V1KcjSqPQrLVs45eA2ylNa6LCp YbrrnOQxWJIi5GLbiiv2MhgkrevEbQMHw0FwbzryLbL/cYAqRlLMGBF0JQ5jDsS7cs38 Swn1LU0gK6Uywm6QOej3PSgbkqGk8NUU9DofCGqnR4mvK/O31ju8G/C9VulR78+z3ElB IGjg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=CUVTcUa5b8bKD7FsmBN2tFeSI1tiWWw4BFpLw9k7yCs=; b=RAPWfn/57+RSLcVw47/BNrgDi7YdZliZ8F1SUzwPWyWf9feTpstTAzan2/9XgbvrOX RIwDsW3B/ShzJRJh3wI3XIb3CH3Sx4kEFn2w0ZNSJ4q3PnsAyQZ8VX1UPEyUZu6NFSak jUJw46pNmrDNM0fPRCNdZrzpvYX2nUHw0D1Xrmh9j/yQUjLa8ACzmvnvSgYPPoRzU17F vu86abil+1IES8wK+MJFRvWA807SKyxJuLDeTY8NK/9Ua6qqndXUujixQDkTxx5Bj5hd Cn2EbjvnSn0qUye8wfxxVVptzBLn1Vu+XqYXa2B5lcV1dw8mp+qVcT2P+gaURsBUCAmQ iNXA== X-Gm-Message-State: APjAAAUx/IIijaJ9BpF4cJMiquEoDXlHQtFFy4500+zVmUZbzyzR2u8P Jll5vE/Fk0of/547O2BzTxI= X-Received: by 2002:a17:902:144:: with SMTP id 62mr20399568plb.100.1570883395203; Sat, 12 Oct 2019 05:29:55 -0700 (PDT) Received: from localhost.localdomain ([2402:3a80:95a:fd75:24a6:4bd:55a6:4f65]) by smtp.gmail.com with ESMTPSA id v8sm33708697pje.6.2019.10.12.05.29.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 12 Oct 2019 05:29:54 -0700 (PDT) From: Shyam Saini To: kernel-hardening@lists.openwall.com Cc: iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Shyam Saini , Christoph Hellwig , Marek Szyprowski , Robin Murphy , Matthew Wilcox , Christopher Lameter , Kees Cook Subject: [PATCH] kernel: dma: Make CMA boot parameters __ro_after_init Date: Sat, 12 Oct 2019 17:59:18 +0530 Message-Id: <20191012122918.8066-1-mayhs11saini@gmail.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This parameters are not changed after early boot. By making them __ro_after_init will reduce any attack surface in the kernel. Link: https://lwn.net/Articles/676145/ Cc: Christoph Hellwig Cc: Marek Szyprowski Cc: Robin Murphy Cc: Matthew Wilcox Cc: Christopher Lameter Cc: Kees Cook Signed-off-by: Shyam Saini --- kernel/dma/contiguous.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/kernel/dma/contiguous.c b/kernel/dma/contiguous.c index 69cfb4345388..1b689b1303cd 100644 --- a/kernel/dma/contiguous.c +++ b/kernel/dma/contiguous.c @@ -42,10 +42,10 @@ struct cma *dma_contiguous_default_area; * Users, who want to set the size of global CMA area for their system * should use cma= kernel parameter. */ -static const phys_addr_t size_bytes = (phys_addr_t)CMA_SIZE_MBYTES * SZ_1M; -static phys_addr_t size_cmdline = -1; -static phys_addr_t base_cmdline; -static phys_addr_t limit_cmdline; +static const phys_addr_t __ro_after_init size_bytes = (phys_addr_t)CMA_SIZE_MBYTES * SZ_1M; +static phys_addr_t __ro_after_init size_cmdline = -1; +static phys_addr_t __ro_after_init base_cmdline; +static phys_addr_t __ro_after_init limit_cmdline; static int __init early_cma(char *p) { -- 2.20.1