Received: by 2002:a5b:505:0:0:0:0:0 with SMTP id o5csp3574279ybp; Sun, 13 Oct 2019 09:44:19 -0700 (PDT) X-Google-Smtp-Source: APXvYqxvAQxGRdRJcX0kfDC+2qdJYeRn17daqsaSYOJYla9mwn3mQ3d8zhbiSW6GLgJiokI5wNKA X-Received: by 2002:a05:6402:2c5:: with SMTP id b5mr24738808edx.45.1570985059379; Sun, 13 Oct 2019 09:44:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1570985059; cv=none; d=google.com; s=arc-20160816; b=B8wzlSBIGWcPeGCqZZYIF0UAVBbfXLYmDCHjr580kJU5/TyZETQuXaDAOSyNG8A605 3FOcC4cBwFigeyNjrPCsXEesZa9h1kn0tuo9mYf+92yx8UfRA6C22taGriY/Gk5LcuQv jJAF4RpojQkSmvVHV+bEJYloQKKJ03jjlPacISpPIB4Mu9ZsnK+NV1V8h/yT6JpyeAPa ftsRZvG3MsZFoQTMPbpmaLwcMwC6FqggUdy/r/Z2NozGNyJlYxBAM4IAhLN57fDxN+4m 7GlDRHP1pItl0SwG1+ZreNSGtp90X+pPdqPkQRPjg0yB6Xojx1WP+DeSvLLUbGadAF8T wxQQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:autocrypt:openpgp:from:references:cc:to:subject :dkim-signature; bh=/D5wlqO48MSRyAKVTTRy6GrLGA7BoZm7n8TtwgC14Is=; b=vBUIlXNEC9RC9pjU0smkEXBebT5Q+YlfAUEJiR7v3xPrscz8XEkJUck99zmUQq/HdO uof3KhjUVItZMAgYyhmNdEbdgr+qWghWN4DBtvyWULhwObPPYc+h0Xl1NiIO8oojoCZY ZzGbYSbpaXQdbClbzRf2Zbjw4UHMwEooKy5VQYJUMzqXrxBhKhuqYqI2rMj3EF8rprqL hzUH+x0TPYXKr6RJK5j9PNVD/xpy+CYhYO9e2nGf0PP/uxeVgNAl/GyxSblLyT15hDD/ jsGTyQzmet8uphefPW99yt0w7M5i9E8OULwO7C1P34M1kXP2xeDldGp8w1ZU3KQS45WL UxgQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b="X/aY7Ith"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id t37si12209277edd.25.2019.10.13.09.43.25; Sun, 13 Oct 2019 09:44:19 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b="X/aY7Ith"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729125AbfJMQkX (ORCPT + 99 others); Sun, 13 Oct 2019 12:40:23 -0400 Received: from mail-wm1-f66.google.com ([209.85.128.66]:40542 "EHLO mail-wm1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727386AbfJMQkW (ORCPT ); Sun, 13 Oct 2019 12:40:22 -0400 Received: by mail-wm1-f66.google.com with SMTP id b24so14433308wmj.5; Sun, 13 Oct 2019 09:40:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:openpgp:autocrypt:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=/D5wlqO48MSRyAKVTTRy6GrLGA7BoZm7n8TtwgC14Is=; b=X/aY7IthFl1y6IlfWYavTR3INLtdsYmUAz71Gu36bKV6U41oAu6A4Lo33IRZBloYoS Sgi+jRNI6LOdVDMrescgXW+evzQ+Z2946p0EBn8z6u2+gPym11QWDD4oti3cubU/loFJ rQlbt2Tle7c58ydzUtVWPsfdmhp4WC/kWXrcPyKcklTqKv191RON22hqPUqufUd+L3s8 DnB+E7+ZMB8uLK6Mn1dYv4Z2NevVmSUPLuuBKbGh7Gu/EDNme54a71YRV0dcRdC/xqn2 Y6BjptdvULtTG/wAUsbGKlfWGWV7HNNMLCoFeCvV34VjmeYBCXQLar3gEUNtPZSvFoga 0uZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:openpgp:autocrypt :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=/D5wlqO48MSRyAKVTTRy6GrLGA7BoZm7n8TtwgC14Is=; b=cP7RS/O+8zjkzHemoRqUS9GJQ0EvAABGm3OC+aoeEtYIXwib4kXcXlmfmg3VsFlewr tV59ZSJWU6Sm/uNcFYYVOhqg22vfUZemTm84b2ZmZfaz26dI0Fg/KzYdKTcj/eLlpsml 06ypO2DBOOhXCJttIgXY5uAxNC/OMFHQrNBVJv0sGsR216I0JTW4ZpvH+SKnE95FskNi 06WTQyczFXVLPgecavTlY4HJEquxznJb6H0BcAnDwQvtjS4XMLoEV2t4yxsxD4mRsTp8 yiWO1rVsBMs3qx/m4I1rasNQsONaZNDDxQ4us9fG2DDnnNZQ1SZ1OfNDpKtBOKkKjHGI PuMg== X-Gm-Message-State: APjAAAXcUAFZkztRbHe13u6B7jlzrDniAYDJB0ooHlaWqk5TQH3T5vAL M8c40LLwWr11J8sOXNjd5Lk= X-Received: by 2002:a1c:ed0d:: with SMTP id l13mr11664133wmh.54.1570984819664; Sun, 13 Oct 2019 09:40:19 -0700 (PDT) Received: from [192.168.1.19] (ckd148.neoplus.adsl.tpnet.pl. [83.31.79.148]) by smtp.gmail.com with ESMTPSA id t8sm14365362wrx.76.2019.10.13.09.40.18 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 13 Oct 2019 09:40:18 -0700 (PDT) Subject: Re: [PATCH v5 3/3] leds: Add control of the voltage/current regulator to the LED core To: Pavel Machek Cc: Jean-Jacques Hiblot , daniel.thompson@linaro.org, linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org, dmurphy@ti.com, tomi.valkeinen@ti.com References: <20190923102059.17818-1-jjhiblot@ti.com> <20190923102059.17818-4-jjhiblot@ti.com> <3e648fab-638f-4aa0-dda9-8ddba6562751@gmail.com> <20191013120937.GK5653@amd> From: Jacek Anaszewski Openpgp: preference=signencrypt Autocrypt: addr=jacek.anaszewski@gmail.com; prefer-encrypt=mutual; keydata= mQINBFWjfaEBEADd66EQbd6yd8YjG0kbEDT2QIkx8C7BqMXR8AdmA1OMApbfSvEZFT1D/ECR eWFBS8XtApKQx1xAs1j5z70k3zebk2eeNs5ahxi6vM4Qh89vBM46biSKeeX5fLcv7asmGb/a FnHPAfQaKFyG/Bj9V+//ef67hpjJWR3s74C6LZCFLcbZM0z/wTH+baA5Jwcnqr4h/ygosvhP X3gkRzJLSFYekmEv+WHieeKXLrJdsUPUvPJTZtvi3ELUxHNOZwX2oRJStWpmL2QGMwPokRNQ 29GvnueQdQrIl2ylhul6TSrClMrKZqOajDFng7TLgvNfyVZE8WQwmrkTrdzBLfu3kScjE14Q Volq8OtQpTsw5570D4plVKh2ahlhrwXdneSot0STk9Dh1grEB/Jfw8dknvqkdjALUrrM45eF FM4FSMxIlNV8WxueHDss9vXRbCUxzGw37Ck9JWYo0EpcpcvwPf33yntYCbnt+RQRjv7vy3w5 osVwRR4hpbL/fWt1AnZ+RvbP4kYSptOCPQ+Pp1tCw16BOaPjtlqSTcrlD2fo2IbaB5D21SUa IsdZ/XkD+V2S9jCrN1yyK2iKgxtDoUkWiqlfRgH2Ep1tZtb4NLF/S0oCr7rNLO7WbqLZQh1q ShfZR16h7YW//1/NFwnyCVaG1CP/L/io719dPWgEd/sVSKT2TwARAQABtC1KYWNlayBBbmFz emV3c2tpIDxqYWNlay5hbmFzemV3c2tpQGdtYWlsLmNvbT6JAlgEEwEIAEICGwMHCwkIBwMC AQYVCAIJCgsDFgIBAh4BAheABQkJZgNMFiEEvx38ClaPBfeVdXCQvWpQHLeLfCYFAl05/9sC GQEACgkQvWpQHLeLfCarMQ/9FN/WqJdN2tf6xkP0RFyS4ft0sT04zkOCFfOMxs8mZ+KZoMU+ X3a+fEppDL7xgRFpHyGaEel7lSi1eqtzsqZ5JiHbDS1Ht1G8TtATb8q8id68qeSeW2mfzaLQ 98NPELGfUXFoUqUQkG5z2p92UrGF4Muj1vOIW93pwvE4uDpNsl+jriwHomLtjIUoZtIRjGfZ RCyUQI0vi5LYzXCebuzAjGD7Jh2YAp7fDGrv3qTq8sX+DUJ4H/+I8PiL+jXKkEeppqIhlBJJ l4WcgggMu3c2uljYDuqRYghte33BXyCPAocfO2/sN+yJRUTVuRFlOxUk4srz/W8SQDwOAwtK V7TzdyF1/jOGBxWwS13EjMb4u3XwPMzcPlEQNdIqz76NFmJ99xYEvgkAmFmRioxuBTRv8Fs1 c1jQ00WWJ5vezqY6lccdDroPalXWeFzfPjIhKbV3LAYTlqv0It75GW9+0TBhPqdTM15DrCVX B7Ues7UnD5FBtWwewTnwr+cu8te449VDMzN2I+a9YKJ1s6uZmzh5HnuKn6tAfGyQh8MujSOM lZrNHrRsIsLXOjeGVa84Qk/watEcOoyQ7d+YaVosU0OCZl0GldvbGp1z2u8cd2N/HJ7dAgFh Q7dtGXmdXpt2WKQvTvQXhIrCWVQErNYbDZDD2V0TZtlPBaZP4fkUDkvH+Sy5Ag0EVaN9oQEQ AMPNymBNoCWc13U6qOztXrIKBVsLGZXq/yOaR2n7gFbFACD0TU7XuH2UcnwvNR+uQFwSrRqa EczX2V6iIy2CITXKg5Yvg12yn09gTmafuoIyKoU16XvC3aZQQ2Bn3LO2sRP0j/NuMD9GlO37 pHCVRpI2DPxFE39TMm1PLbHnDG8+lZql+dpNwWw8dDaRgyXx2Le542CcTBT52VCeeWDtqd2M wOr4LioYlfGfAqmwcwucBdTEBUxklQaOR3VbJQx6ntI2oDOBlNGvjnVDzZe+iREd5l40l+Oj TaiWvBGXkv6OI+wx5TFPp+BM6ATU+6UzFRTUWbj+LqVA/JMqYHQp04Y4H5GtjbHCa8abRvBw IKEvpwTyWZlfXPtp8gRlNmxYn6gQlTyEZAWodXwE7CE+KxNnq7bPHeLvrSn8bLNK682PoTGr 0Y00bguYLfyvEwuDYek1/h9YSXtHaCR3CEj4LU1B561G1j7FVaeYbX9bKBAoy/GxAW8J5O1n mmw7FnkSHuwO/QDe0COoO0QZ620Cf9IBWYHW4m2M2yh5981lUaiMcNM2kPgsJFYloFo2XGn6 lWU9BrWjEoNDhHZtF+yaPEuwjZo6x/3E2Tu3E5Jj0VpVcE9U1Zq/fquDY79l2RJn5ENogOs5 +Pi0GjVpEYQVWfm0PTCxNPOzOzGR4QB3BNFvABEBAAGJAiUEGAEIAA8FAlWjfaECGwwFCQlm AYAACgkQvWpQHLeLfCZqGxAAlWBWVvjU6xj70GwengiqYZwmW1i8gfS4TNibQT/KRq0zkBnE wgKwXRbVoW38pYVuGa5x/JDQMJDrLAJ0wrCOS3XxbSHCWOl/k2ZD9OaxUeXq6N+OmGTzfrYv PUvWS1Hy04q9AD1dIaMNruZQmvnRfkOk2UDncDIg0166/NTHiYI09H5mpWGpHn/2aT6dmpVw uoM9/rHlF5s5qAAo95tZ0QW2BtIceG9/rbYlL57waSMPF49awvwLQX5RhWoF8mPS5LsBrXXK hmizIsn40tLbi2RtWjzDWgZYitqmmqijeCnDvISN4qJ/nCLO4DjiSGs59w5HR+l0nwePDhOC A4RYZqS1e2Clx1VSkDXFpL3egabcIsqK7CZ6a21r8lXVpo4RnMlQsmXZTnRx4SajFvX7PrRg /02C811fLfh2r5O5if8sKQ6BKKlHpuuioqfj/w9z3B0aQ71e4n1zNJBO1kcdznikPLAbr7jG gkBUXT1yJiwpTfRQr5y2Uo12IJsKxohnNFVYtK8X/R6S0deKPjrZWvAkllgIPcHjMi2Va8yw KTj/JgcpUO5KN906Pf7ywZISe7Kbcc/qnE0YjPPSqFOvoeZvHe6EZCMW9+xZsaipvlqpByQV UHnVg09K9YFvjUBsBPdC8ef6YwgfR9o6AnPmxl0oMUIXkCCC5c99fzJY/k+JAq0EGAEIACAW IQS/HfwKVo8F95V1cJC9alAct4t8JgUCWwqKhgIbAgCBCRC9alAct4t8JnYgBBkWCAAdFiEE FMMcSshOZf56bfAEYhBsURv0pdsFAlsKioYACgkQYhBsURv0pdvELgD/U+y3/hsz0bIjMQJY 0LLxM/rFY9Vz1L43+lQHXjL3MPsA/1lNm5sailsY7aFBVJxAzTa8ZAGWBdVaGo6KCvimDB8G 7joP/jx+oGOmdRogs7mG//H+w9DTnBfPpnfkeiiokGYo/+huWO5V0Ac9tTqZeFc//t/YuYJn wWvS0Rx+KL0fT3eh9BQo47uF4yDiZIiWLNh4Agpup1MUSVsz4MjD0lW6ghtnLcGlIgoVHW0v tPW1m9jATYyJSOG/MC1iDrcYcp9uVYn5tKfkEeQNspuG6iSfS0q3tajPKnT1nJxMTxVOD2RW EIGfaV9Scrou92VD/eC+/8INRsiWS93j3hOKIAV5XRNINFqtzkagPYAP8r6wksjSjh01fSTB p5zxjfsIwWDDzDrqgzwv83CvrLXRV3OlG1DNUDYA52qJr47paH5QMWmHW5TNuoBX8qb6RW/H M3DzPgT+l+r1pPjMPfvL1t7civZUoPuNzoyFpQRj6TvWi2bGGMQKryeYksXG2zi2+avMFnLe lOxGdUZ7jn1SJ6Abba5WL3VrXCP+TUE6bZLgfw8kYa8QSXP3ysyeMI0topHFntBZ8a0KXBNs qqFCBWmTHXfwsfW0VgBmRtPO7eXVBybjJ1VXKR2RZxwSq/GoNXh/yrRXQxbcpZ+QP3/Tttsb FdKciZ4u3ts+5UwYra0BRuvb51RiZR2wRNnUeBnXWagJVTlG7RHBO/2jJOE6wrcdCMjs0Iiw PNWmiVoZA930TvHA5UeGENxdGqo2MvMdRJ54YaIR Message-ID: <291da5c4-16c0-28a4-9bd4-ba89f6f41051@gmail.com> Date: Sun, 13 Oct 2019 18:40:17 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <20191013120937.GK5653@amd> Content-Type: text/plain; charset=windows-1252 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/13/19 2:09 PM, Pavel Machek wrote: > Hi! > >> I must say I'm not a big fan of this change. >> It adds a bunch of code to the LED core and gives small >> functionality in a reward. It may also influence maximum >> software blinking rate, so I'd rather avoid calling >> regulator_enable/disable when timer trigger is set. >> >> It will of course require more code. >> >> Since AFAIR Pavel was original proponent of this change then >> I'd like to see his opinion before we move on to discussing >> possible improvements to this patch. > > Was I? See [0]: "For the record, I also believe regulator and enable gpio should be handled in the core." > Okay, this series looks quite confusing to me. First, 1/3 looks > "interesting" (would have to analyze it way more). > > Second, 3/3... So we have a LED driver _and_ a regulator? So yes, the > chip driving a LED is usually ... voltage/current regulator. What is > second regulator doing there? Is that a common setup? > > Best regards, > Pavel > > [0] https://lore.kernel.org/linux-leds/20190705100851.zn2jkipj4fxq5we6@devuan/ -- Best regards, Jacek Anaszewski