Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   <Narendra.K@dell.com>
To:     <Narendra.K@dell.com>
CC:     <linux-efi@vger.kernel.org>, <ard.biesheuvel@linaro.org>,
        <Mario.Limonciello@dell.com>, <geert@linux-m68k.org>,
        <mingo@kernel.org>, <tglx@linutronix.de>, <james.morse@arm.com>,
        <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v1] Ask user input only when CONFIG_X86 or
 CONFIG_COMPILE_TEST is set to y
Thread-Topic: [PATCH v1] Ask user input only when CONFIG_X86 or
 CONFIG_COMPILE_TEST is set to y
Thread-Index: AQHVgfgBvGXu4mhWM0KINjBW7iNITKdYlNQA
Date:   Sun, 13 Oct 2019 19:15:03 +0000
Message-ID: <20191013191450.GA2792@localhost.localdomain>
References: <20191013185643.GA2583@localhost.localdomain>
In-Reply-To: <20191013185643.GA2583@localhost.localdomain>
Accept-Language: en-US
Content-Language: en-US
user-agent: Mutt/1.10.1 (2018-07-13)
x-ms-exchange-messagesentrepresentingtype: 1
x-ms-exchange-transport-fromentityheader: Hosted
x-originating-ip: [10.143.242.75]
Content-Type: text/plain; charset="us-ascii"
Content-ID: <9C1695738C57CA4C95FC2D0A4BD65518@dell.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.95,1.0.8
 definitions=2019-10-13_09:2019-10-10,2019-10-13 signatures=0
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501
 adultscore=0 clxscore=1015 lowpriorityscore=0 impostorscore=0 spamscore=0
 malwarescore=0 suspectscore=0 phishscore=0 mlxlogscore=999 mlxscore=0
 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-1908290000 definitions=main-1910130192
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 bulkscore=0 mlxscore=0
 malwarescore=0 clxscore=1015 lowpriorityscore=0 mlxlogscore=999
 phishscore=0 priorityscore=1501 suspectscore=0 impostorscore=0 spamscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-1908290000
 definitions=main-1910130193
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Ard,

On Sun, Oct 13, 2019 at 06:57:05PM +0000, K, Narendra wrote:
> From: Narendra K <Narendra.K@dell.com>
>=20
> For the EFI_RCI2_TABLE kconfig option, 'make oldconfig' asks the user
> for input on platforms where the option may not be applicable. This patch
> modifies the kconfig option to ask the user for input only when CONFIG_X8=
6
> or CONFIG_COMPILE_TEST is set to y.
>=20
> Reported-by: Geert Uytterhoeven <geert@linux-m68k.org>
> Fix-suggested-by: Geert Uytterhoeven <geert@linux-m68k.org>
> Signed-off-by: Narendra K <Narendra.K@dell.com>
> ---
I missed mentioning the following details -

This patch is created on kernel version 5.4-rc2

Changes in v1:
- dropped following changes
	'depends on EFI' as it is implied
	'default n' as 'n' is the default if not mentioned
	splitting 'bool' to 'bool + prompt'
- added dependency on X86 || COMPILE_TEST
- added the 'Reported-by:' and 'Fix-suggested-by:' to give credit to=20
Geert Uytterhoeven who reported the issue and suggested the fix=20


>  drivers/firmware/efi/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
>=20
> diff --git a/drivers/firmware/efi/Kconfig b/drivers/firmware/efi/Kconfig
> index 178ee8106828..b248870a9806 100644
> --- a/drivers/firmware/efi/Kconfig
> +++ b/drivers/firmware/efi/Kconfig
> @@ -182,6 +182,7 @@ config RESET_ATTACK_MITIGATION
> =20
>  config EFI_RCI2_TABLE
>  	bool "EFI Runtime Configuration Interface Table Version 2 Support"
> +	depends on X86 || COMPILE_TEST
>  	help
>  	  Displays the content of the Runtime Configuration Interface
>  	  Table version 2 on Dell EMC PowerEdge systems as a binary
> --=20
> 2.18.1
>=20
> --=20
> With regards,
> Narendra K

--=20
With regards,
Narendra K=