Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Mon, 14 Oct 2019 05:12:38 +0200
From:   Sebastian Reichel <sre@kernel.org>
To:     Yizhuo Zhai <yzhai003@ucr.edu>, Beomho Seo <beomho.seo@samsung.com>
Cc:     linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
        Zhiyun Qian <zhiyunq@cs.ucr.edu>,
        Chengyu Song <csong@cs.ucr.edu>
Subject: Re: Potential uninitialized variables in power: supply:
 rt5033_battery:
Message-ID: <20191014031238.fqiytckizbrwntci@earth.universe>
References: <CABvMjLTicqk-ncY18j=UCZhCCugTVkPWKjkWZj9yEccUp3m8XQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="oguz6rorx46w3zrv"
Content-Disposition: inline
In-Reply-To: <CABvMjLTicqk-ncY18j=UCZhCCugTVkPWKjkWZj9yEccUp3m8XQ@mail.gmail.com>
User-Agent: NeoMutt/20180716
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


--oguz6rorx46w3zrv
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi,

On Thu, Oct 03, 2019 at 09:21:44PM -0700, Yizhuo Zhai wrote:
> drivers/power/supply/rt5033_battery.c:
>=20
> In function rt5033_battery_get_present(), variable "val" could be
> uninitialized if regmap_read() returns -EINVAL. However, "val" is
> used to decide the return value, which is potentially unsafe.
>=20
> Also, we cannot simply return -EINVAL in rt5033_battery_get_present()
> because it's not an acceptable return value.
>=20
> Thanks for your time to check this case.

Should be fine to just return false when regmap_read() fails.
Will you prepare a patch for that?

Thanks,

-- Sebastian

--oguz6rorx46w3zrv
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEE72YNB0Y/i3JqeVQT2O7X88g7+poFAl2j56MACgkQ2O7X88g7
+pqEHg/9EW8LYtH5bHaYEn8WLUM+DKorgimr8m5w9WQp4yw4fjl+WzteTp6MdUdm
0a00kYbFxFVwffJBoy28MS2tFG/4T8+NqdE7JQeFnatAERlA4FJhzpxB/etA/9IE
pbtETgg/r0qVLaLUKwlrqfWN0Dlo0g1t/QrKK7BaNWR2eZu0cGUI4O6k6s6C00u1
lyxXgUCkOgNEJSD4k664jcKIf3XboFZLanTghQ/uFerU9kH1gqCdSd51gxQ8eodu
KlS3Eb4qcSWgLwrZLMtg/ewPa6KK9r+MRyQEipyK2ZyLEohlVhf+ZQ72R6+YM08M
gmkr52vyzIVq673hPNGOVL9eUUQUKFLtJPDesQcdgPDlsEP2Vxs+EA7QEWIPTrSC
AORM4pFjzpLiG+0aXbeX9TSA9xG2h+vpJ0rBTqbtl8syz2447rbzrgXirhhVI/06
4H0xmQXq9w8ctSW/qk/gJci1djcogYGes9lM8iN0mH2B++sC44vwgiHTe1b5h6IZ
HeFDCzs8ZzIQR8Mk0aGYUMi/vCyhpBmVBO1JnZfecYmNAQ2XSlLu2yZeEsPh+jiW
kld/CRSenBhE6oMb0f95UI5TG6Q4oVpUYtyyTRKoIMXf3PJwY84VI004M3+YhcAb
e3EgTf2v8PSHF/s9pPBPurQ4bv/fkCNOFws++JsWDUTv23ekDE0=
=GwVf
-----END PGP SIGNATURE-----

--oguz6rorx46w3zrv--