Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Mon, 14 Oct 2019 05:31:08 +0200
From:   Sebastian Reichel <sre@kernel.org>
To:     Yizhuo <yzhai003@ucr.edu>
Cc:     csong@cs.ucr.edu, zhiyunq@cs.ucr.edu, linux-pm@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] power: supply: max17042_battery: fix the potential
 uninitialized use in max17042_write_verify_reg()
Message-ID: <20191014033108.jgb2c7yy3y46l6tp@earth.universe>
References: <20191002154406.8875-1-yzhai003@ucr.edu>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="uy5mgzfnhj6ksy7u"
Content-Disposition: inline
In-Reply-To: <20191002154406.8875-1-yzhai003@ucr.edu>
User-Agent: NeoMutt/20180716
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


--uy5mgzfnhj6ksy7u
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi,

On Wed, Oct 02, 2019 at 08:44:06AM -0700, Yizhuo wrote:
> In function max17042_write_verify_reg(), variable "read_value"
> could be uninitialized if regmap_read() fails. However,
> "read_value" is used to decide the control flow later in the if
> statement, which is potentially unsafe.
>=20
> Signed-off-by: Yizhuo <yzhai003@ucr.edu>
> ---

Instead of directly failing, integrate this into
the retry loop. Also the Signed-off-by and patch
author name looks incomplete.

Thanks,

-- Sebastian

>  drivers/power/supply/max17042_battery.c | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)
>=20
> diff --git a/drivers/power/supply/max17042_battery.c b/drivers/power/supp=
ly/max17042_battery.c
> index 0dfad2cf13fe..e6a2dacaa730 100644
> --- a/drivers/power/supply/max17042_battery.c
> +++ b/drivers/power/supply/max17042_battery.c
> @@ -486,12 +486,15 @@ static void max17042_external_power_changed(struct =
power_supply *psy)
>  static int max17042_write_verify_reg(struct regmap *map, u8 reg, u32 val=
ue)
>  {
>  	int retries =3D 8;
> -	int ret;
> +	int ret, err;
>  	u32 read_value;
> =20
>  	do {
>  		ret =3D regmap_write(map, reg, value);
> -		regmap_read(map, reg, &read_value);
> +		err =3D regmap_read(map, reg, &read_value);
> +		if (err)
> +			return err;
> +
>  		if (read_value !=3D value) {
>  			ret =3D -EIO;
>  			retries--;
> --=20
> 2.17.1
>=20

--uy5mgzfnhj6ksy7u
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIyBAEBCgAdFiEE72YNB0Y/i3JqeVQT2O7X88g7+poFAl2j6/sACgkQ2O7X88g7
+poCKw/3YVQktTEMrKN5htcAmBVhOdGo9C+Twnb/fTNXPQWEi4WV0683ghoVeNXd
fGiUAwqmDFkOMMKUY+NKITBJC4dAVrUXfBE0t/EwFKhU9JEy1P0DSwWHTIl3Yq+V
6GiQK9jjBdvbuJCSuzQXFUSlT1yfYr0ekeIsBYR1fnVhlNDuaDmJIZOB80cDA3m4
z17RsZlcFqAsaAAyaK3E5PrWQQJYM5vqeIXZqfOCspsXZfwTsTS7MM220/O6Er2Q
qaTgn5lBXTj0T4e2xLAfWbgKkuRROUf0wLwByY+ZYh9whRxe1N1582JzADn+ysMR
kHbU0pnxV/4LaCXWXq/nb2TO68FeM9cqwMLLJv1V2WpmyZM3bKvsLrF2JLQRmvuU
hP5vsMd/OR0fl8BFL0+G6ELzGuVKZ3ywMlcoCtVl5W0UUse9fDJHpc7O3STexomH
YMobOE5g574GDxmdNXtQXLRRDqP+9oX2ip3/WdNscfQtEh+laPAmFP0zkx4uiSne
TFWiyi6DimPAAuNY9xV2IkKZl06Mej3VHh2M8mocnVphXQRLTOm+BYIOzJXm985P
X1rbWC2aQLTg+NLY644YnJYcWKaw6YpQe/Rf+z/b2pdlbv/p3nVmcTB8h0ZcuCkX
89c3u/Nm03kK5+owvtWmTBiIOSJODw3a5eY1xExjF0gPFvfHxQ==
=brFC
-----END PGP SIGNATURE-----

--uy5mgzfnhj6ksy7u--