Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
IronPort-SDR: J4MdPp7ynyysT8SeG5/SUUfxtVN6F5xa0/N+4NaJTVMG1XYlQlAMdH0MmI7X0Ft8UhN1yUV1fY
 VdnWOtvqYCQwK0eVXgBDc8Lk/V3U3xEnlZr11/L4mUA/lAgme5zzoim+cdlgQ4uYhdwy/xWK6N
 BT6O56Z9tJ9AebPrh094cqom2RGDdMm6FEBybXwc9yf+Y3kulb11GRonfhJ6JGDEUJqmDHeNUg
 9q6pPFDGgVIBkWf9famD0vF3go1PfYZXEDnzoxoYa6FXPU1p4ogvKXgY/JOphaCpbikSFxz/iV
 /9s=
IronPort-PHdr: =?us-ascii?q?9a23=3AdvOCxBIj7ZbAyz6fUtmcpTZWNBhigK39O0sv0r?=
 =?us-ascii?q?FitYgRLfXxwZ3uMQTl6Ol3ixeRBMOHsqkC1LKd7P6ocFdDyK7JiGoFfp1IWk?=
 =?us-ascii?q?1NouQttCtkPvS4D1bmJuXhdS0wEZcKflZk+3amLRodQ56mNBXdrXKo8DEdBA?=
 =?us-ascii?q?j0OxZrKeTpAI7SiNm82/yv95HJbAhEmTSwbalwIRmqognctMgbipZ+J6gszR?=
 =?us-ascii?q?fEvmFGcPlMy2NyIlKTkRf85sOu85Nm7i9dpfEv+dNeXKvjZ6g3QqBWAzogM2?=
 =?us-ascii?q?Au+c3krgLDQheV5nsdSWoZjBxFCBXY4R7gX5fxtiz6tvdh2CSfIMb7Q6w4VS?=
 =?us-ascii?q?ik4qx2UxLjljsJOCAl/2HWksxwjbxUoBS9pxxk3oXYZJiZOOdicq/BeN8XQ3?=
 =?us-ascii?q?dKUMRMWCxbGo6zYIUPAOgBM+hWrIfzukUAogelCAmwGO/i0CNEimPq0aA41e?=
 =?us-ascii?q?kqDAHI3BYnH9ILqHnbrtT1NaYSUeCoy6nD0DbMb/NM1jf89YPFdRAgoPCMXb?=
 =?us-ascii?q?1qcMrd1VUjGg3eg1WNtYPlJSmZ2foQvGiG9udtU/+khW0/qwxpvDSj2sMhhp?=
 =?us-ascii?q?PKi48V0FzI6zl1zYUvKdGlTEN2ZdipG4ZKuS6ALYt5WMYiTnltuCY917IJp4?=
 =?us-ascii?q?a2fDMPyJQ73x7fbOGHc5SQ7hLjSumRJTB4iWpgeL2lhhay9VGsyun+VsWpyV?=
 =?us-ascii?q?pKoDdJn93Iu3wX2BzT7c+HSvR5/ki/wzqAywfT6uRcLUA1k6rUNYIhz6Yump?=
 =?us-ascii?q?YPtUnPBCz7lUXsgKOIakkp+fKk5/njb7jivpOcMpV7igD6MqQggMy/BuE4Px?=
 =?us-ascii?q?AOXmma+eSzzrzj8VHlTLhElfA2j7XWsIrAKcsFu6G5HhdZ0pw/5BanEzemzN?=
 =?us-ascii?q?MYkGEDLFJEfhKHkofoN0jNIP/mF/e/hUqjkDNwyvDYMb3uHI/NImLAkLj/Z7?=
 =?us-ascii?q?Z97VBTyA4pwdBY/ZJUBeJJHPWmYUL7vcfEDxY/eza5wu3nBdE1gpgEVEqMD7?=
 =?us-ascii?q?WfPaeUtkWHsLEBOe6JMb4UqjbgLLAX5/fvxSsoi18UfPHxhrMKY2r+E/h7dR?=
 =?us-ascii?q?bKKUHwi8sMRD9Z9jE1S/bn3RjbCWZe?=
MIME-Version: 1.0
References: <CABvMjLTicqk-ncY18j=UCZhCCugTVkPWKjkWZj9yEccUp3m8XQ@mail.gmail.com>
 <20191014031238.fqiytckizbrwntci@earth.universe>
In-Reply-To: <20191014031238.fqiytckizbrwntci@earth.universe>
From:   Yizhuo Zhai <yzhai003@ucr.edu>
Date:   Sun, 13 Oct 2019 20:55:40 -0700
Message-ID: <CABvMjLTc8BasrnsOtRvj5zcUiyc6Qj3+sxH2Ox704qRT2GWwmA@mail.gmail.com>
Subject: Re: Potential uninitialized variables in power: supply: rt5033_battery:
To:     Sebastian Reichel <sre@kernel.org>
Cc:     Beomho Seo <beomho.seo@samsung.com>, linux-pm@vger.kernel.org,
        linux-kernel@vger.kernel.org, Zhiyun Qian <zhiyunq@cs.ucr.edu>,
        Chengyu Song <csong@cs.ucr.edu>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Sebastian:

Thanks for your explanation and I will send the patch accordingly.

On Sun, Oct 13, 2019 at 8:12 PM Sebastian Reichel <sre@kernel.org> wrote:
>
> Hi,
>
> On Thu, Oct 03, 2019 at 09:21:44PM -0700, Yizhuo Zhai wrote:
> > drivers/power/supply/rt5033_battery.c:
> >
> > In function rt5033_battery_get_present(), variable "val" could be
> > uninitialized if regmap_read() returns -EINVAL. However, "val" is
> > used to decide the return value, which is potentially unsafe.
> >
> > Also, we cannot simply return -EINVAL in rt5033_battery_get_present()
> > because it's not an acceptable return value.
> >
> > Thanks for your time to check this case.
>
> Should be fine to just return false when regmap_read() fails.
> Will you prepare a patch for that?
>
> Thanks,
>
> -- Sebastian


-- 
Kind Regards,

Yizhuo Zhai

Computer Science, Graduate Student
University of California, Riverside