Received: by 2002:a5b:505:0:0:0:0:0 with SMTP id o5csp4147262ybp; Sun, 13 Oct 2019 23:20:19 -0700 (PDT) X-Google-Smtp-Source: APXvYqyekpGBYAw3wz96y6lIJohOghGHWT7ULlfokfi/LDn8fgE8IXE8qjNpwdEcUnRW6Yh0rrgG X-Received: by 2002:a17:906:5fc1:: with SMTP id k1mr27264097ejv.268.1571034019349; Sun, 13 Oct 2019 23:20:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1571034019; cv=none; d=google.com; s=arc-20160816; b=c7YonImN2DOhva35lDBzjkjVq1RFAa+3yqXyQ7/YNRocMLBhC62rkZVlK7tSruDahK kXHauRi6wP9L8X1nvUtmw5LmdpgG3l5TCNS+gzftIOIbHuCbzx6Tu5gSngF6kax2dypd 4uvfPytq0eYgCPmAoQpwiMYhULDqmIbCLMwDakP9CfSuo71BzPpmCEv4aM9gBpnXm7LK cJAT+iXRv+o3qmal4/G2OFW1shqm4OF+lQ1fhxaa/4m5FLToBihs7ldYbCqAZWnjZmkV nwsnfjuBzcoHzOxhH2k+S3O0OCX7T6/Sz5I9aQnhPiEnUfUvMB57t1jt1xczkbz9Wpal 0lyw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:in-reply-to :content-disposition:mime-version:references:subject:cc:to:from:date; bh=RaBOxapIirg3sTXgsEiXvcXPdt336I2rBIWtj/R9HyU=; b=qhKTYP2Aq8l9YYlrAUJT7lCwrxagD1IxEpkSuX0NCzs6Ndp4XpNuhuJBFsvDf75z5z 9GcHtypHYn4mnOz+Ttrlq+H5etrNzcnYBp+LZE5ixuN6MaNG1nfS3pl56+NDlCExcIS0 yXuyeEoSWNL3byUIUYAKt475P8eb/9hMrSHUvSSSPBZsT9kJQHEBeH0vOYlJADeohYX+ 6eI2ETdHH5YHFDQUsGSbCvZGlOarikqTMqXQfg9MhkWE7SfydhRUSSr2MwLbTHM0BT7j GpxzxPLsmdT5x8V+8W0gx3YXaNbnXgMmqtoOXeCHyOjMlJRvlc/tYLyMP+kESXozrkL9 BwDg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d6si10283544edx.85.2019.10.13.23.19.55; Sun, 13 Oct 2019 23:20:19 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730000AbfJNGS6 (ORCPT + 99 others); Mon, 14 Oct 2019 02:18:58 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:31646 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725936AbfJNGS5 (ORCPT ); Mon, 14 Oct 2019 02:18:57 -0400 Received: from pps.filterd (m0098404.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x9E67iP4104007 for ; Mon, 14 Oct 2019 02:18:56 -0400 Received: from e06smtp02.uk.ibm.com (e06smtp02.uk.ibm.com [195.75.94.98]) by mx0a-001b2d01.pphosted.com with ESMTP id 2vmjq99b77-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Mon, 14 Oct 2019 02:18:56 -0400 Received: from localhost by e06smtp02.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 14 Oct 2019 07:18:53 +0100 Received: from b06avi18878370.portsmouth.uk.ibm.com (9.149.26.194) by e06smtp02.uk.ibm.com (192.168.101.132) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Mon, 14 Oct 2019 07:18:49 +0100 Received: from d06av22.portsmouth.uk.ibm.com (d06av22.portsmouth.uk.ibm.com [9.149.105.58]) by b06avi18878370.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id x9E6Im7a40567074 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 14 Oct 2019 06:18:48 GMT Received: from d06av22.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 039EC4CCB7; Mon, 14 Oct 2019 06:18:48 +0000 (GMT) Received: from d06av22.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 6D2404CC9B; Mon, 14 Oct 2019 06:18:47 +0000 (GMT) Received: from osiris (unknown [9.152.212.85]) by d06av22.portsmouth.uk.ibm.com (Postfix) with ESMTPS; Mon, 14 Oct 2019 06:18:47 +0000 (GMT) Date: Mon, 14 Oct 2019 08:18:46 +0200 From: Heiko Carstens To: Johan Hovold Cc: Rob Clark , Sean Paul , Fabien Dessenne , Mauro Carvalho Chehab , Harald Freudenberger , David Airlie , Daniel Vetter , Vasily Gorbik , Christian Borntraeger , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linux-s390@vger.kernel.org, Greg Kroah-Hartman , stable , Martin Schwidefsky Subject: Re: [PATCH 4/4] s390/zcrypt: fix memleak at release References: <20191010131333.23635-1-johan@kernel.org> <20191010131333.23635-5-johan@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191010131333.23635-5-johan@kernel.org> X-TM-AS-GCONF: 00 x-cbid: 19101406-0008-0000-0000-00000321CE1C X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 19101406-0009-0000-0000-00004A40DEC6 Message-Id: <20191014061846.GA6834@osiris> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2019-10-14_05:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=5 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=927 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1908290000 definitions=main-1910140060 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Oct 10, 2019 at 03:13:33PM +0200, Johan Hovold wrote: > If a process is interrupted while accessing the crypto device and the > global ap_perms_mutex is contented, release() could return early and > fail to free related resources. > > Fixes: 00fab2350e6b ("s390/zcrypt: multiple zcrypt device nodes support") > Cc: stable # 4.19 > Cc: Harald Freudenberger > Cc: Martin Schwidefsky > Signed-off-by: Johan Hovold > --- > drivers/s390/crypto/zcrypt_api.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) Applied, thanks!