Received: by 2002:a5b:505:0:0:0:0:0 with SMTP id o5csp4190447ybp; Mon, 14 Oct 2019 00:18:27 -0700 (PDT) X-Google-Smtp-Source: APXvYqzZb9LpwyS3bw2jGOdKA0oGtBXRKkKVR/KFOXFFF3bqj2niwpZ9PGJdZgqu1JGDzU1gaJ1C X-Received: by 2002:a17:906:470d:: with SMTP id y13mr27159925ejq.241.1571037507832; Mon, 14 Oct 2019 00:18:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1571037507; cv=none; d=google.com; s=arc-20160816; b=BkmYc0pqDOwvv+SFY+O6buKJZ91Gr6UjZHgOgEYAbN5H8v1haJzv8+z8vgqzw18ThY 1QynGoYHxb6XKUTI3AGMRT9RGFr6OkVi65j2lxkQIlB0gviP/fGYtE84deHTkSCPbjJA ZH4/VtQbW3yN1bJ1zRfx95R+eRPuVY5Bi7nZIWGrOSX+X8mFklFI8oWDRvug09dGWfpy frwCRCuKpqCt2LeeZ4TWeMBQv1VC0qxHv43bT3saiWrsv/MsEwV3c5lRBtYIoWZJtFrq zzGgHDu++ndj8CabBSS85gbPFwGqBJ3xhC9Ff4eqbO4UuwLtNZo6HTahQq0vh2J8CV4e N9qQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:to:content-transfer-encoding:mime-version :message-id:date:subject:cc:from:dkim-signature; bh=EcHPy7pjRRYKhGqR1ifh85tAKii20mZHUVwEAWWq4vA=; b=X9+F2f7XbigOaQ29jSHg8fW6CyTWjsxeYlerY+1YBN7xW+UmpgE6FV9l5LUYUt724E gZ0s/If513/8P/SGAleWcIVW9MrPzF42dnEpFwp5guWXbWjST6f9Zzqx0VuwyZ0mfaic KF+mM0Euwsi/yNL97gMof6cYaPs6167bLDsYSYHx3Y7jvgJ69zicqyIHcnoFXo03UI4+ dd9W/Lkcqhyu+/BqRvg8hTimISPhCm9/ICDbV0aHTVM89FOSERR86VGIauCGCboW+6sG I/XEVwcbJk0al6CE+MLbpj4s7yi+DEzLLhPE80rlfmuNgaWdwGjizBmRTv8x6jRUXcF6 1yYw== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=DRzdaIn0; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id q20si11402032ejn.18.2019.10.14.00.18.04; Mon, 14 Oct 2019 00:18:27 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=DRzdaIn0; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730360AbfJNHP7 (ORCPT + 99 others); Mon, 14 Oct 2019 03:15:59 -0400 Received: from mail-pl1-f196.google.com ([209.85.214.196]:33281 "EHLO mail-pl1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730109AbfJNHP7 (ORCPT ); Mon, 14 Oct 2019 03:15:59 -0400 Received: by mail-pl1-f196.google.com with SMTP id d22so7623842pls.0; Mon, 14 Oct 2019 00:15:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=EcHPy7pjRRYKhGqR1ifh85tAKii20mZHUVwEAWWq4vA=; b=DRzdaIn0lZu/lCPx8qOsHxv2FJ25hNx8czlGr6HpoGiM7THWTHGbh7eyXp8vnBrVJ3 NyoZL/MfiHqr+EZHKDMFdwIS+XHXZGKEnj/z8aZjSrghZuzBE892zmGPjshGRwIbu8qM nc6rZB9RC+jcm6nAc3P2b7mee/bwX/THceu9SEHWUTGtwqGRsC9sdktMIRK2oyWapAyC 8zqkdyfB6pjTkmTdGPqXZ9L9QajddMUn9RdnHFlizPpbxuqS26FdgmmsYhHVvK28Vqd7 IPGiuwmWRg0PvFksgLR+OttjXm/JRAvCXRWz2hRPgvYSf9c7Fcj3SHgt7HbtaKOZ8kOM R/Ug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=EcHPy7pjRRYKhGqR1ifh85tAKii20mZHUVwEAWWq4vA=; b=W+oeVdwDCpqJfCHwR9Ukr5jQAHcyTRSPM0cEbuqhcREiEAgByjGPo7r+vqI2BtgELf GRYRdVU7yQw52vUP71sqfg5XFuNaxL3UJ7tqa1VxrtZIWmVnOdQSxU3qAA3OfGzqnImW l/HcNhMIzOPrDy6FGOQ969YW/xiFEqf0nqzVMA14aJicX23TxBZlqVwR7yE+LBDRld+5 Tl0b7PhuS9iwnS7R4XTJaQxueKuNQ0FneBE3btSNHJ36axj9mSwZDZFGvWy6P3W82e/i rbhm8Oc2EZyLq+KCyf/m/Wp/FT+/z9JgSa1JcUV2S61oQ9ic0voJLd/7zzqDkV9aWjQJ mzvw== X-Gm-Message-State: APjAAAU7JMo3E8RSawZ7L84dIvptfDZPcruMXf5vaX7sPtNpNaacturo 182k+UCjvHCdnHt9NGz6RTI= X-Received: by 2002:a17:902:d90e:: with SMTP id c14mr28542085plz.91.1571037358463; Mon, 14 Oct 2019 00:15:58 -0700 (PDT) Received: from suzukaze.ipads-lab.se.sjtu.edu.cn ([89.31.126.54]) by smtp.gmail.com with ESMTPSA id p88sm14971345pjp.22.2019.10.14.00.15.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 14 Oct 2019 00:15:57 -0700 (PDT) From: Chuhong Yuan Cc: Steve French , linux-cifs@vger.kernel.org, samba-technical@lists.samba.org, linux-kernel@vger.kernel.org, Chuhong Yuan Subject: [PATCH] cifs: Fix missed free operations Date: Mon, 14 Oct 2019 15:15:31 +0800 Message-Id: <20191014071531.12790-1-hslester96@gmail.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit To: unlisted-recipients:; (no To-header on input) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org cifs_setattr_nounix has two paths which miss free operations for xid and fullpath. Use goto cifs_setattr_exit like other paths to fix them. Fixes: aa081859b10c ("cifs: flush before set-info if we have writeable handles") Signed-off-by: Chuhong Yuan --- fs/cifs/inode.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/fs/cifs/inode.c b/fs/cifs/inode.c index 5dcc95b38310..df9377828e2f 100644 --- a/fs/cifs/inode.c +++ b/fs/cifs/inode.c @@ -2475,9 +2475,9 @@ cifs_setattr_nounix(struct dentry *direntry, struct iattr *attrs) rc = tcon->ses->server->ops->flush(xid, tcon, &wfile->fid); cifsFileInfo_put(wfile); if (rc) - return rc; + goto cifs_setattr_exit; } else if (rc != -EBADF) - return rc; + goto cifs_setattr_exit; else rc = 0; } -- 2.20.1