Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII;
 format=flowed
Content-Transfer-Encoding: 7bit
Date:   Mon, 14 Oct 2019 08:16:58 +0100
From:   Ben Dooks <ben.dooks@codethink.co.uk>
To:     paulmck@kernel.org
Cc:     linux-kernel@lists.codethink.co.uk,
        Josh Triplett <josh@joshtriplett.org>,
        Steven Rostedt <rostedt@goodmis.org>,
        Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
        Lai Jiangshan <jiangshanlai@gmail.com>,
        Joel Fernandes <joel@joelfernandes.org>, rcu@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] rcu: add declarations of undeclared items
In-Reply-To: <20191012044430.GG2689@paulmck-ThinkPad-P72>
References: <20191011170824.30228-1-ben.dooks@codethink.co.uk>
 <20191012044430.GG2689@paulmck-ThinkPad-P72>
Message-ID: <7acbcc9b901304f8f55cc1cece802785@codethink.co.uk>
User-Agent: Roundcube Webmail/1.3.10
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


On 2019-10-12 05:44, Paul E. McKenney wrote:
> On Fri, Oct 11, 2019 at 06:08:24PM +0100, Ben Dooks wrote:
>> The rcu_state, rcu_rnp_online_cpus and rcu_dynticks_curr_cpu_in_eqs
>> do not have declarations in a header. Add these to remove the
>> following sparse warnings:
>> 
>> kernel/rcu/tree.c:87:18: warning: symbol 'rcu_state' was not declared. 
>> Should it be static?
>> kernel/rcu/tree.c:191:15: warning: symbol 'rcu_rnp_online_cpus' was 
>> not declared. Should it be static?
>> kernel/rcu/tree.c:297:6: warning: symbol 
>> 'rcu_dynticks_curr_cpu_in_eqs' was not declared. Should it be static?
>> 
>> Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
> 
> Good catch!
> 
> However, these guys (plus one more) are actually used only in the
> kernel/rcu/tree.o translation unit, so they can be marked static.
> I made this change as shown below with your Reported-by.
> 
> Seem reasonable?

yes, thanks.