Received: by 2002:a5b:505:0:0:0:0:0 with SMTP id o5csp4200355ybp; Mon, 14 Oct 2019 00:30:55 -0700 (PDT) X-Google-Smtp-Source: APXvYqxjBOd+2F4r0m0vy0M1hN5suVNtMhJ6HFIthvmOqMVoRLc/82WMOmSMTixrDN0+kdT9AYwf X-Received: by 2002:a05:6402:21c7:: with SMTP id bi7mr27041117edb.205.1571038254911; Mon, 14 Oct 2019 00:30:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1571038254; cv=none; d=google.com; s=arc-20160816; b=IwhfzV6DMgljwGHFrjtAGKFIWKOzc/luyJZO7zVG7yvKTUBm4Iq8ViOJv9dknbqsCE VslYZovKE88vHrmTuEHQSCoj55y+ODKajHuN9U0LMUzFif18b47qeoSTZCB7gebIC+RH IXSG5X+GRpQpScDiIAXyl0nU9RDUIJiGICfPBqDsCu+CsQwoLn9SFYvRHHIERJhlia8O zkVR0KoMtr4S1tbbw8vlmi0NHJ4qYszUhxDgnqwxMphFQry7Xfvk93m+UNEjrdkT20/Y XVdnVzDuMZWN3IM3wkASIwBjjRHjn4VRChZGSYCwB8d4mty6fKlKQ/ph3mtyyA+bs5gZ 1LzQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-transfer-encoding:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=TWp5GZfXAuJiSjhN3OBoDFjXnsSknmpXMaB8oSLy2/g=; b=yfBPuTMeOzS8/3m4gMevutmMrviU3jCVf3PZ6N14cLzf60wtnBraUWHk4/Bh72c5lM XuhwpByt1iHDBgyk3YulbR1akdODhutsrsWsB1gT4Ak/A6HrRWyRYVsHbcq/cTlWyxyk 88VmomwhASABeICzxLpnI9p75hwAVyc7xgZZkSLMwO5NeVNSsiWmylOdYtAHFnHHaC3P 8LBgThmSvcYWefvzce8MViYIfJjmTE7ApWnJ8eb8RQAx+9t+axkIwmnhKDHaFnM9Dl/Q 6c9YHHeM/dIKvqvCDCGXTvsOuvNp1fV6EJyc4dkuTdjWdfhAlHs/Wc9gbEmDikXCYK9W +psA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=djTw1yvq; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id i12si11776872edb.133.2019.10.14.00.30.31; Mon, 14 Oct 2019 00:30:54 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=djTw1yvq; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728900AbfJNH13 (ORCPT + 99 others); Mon, 14 Oct 2019 03:27:29 -0400 Received: from mail-wr1-f66.google.com ([209.85.221.66]:38180 "EHLO mail-wr1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728883AbfJNH13 (ORCPT ); Mon, 14 Oct 2019 03:27:29 -0400 Received: by mail-wr1-f66.google.com with SMTP id y18so8898024wrn.5 for ; Mon, 14 Oct 2019 00:27:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=TWp5GZfXAuJiSjhN3OBoDFjXnsSknmpXMaB8oSLy2/g=; b=djTw1yvqaE4roQjMnJd2pe7/Kqo55OxZfnKi7PrNRYJCR3cP8VIuQ+Ac9RIOVFyZFp y8DgO8aeG3E0jLWMJirbmkXHnp+22ZU5W1/4Sle4LVjo00mv6/tkZp48vg8MI5G9bIk0 TCoQCvmiECFLPfeKKhGJp28J0iY48QU45qXb4pB/QNZPE6U9DnhZfKU6CxHO6JjKO3rl JU/dDVqgr4+2HcxH+cdizMhUCpJDhKygiK7bLOk4voo6GA//n/Ao9fvlWyra5pv/itdG zhv6DyuGCQs0uuzCLvO64pnitnLClO7bcHr2MJBC6baxfXkXaLZ0LOS2hBpoz1e103jy EHZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=TWp5GZfXAuJiSjhN3OBoDFjXnsSknmpXMaB8oSLy2/g=; b=Wo7rSWrqj2g4/IfBWAJnIFgB82Qmbt+X/G6llMi8qlUCqoNlo8X/NlkDiFcVlkbDnD XQd26dq0QCWhu6YdRJMzSTs/83DJAyvo+Ftj95YOadPKTyNcDOiKDoC/xICNYKNA8Ujs 6bDnhl3aWLr6K5p+j70a4WP7fLSd/211VmaQdzYTtAtgUn6f4XqmD++E3HP7qj+iKiPQ Y3mEs7M14ItdovEDUnnolpyZQSsL/swy0AjXK9eNzYgESwEO7SLM2SQGH6WFAADh3vC/ lnUS4SwFlzcWNhQTzStZ0hEFIamgyX6GuQIhCK3pRDjo2IfdEPoBz+jR50SaNuotRKRk 7V5A== X-Gm-Message-State: APjAAAVTbJ95f9vMQQSbeSrFVZrAx+TDnSqZ8rNlZ9E+6hc01WP5SMgk +Rtxjc/ITsTvjUtPY5a5L2lNsw== X-Received: by 2002:adf:dbd2:: with SMTP id e18mr11305190wrj.268.1571038047490; Mon, 14 Oct 2019 00:27:27 -0700 (PDT) Received: from dell ([2.27.167.11]) by smtp.gmail.com with ESMTPSA id e3sm16653686wme.39.2019.10.14.00.27.26 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 14 Oct 2019 00:27:26 -0700 (PDT) Date: Mon, 14 Oct 2019 08:27:25 +0100 From: Lee Jones To: Rasmus Villemoes Cc: Thierry Reding , Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , Daniel Thompson , Jingoo Han , Bartlomiej Zolnierkiewicz , linux-pwm@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 2/4] backlight: pwm_bl: eliminate a 64/32 division Message-ID: <20191014072725.GF4545@dell> References: <20191008120327.24208-1-linux@rasmusvillemoes.dk> <20191008120327.24208-3-linux@rasmusvillemoes.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20191008120327.24208-3-linux@rasmusvillemoes.dk> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 08 Oct 2019, Rasmus Villemoes wrote: > lightness*1000 is nowhere near overflowing 32 bits, so we can just use > an ordinary 32/32 division, which is much cheaper than the 64/32 done > via do_div(). > > Reviewed-by: Daniel Thompson > Signed-off-by: Rasmus Villemoes > --- > drivers/video/backlight/pwm_bl.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Applied, thanks. -- Lee Jones [李琼斯] Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog