Received: by 2002:a5b:505:0:0:0:0:0 with SMTP id o5csp4291773ybp; Mon, 14 Oct 2019 02:13:23 -0700 (PDT) X-Google-Smtp-Source: APXvYqxUm/0XIRJ611CLiJ4c3pAP49BQmzDu0Uork5aWq2bbkxpU0Rm+qDfkB4RzLir4EHwpsp1C X-Received: by 2002:a05:6402:149a:: with SMTP id e26mr26983074edv.123.1571044403007; Mon, 14 Oct 2019 02:13:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1571044402; cv=none; d=google.com; s=arc-20160816; b=tNQNhx68Ew3mJvf/iDNYeYvUOvVnUOsjZs+IrSnEaHAamjO6uKjFFkXjsW+QyxXKmd qy/JnL23MiPsX1rd+PpSyXV7PC65A9AyfyrvEsOPuZ5f2bf0ZYD1z9SJzWtppIXXsJPe 9wDR++DJfMjNHCTragP6xWoQ5UYvK+vkKq2cCohH9rDcCltGgS3ZxnXGW5846S4V4E3h +nEVapUdvaVi+CPW2MRblU6vZiFnOn9UTnSn1NQxTztqXIum1ScFotp6Y0KJN9F3kB69 OJw+p9xhATL8Igt9ijcdT+iQkpmxXYvPOKm0ir0UWHsJfEWc6kaiZ3p/WQu5FKM9y0Zo eSrw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from; bh=ITNiS8q6sr5yAwu9p7Fr+7C0eRh9rfv6hECX1kYNCGk=; b=dUsGKkGCjpQRYAhTtzmuIiKFmAlpqNRucZyIsm0QSpoE/WEgxJuiSMfIeS/aVf1fOz Q7BSzOK2w/nn9DceUpi5HBO0+J85FbbG+y4gBsfkJvp0EilzDI/niAbXreIB+5X8Y5mz I5VM7yfCO5ZSkGE36SluG2y5GHZ2cTFMkTcnhNqY39H1MD6lLs7/7b4eFpAJ5zYSL+3b Z3cXIlKaURXEMFShs7iXWbJFmcUG71csa8useAIDAWzTbowlhMcfaVRmLg9PAMDgdY1O o36ELreabDqRgBJHegPzMUztwAzJOkw6D17jjntlfYL09ABanalPdp9qpms6PUJjPh/L oK4A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id e14si12870903eda.104.2019.10.14.02.13.00; Mon, 14 Oct 2019 02:13:22 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730764AbfJNJJX (ORCPT + 99 others); Mon, 14 Oct 2019 05:09:23 -0400 Received: from mx2.suse.de ([195.135.220.15]:35990 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1730718AbfJNJJP (ORCPT ); Mon, 14 Oct 2019 05:09:15 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id C4700B65E; Mon, 14 Oct 2019 09:09:13 +0000 (UTC) From: Juergen Gross To: xen-devel@lists.xenproject.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Juergen Gross , Wei Liu , Paul Durrant , "David S. Miller" , stable@vger.kernel.org Subject: [PATCH 1/2] xen/netback: fix error path of xenvif_connect_data() Date: Mon, 14 Oct 2019 11:09:09 +0200 Message-Id: <20191014090910.9701-2-jgross@suse.com> X-Mailer: git-send-email 2.16.4 In-Reply-To: <20191014090910.9701-1-jgross@suse.com> References: <20191014090910.9701-1-jgross@suse.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org xenvif_connect_data() calls module_put() in case of error. This is wrong as there is no related module_get(). Remove the superfluous module_put(). Fixes: 279f438e36c0a7 ("xen-netback: Don't destroy the netdev until the vif is shut down") Cc: # 3.12 Signed-off-by: Juergen Gross --- drivers/net/xen-netback/interface.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/xen-netback/interface.c b/drivers/net/xen-netback/interface.c index 240f762b3749..103ed00775eb 100644 --- a/drivers/net/xen-netback/interface.c +++ b/drivers/net/xen-netback/interface.c @@ -719,7 +719,6 @@ int xenvif_connect_data(struct xenvif_queue *queue, xenvif_unmap_frontend_data_rings(queue); netif_napi_del(&queue->napi); err: - module_put(THIS_MODULE); return err; } -- 2.16.4