Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Received-SPF: TempError (protection.outlook.com: error in processing during
 lookup of arm.com: DNS Timeout)
From:   "james qian wang (Arm Technology China)" <james.qian.wang@arm.com>
To:     Liviu Dudau <Liviu.Dudau@arm.com>,
        "airlied@linux.ie" <airlied@linux.ie>,
        Brian Starkey <Brian.Starkey@arm.com>,
        "maarten.lankhorst@linux.intel.com" 
        <maarten.lankhorst@linux.intel.com>,
        "sean@poorly.run" <sean@poorly.run>,
        "imirkin@alum.mit.edu" <imirkin@alum.mit.edu>, nd <nd@arm.com>,
        Ayan Halder <Ayan.Halder@arm.com>,
        "Oscar Zhang (Arm Technology China)" <Oscar.Zhang@arm.com>,
        "Tiannan Zhu (Arm Technology China)" <Tiannan.Zhu@arm.com>,
        Mihail Atanassov <Mihail.Atanassov@arm.com>,
        "Jonathan Chai (Arm Technology China)" <Jonathan.Chai@arm.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "dri-devel@lists.freedesktop.org" <dri-devel@lists.freedesktop.org>,
        "Julien Yin (Arm Technology China)" <Julien.Yin@arm.com>,
        "Channing Chen (Arm Technology China)" <Channing.Chen@arm.com>,
        "Yiqi Kang (Arm Technology China)" <Yiqi.Kang@arm.com>,
        "Thomas Sun (Arm Technology China)" <thomas.Sun@arm.com>,
        "Lowry Li (Arm Technology China)" <Lowry.Li@arm.com>,
        Ben Davis <Ben.Davis@arm.com>
Subject: Re: [PATCH v2 1/4] drm/komeda: Add a new helper
 drm_color_ctm_s31_32_to_qm_n()
Thread-Topic: [PATCH v2 1/4] drm/komeda: Add a new helper
 drm_color_ctm_s31_32_to_qm_n()
Thread-Index: AQHVf/bDNAzoDxuLVU+by7UkFix6lKdZ2n6AgAARXYA=
Date:   Mon, 14 Oct 2019 09:58:20 +0000
Message-ID: <20191014095813.GA15227@jamwan02-TSP300>
References: <20191011054240.17782-1-james.qian.wang@arm.com>
 <20191011054240.17782-2-james.qian.wang@arm.com>
 <20191014085605.GF11828@phenom.ffwll.local>
In-Reply-To: <20191014085605.GF11828@phenom.ffwll.local>
Accept-Language: en-US
Content-Language: en-US
user-agent: Mutt/1.10.1 (2018-07-13)
Authentication-Results-Original: spf=none (sender IP is )
 smtp.mailfrom=james.qian.wang@arm.com; 
x-ms-exchange-messagesentrepresentingtype: 1
x-ms-publictraffictype: Email
X-MS-Office365-Filtering-Correlation-Id: d0309ae0-cb2f-40e8-b3e0-08d7508d11d1
X-MS-Office365-Filtering-HT: Tenant
X-MS-TrafficTypeDiagnostic: VE1PR08MB5229:|VE1PR08MB5229:|HE1PR0801MB1978:
X-MS-Exchange-PUrlCount: 3
x-ms-exchange-transport-forked: True
X-Microsoft-Antispam-PRVS: <HE1PR0801MB1978261AA5626ABE57C59D95B3900@HE1PR0801MB1978.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
x-ms-oob-tlc-oobclassifiers: OLM:4303;OLM:4303;
x-forefront-prvs: 01901B3451
X-Forefront-Antispam-Report-Untrusted: SFV:NSPM;SFS:(10009020)(4636009)(7916004)(39860400002)(136003)(376002)(346002)(396003)(366004)(189003)(199004)(478600001)(305945005)(7736002)(3846002)(966005)(256004)(6116002)(6636002)(99286004)(2906002)(14454004)(33716001)(8676002)(9686003)(1076003)(81156014)(6512007)(6306002)(81166006)(66066001)(25786009)(6246003)(33656002)(71200400001)(71190400001)(58126008)(316002)(6436002)(6486002)(64756008)(2501003)(5660300002)(2171002)(110136005)(6506007)(52116002)(26005)(76176011)(55236004)(386003)(102836004)(229853002)(66556008)(2201001)(476003)(446003)(11346002)(486006)(86362001)(186003)(66446008)(8936002)(66946007)(66476007)(921003)(1121003);DIR:OUT;SFP:1101;SCL:1;SRVR:VE1PR08MB5229;H:VE1PR08MB5006.eurprd08.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:1;A:1;
received-spf: None (protection.outlook.com: arm.com does not designate
 permitted sender hosts)
X-MS-Exchange-SenderADCheck: 1
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original: fnKNND30CDoY9OPkGf+wVKHjzfRvPBgVCI6gF/w1cow3qdVgWguiNKocdwP/86QexiiKJXp2EwZh4mbimnVzN2shxEtaf0pUxKl/TbSH4PWa73OrSPaQ8/i+0W3E86oYZSgSa4vM1k6GGbrn9Eydl8ArEevFDiUHYK0MMchHeXcmUL2kW+0KhZM9u0Ii7qp6kupxmGjRrZgqQy/7dL+N3LoL0TaKg893cMn85HF2Tj7WOGzOhOoDaeVdgnEbfGGGrHxf7BjUECUbL3jAWzzCFQH4YNi+HAEBqG95NHODywiwVZ6zR6pOViQqXqGx2df0/pejcuZPLwT4y05xQL8wjBgdSowkjbE4zcSaj+ZRybT/pq/lVJ6k41u78embbNrcaL7OVd6UEOye0Eg1vZjC8UbTZCK+biOO16ifmhbfKlTFytQv5UbnpNgkHQG1i7nwy2JhuOjVx/IKTFVkgKfnxg==
Content-Type: text/plain; charset="us-ascii"
Content-ID: <E14DA5AE9F7FDB4CA94BF9940278DB15@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR08MB5229
Original-Authentication-Results: spf=none (sender IP is )
 smtp.mailfrom=james.qian.wang@arm.com; 
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT030.eop-EUR03.prod.protection.outlook.com
X-Forefront-Antispam-Report: CIP:63.35.35.123;IPV:CAL;SCL:-1;CTRY:IE;EFV:NLI;SFV:NSPM;SFS:(10009020)(7916004)(4636009)(396003)(136003)(376002)(39860400002)(346002)(40434004)(189003)(199004)(33716001)(6636002)(305945005)(36906005)(587094005)(5660300002)(2906002)(316002)(486006)(126002)(110136005)(7736002)(2201001)(86362001)(58126008)(336012)(476003)(70586007)(1076003)(6512007)(5024004)(9686003)(6306002)(46406003)(2501003)(76130400001)(14444005)(229853002)(386003)(6506007)(446003)(102836004)(6486002)(63350400001)(70206006)(11346002)(81166006)(14454004)(2171002)(25786009)(6246003)(966005)(81156014)(50466002)(26826003)(478600001)(76176011)(22756006)(356004)(8746002)(66066001)(97756001)(26005)(23726003)(3846002)(186003)(6116002)(33656002)(47776003)(8936002)(99286004)(8676002)(921003)(1121003);DIR:OUT;SFP:1101;SCL:1;SRVR:HE1PR0801MB1978;H:64aa7808-outbound-1.mta.getcheckrecipient.com;FPR:;SPF:TempError;LANG:en;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;MX:1;A:1;
X-MS-Office365-Filtering-Correlation-Id-Prvs: 36981c5f-7317-4636-a4fb-08d7508d0b27
X-Forefront-PRVS: 01901B3451
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: OnSlGjKWzAvDC0M6eRr/8WWhprutXdBIKfyhkzJGbLvI0y6ijTv/Aclh0L+JxowcboeunTe8I74tArou/6tSnonpdRDhLNN5Q0xgixs5jExlx6CLrsT5KbB9ckMTEvFcGpo2QP/7rWseKcRb+Y0VcI8nycsW/rdTh1YV4c/XEkjs2Y/hTcoNayqhchwLDSd14Qa4Om03JuHGl1pk7TMjqmB6uYi8HUHba+PJCBYXf5vk4EuwgsW6X6h6G7/faBdX1CyS3j8/NMIX4tbTKr7/+Hk8nqeImvhxid5JLMILCW8kN2JKEA7JRBKMuvS5h8rXtzz3N7pQCS40MUj91LxXO7SxeyNej5+e462ncNLirH4PBWK/88tuwbw/CAV8N9pFYLaEubWkv7Cyoj3om8/GIkfIxPJOQthoPk7Ubib7lv3Qc239lkNELFNUHWStwTlnxapGZtdcpIfuJrj2DVl14w==
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Oct 2019 09:58:31.4440
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: d0309ae0-cb2f-40e8-b3e0-08d7508d11d1
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0801MB1978
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Oct 14, 2019 at 10:56:05AM +0200, Daniel Vetter wrote:
> On Fri, Oct 11, 2019 at 05:43:09AM +0000, james qian wang (Arm Technology=
 China) wrote:
> > Add a new helper function drm_color_ctm_s31_32_to_qm_n() for driver to
> > convert S31.32 sign-magnitude to Qm.n 2's complement that supported by
> > hardware.
> >
> > Signed-off-by: james qian wang (Arm Technology China) <james.qian.wang@=
arm.com>
> > ---
> >  drivers/gpu/drm/drm_color_mgmt.c | 23 +++++++++++++++++++++++
> >  include/drm/drm_color_mgmt.h     |  2 ++
> >  2 files changed, 25 insertions(+)
> >
> > diff --git a/drivers/gpu/drm/drm_color_mgmt.c b/drivers/gpu/drm/drm_col=
or_mgmt.c
> > index 4ce5c6d8de99..3d533d0b45af 100644
> > --- a/drivers/gpu/drm/drm_color_mgmt.c
> > +++ b/drivers/gpu/drm/drm_color_mgmt.c
> > @@ -132,6 +132,29 @@ uint32_t drm_color_lut_extract(uint32_t user_input=
, uint32_t bit_precision)
> >  }
> >  EXPORT_SYMBOL(drm_color_lut_extract);
> >
> > +/**
> > + * drm_color_ctm_s31_32_to_qm_n
> > + *
> > + * @user_input: input value
> > + * @m: number of integer bits
> > + * @n: number of fractinal bits
> > + *
> > + * Convert and clamp S31.32 sign-magnitude to Qm.n 2's complement.
>
> What's the Q meaning here? Also maybe specify that the higher bits above
> m+n are cleared to all 0 or all 1. Unit test would be lovely too. Anyway:

The Q used to represent signed two's complement.

For detail: https://en.wikipedia.org/wiki/Q_(number_format)

And it Q is 2's complement, so the value of higher bit equal to
sign-bit.
All 1 if it is negative
0 if it is positive.

James

> Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
>
> > + */
> > +uint64_t drm_color_ctm_s31_32_to_qm_n(uint64_t user_input,
> > +                                 uint32_t m, uint32_t n)
> > +{
> > +   u64 mag =3D (user_input & ~BIT_ULL(63)) >> (32 - n);
> > +   bool negative =3D !!(user_input & BIT_ULL(63));
> > +   s64 val;
> > +
> > +   /* the range of signed 2s complement is [-2^n+m, 2^n+m - 1] */
> > +   val =3D clamp_val(mag, 0, negative ? BIT(n + m) : BIT(n + m) - 1);
> > +
> > +   return negative ? 0ll - val : val;
> > +}
> > +EXPORT_SYMBOL(drm_color_ctm_s31_32_to_qm_n);
> > +
> >  /**
> >   * drm_crtc_enable_color_mgmt - enable color management properties
> >   * @crtc: DRM CRTC
> > diff --git a/include/drm/drm_color_mgmt.h b/include/drm/drm_color_mgmt.=
h
> > index d1c662d92ab7..60fea5501886 100644
> > --- a/include/drm/drm_color_mgmt.h
> > +++ b/include/drm/drm_color_mgmt.h
> > @@ -30,6 +30,8 @@ struct drm_crtc;
> >  struct drm_plane;
> >
> >  uint32_t drm_color_lut_extract(uint32_t user_input, uint32_t bit_preci=
sion);
> > +uint64_t drm_color_ctm_s31_32_to_qm_n(uint64_t user_input,
> > +                                 uint32_t m, uint32_t n);
> >
> >  void drm_crtc_enable_color_mgmt(struct drm_crtc *crtc,
> >                             uint degamma_lut_size,
> > --
> > 2.20.1
> >
> > _______________________________________________
> > dri-devel mailing list
> > dri-devel@lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/dri-devel
>
> --
> Daniel Vetter
> Software Engineer, Intel Corporation
> http://blog.ffwll.ch
IMPORTANT NOTICE: The contents of this email and any attachments are confid=
ential and may also be privileged. If you are not the intended recipient, p=
lease notify the sender immediately and do not disclose the contents to any=
 other person, use it for any purpose, or store or copy the information in =
any medium. Thank you.