Received: by 2002:a5b:505:0:0:0:0:0 with SMTP id o5csp4372340ybp; Mon, 14 Oct 2019 03:41:43 -0700 (PDT) X-Google-Smtp-Source: APXvYqyrOV9easIjEM3UKfOfpC3N24JbtwpgnQrAHgf4USJi9IEBQf0wjezn7LfZYuwIKrtCBytD X-Received: by 2002:a17:906:c801:: with SMTP id cx1mr28619388ejb.266.1571049702986; Mon, 14 Oct 2019 03:41:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1571049702; cv=none; d=google.com; s=arc-20160816; b=ZKnCsvYkqI+tfmmdp2PjdB5YsZVabAfv2eRKPxSPrsuh+eEIXh6HQd9wIjRcKLkR6t ZHFkK62nJkc/5VcPqcLo49fPZO5J/82EO3007rgWhxh5HyBuEJ62GlUfBu8OLf73FxTr TovOh5dLR5KVSa80+EIwu4LCcsXLzYDQOwDn+I8+rJ8vKdGB18oZrFM6+Kmji0LHX4Jg ZW15HeevnMz9I1YwEUNUyXTjB68eIcOnBd5cNJO469vVp+AF7jsDVBH2mL4kktgo1ZKX WBSS/cj5XIolkD3PqCZWGwXysTx+7Awl2VuPfNKZW/AIDTgjzHK0fhisT1M4vI2ccTDl SZvg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=az0lr6W/XdF3ZKiV6v82Lso/sJPweeXPsw4tU1pOQhI=; b=C+ey5jlsecClmoMUmfT6AaYXbRz8Vn4nBBrhZNV7RpPPZjv/J+KnG41/OtPLUdaKhg v7TK0BzEblSqDmTMuQ83EDLHNGlDhprZzspyBptzncd0UohXwnLxKhmoLY10y4jw175Y r8MCRf9LtfFKK0Dbd6Kw09wFEUZ8Loinqc5UP8nCE1Gun6uBIEojilVwqbU+4gjkNpZb P1URrHyl7+TkvHJcG16eIxdbxhK14coEKcsgD+kOOsZZVR7vFCqV/xd4wv5YW3IcvQdU rPN+VXbIgjl2sJgEal8IiSNlLrnrEzLR0n1QFi0+g4HWYPtlBECsVCNZLmdxuM+dmgMY KTIg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=LKh6mdXO; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id v2si10828189eju.3.2019.10.14.03.41.20; Mon, 14 Oct 2019 03:41:42 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=LKh6mdXO; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731547AbfJNKkk (ORCPT + 99 others); Mon, 14 Oct 2019 06:40:40 -0400 Received: from mail-pl1-f196.google.com ([209.85.214.196]:32786 "EHLO mail-pl1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731249AbfJNKkk (ORCPT ); Mon, 14 Oct 2019 06:40:40 -0400 Received: by mail-pl1-f196.google.com with SMTP id d22so7857820pls.0 for ; Mon, 14 Oct 2019 03:40:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=az0lr6W/XdF3ZKiV6v82Lso/sJPweeXPsw4tU1pOQhI=; b=LKh6mdXOmk1Rk/e+bErnSvIAIOp6qKXlfI3C1lJEoII64qJ7jqNokHlM0G8VjXu74V mZCe/pqp9WBormsTHQZiC4uYpPdrK5cBjz50YtFMud+JuZ7+4aXK9xu4v/Mnia4MC8Lr cKj0pPnkI/ylBVB9VYN4uSshawnA/I8X/dNUi6t72mG2gQ5lLGx0iEBeVs818pkyzDH8 oTn+WyW69mZUxGHiJjwYAvovZ3dcicMToVUdPGjNBtP/kb5YS1SWgPV8r50taCkHhihh ZvjP7TZNh8zEiR2s0xdMd1fqupur7Oxn1PPf+bJqm+g9sA3bcChuc3MlYeC0mteqNOQ3 oWmw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=az0lr6W/XdF3ZKiV6v82Lso/sJPweeXPsw4tU1pOQhI=; b=Qtz9OrPH+5vV95R8bTDA0Ht0xMpuwegQldiHVcdVeKBvAF5PkwdkYpZdJdbkc2Im+U T3rE1t5ZfKL1DuaS5XImkMcKuTlNTUV4j4N1Z7ccziP6L//In/QVm0Yuw3JOoQd2SV8b vXW5OIiZThErqJ3L9Ma6Fdoip2/EyPVEcnISbRZpsa+82kdV1tx1653qUS70SaITemZv +Ns9zZFtdnd+z6gZPtrBe/t+3PB9hO3ncEhCI6m60UPeFugj3IIyEoVUxEy00RcsP3lB 0QLpg/F+upGKemZxChATONC9yb3x216VC2MdpRqQkk4NPwdmQU3JSgWBELwLz40gOhd1 eu/w== X-Gm-Message-State: APjAAAXcKRK5TSOrylda3kDb1Xv9T8huFk+c0n4E+7Jfl5BCltT2VXcy M2pRCDKHRaqNExk+6kjvgr8= X-Received: by 2002:a17:902:465:: with SMTP id 92mr29494485ple.85.1571049640018; Mon, 14 Oct 2019 03:40:40 -0700 (PDT) Received: from localhost ([211.246.68.186]) by smtp.gmail.com with ESMTPSA id u68sm1119231pfu.39.2019.10.14.03.40.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 14 Oct 2019 03:40:39 -0700 (PDT) Date: Mon, 14 Oct 2019 19:38:23 +0900 From: Sergey Senozhatsky To: Vitaly Wool Cc: Linux-MM , Andrew Morton , Dan Streetman , Minchan Kim , Sergey Senozhatsky , LKML , Vlastimil Babka , Shakeel Butt , Henry Burns , Theodore Ts'o Subject: Re: [PATCH 2/3] zsmalloc: add compaction and huge class callbacks Message-ID: <20191014103823.GA42921@jagdpanzerIV> References: <20191010230414.647c29f34665ca26103879c4@gmail.com> <20191010231143.09e4a2bd52f331efd0c4baf9@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191010231143.09e4a2bd52f331efd0c4baf9@gmail.com> User-Agent: Mutt/1.12.2 (2019-09-21) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On (10/10/19 23:11), Vitaly Wool wrote: [..] > +static unsigned long zs_zpool_get_compacted(void *pool) > +{ > + struct zs_pool_stats stats; > + > + zs_pool_stats(pool, &stats); > + return stats.pages_compacted; > +} So zs_pool_stats() can become static? -ss