Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Robert Richter <rrichter@marvell.com>
To:     Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
CC:     Borislav Petkov <bp@alien8.de>, Tony Luck <tony.luck@intel.com>,
        "James Morse" <james.morse@arm.com>,
        "linux-edac@vger.kernel.org" <linux-edac@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 12/19] EDAC: Store error type in struct
 edac_raw_error_desc
Thread-Topic: [PATCH 12/19] EDAC: Store error type in struct
 edac_raw_error_desc
Thread-Index: AQHVf6jbve5vRxDO20qtSKMm5w5VjadVRSSAgATFvAA=
Date:   Mon, 14 Oct 2019 11:47:12 +0000
Message-ID: <20191014114704.yyemipcregxghrox@rric.localdomain>
References: <20191010202418.25098-1-rrichter@marvell.com>
 <20191010202418.25098-13-rrichter@marvell.com>
 <20191011075412.03458c3e@coco.lan>
In-Reply-To: <20191011075412.03458c3e@coco.lan>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-messagesentrepresentingtype: 1
x-originating-ip: [31.208.96.227]
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 8f17d8f9-9e77-4168-07c9-08d7509c4049
x-ms-traffictypediagnostic: MN2PR18MB2573:
x-microsoft-antispam-prvs: <MN2PR18MB25731D1819FB52889BA30213D9900@MN2PR18MB2573.namprd18.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:8882;
x-forefront-prvs: 01901B3451
x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(4636009)(136003)(39850400004)(366004)(346002)(376002)(396003)(199004)(189003)(6246003)(66946007)(6486002)(71190400001)(6512007)(86362001)(9686003)(66476007)(3846002)(256004)(6116002)(66556008)(3716004)(76176011)(71200400001)(7736002)(8936002)(81156014)(14454004)(8676002)(52116002)(81166006)(4326008)(305945005)(25786009)(64756008)(99286004)(66446008)(6436002)(186003)(1076003)(2906002)(66066001)(229853002)(5660300002)(476003)(11346002)(446003)(4744005)(486006)(478600001)(316002)(102836004)(6506007)(386003)(54906003)(53546011)(26005);DIR:OUT;SFP:1101;SCL:1;SRVR:MN2PR18MB2573;H:MN2PR18MB3408.namprd18.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1;MX:1;
received-spf: None (protection.outlook.com: marvell.com does not designate
 permitted sender hosts)
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: ePDyTIpDGMKnRHWXoi+m+Jz954bfkwLKz0lejF4SSp3XC1BLJkVQjc4Q7SAM9puKiG7631Ou+wW0AEaOp4QLg9YEzBk7Bm4GOV/EfZgiklNalr1aG9cmquq2gPGMv6xd2ajNpjPdWBc9M+zyOAMgRz8o86kn6a6FgrAjq5Omk73Sd0jnHP5KMFQ8y5cTBkbnsHAKimGJuu1y4tMsM/lSO0cAXLMNzjdZb6KTqUu1U5g4+IzmxGfdb/N9RMlUCI3ua0cq9MJYtuXarlS2W3sVTc2k5EnXzCnH+AHVB+zNUtuVDyp3hKU8y28hTkXPBhMvJNyug0iPgQfRvkWZD1UN+uh618DHhuTy5vmdDk7jiLEhcryfmR8akVKYT2jJJnSO7VivPbUg0DTYv0TPfeu2PHZKQ6qxb2/uooXDQUdjy3I=
x-ms-exchange-transport-forked: True
Content-Type: text/plain; charset="us-ascii"
Content-ID: <4137A5AE7585544B9A91F32F1BBACFF3@namprd18.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 8f17d8f9-9e77-4168-07c9-08d7509c4049
X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Oct 2019 11:47:12.2231
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: L9ZNsYpjzysRwKLBIJIvlAqs0NR68DuPbVmy4U/OqB90Y3jTFKt41RD4/u6p3AaLLUG9ls79HRhW+oWQhy0YFw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR18MB2573
X-OriginatorOrg: marvell.com
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.95,1.0.8
 definitions=2019-10-14_07:2019-10-11,2019-10-14 signatures=0
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 11.10.19 07:54:19, Mauro Carvalho Chehab wrote:
> Em Thu, 10 Oct 2019 20:25:29 +0000
> Robert Richter <rrichter@marvell.com> escreveu:
>=20
> > Store the error type in struct edac_raw_error_desc. This makes the
> > type parameter of edac_raw_mc_handle_error() obsolete.
>=20
> I don't see much gain on this change, but whatever works best for
> ghes.

The error type clearly describes the error. It makes sense to keep it
in struct edac_raw_error_desc as the function interface of
edac_raw_mc_handle_error() becomes easier. There is no reason to have
a function argument for the type while all other error data is in
edac_raw_error_desc.

This change might look trivial, but this series contains many small
changes like this and in the end there is a reasonable change of the
function that describes it much better:

void edac_raw_mc_handle_error(struct edac_raw_error_desc *e,
                          struct dimm_info *dimm);

... that reads as handle error described in e that affects this dimm.

-Robert