Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Mon, 14 Oct 2019 21:06:09 +0530
From:   Nishad Kamdar <nishadkamdar@gmail.com>
To:     Andrew Lunn <andrew@lunn.ch>, Vladimir Oltean <olteanv@gmail.com>
Cc:     Vivien Didelot <vivien.didelot@gmail.com>,
        Florian Fainelli <f.fainelli@gmail.com>,
        "David S. Miller" <davem@davemloft.net>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Joe Perches <joe@perches.com>,
        Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= 
        <u.kleine-koenig@pengutronix.de>, netdev <netdev@vger.kernel.org>,
        lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] net: dsa: sja1105: Use the correct style for SPDX
 License Identifier
Message-ID: <20191014153607.GA3324@nishad>
References: <20191012123938.GA6865@nishad>
 <CA+h21hr=Wg7ydqcTLk85rrRGhx_LCxu2Ch3dWCt1-d1XtPaAcA@mail.gmail.com>
 <20191014130016.GD19861@lunn.ch>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20191014130016.GD19861@lunn.ch>
User-Agent: Mutt/1.9.4 (2018-02-28)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, Oct 14, 2019 at 03:00:16PM +0200, Andrew Lunn wrote:
> On Mon, Oct 14, 2019 at 01:46:26PM +0300, Vladimir Oltean wrote:
> > Hi Nishad,
> > 
> > On Sat, 12 Oct 2019 at 15:39, Nishad Kamdar <nishadkamdar@gmail.com> wrote:
> > >
> > > This patch corrects the SPDX License Identifier style
> > > in header files related to Distributed Switch Architecture
> > > drivers for NXP SJA1105 series Ethernet switch support.
> > > For C header files Documentation/process/license-rules.rst
> > > mandates C-like comments (opposed to C source files where
> > > C++ style should be used)
> > >
> > > Changes made by using a script provided by Joe Perches here:
> > > https://lkml.org/lkml/2019/2/7/46.
> > >
> > > Suggested-by: Joe Perches <joe@perches.com>
> > > Signed-off-by: Nishad Kamdar <nishadkamdar@gmail.com>
> > > ---
> > 
> > Your commit message has nothing to do with what you're fixing, but
> > whatever. The SPDX identifiers _are_ using C-like comments.
> 
> Agreed. Please fix the commit message, and maybe make the script
> generating the commit message, so future uses of it will get the
> message correct.
> 
> Thanks
> 	Andrew
Hello Andrew and Vladimir,

I understand your comments.
I will change the commit message in the next version of the patch.

Thanks for the review.

Regards,
Nishad