Received: by 2002:a5b:505:0:0:0:0:0 with SMTP id o5csp4749101ybp; Mon, 14 Oct 2019 09:25:17 -0700 (PDT) X-Google-Smtp-Source: APXvYqwTKgfWiCpO6LQvHlC1iumm2VsJaH+b69kaOPCs1bZNWe3cnO7gIvLg6MQi5lZ/x9UNuOsO X-Received: by 2002:a17:906:1fc8:: with SMTP id e8mr25803844ejt.86.1571070317287; Mon, 14 Oct 2019 09:25:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1571070317; cv=none; d=google.com; s=arc-20160816; b=BthxQLts58AOB+jhA8JjGyPE+hHlGEC6NglWy9Q2pIVCZUQs9UIhiS/aSKpollvMY6 TJK9l8aMN6F8+zUT29hifeibgIhg5cnZf8hcIOlhJ6EMDs9O5GjO9cay7ttySyFRctSf mcTovZfg5hAAbY2pJdt+rhRhDLWnHv+pFWqdnbMtEEQOsn112JlesKrjIz4ZXHaSxjMF 4s3tuMtVWTqrSj5RpHsIgzrpOn+q7bqkF7sRzHDpnmrGg+kysJpN39zcE6qrK1FEQcJI qUeAfTHq25fQV/K/FdKLllWlXxv+TRTvTlSwc5UuMBtmwlFasDPJ+Tv/wZAdGr9N3fzP vkcw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=Ma3cM/u+MgRe+wp5SBaXxS+fTjKOETR2+RBeu4LVzFk=; b=VDJrueXKpjs0alb3EytEWM96O/6qfOT5nGxv6/zuk6kKxkmsA7uM3sJHmoHTArPz+a 1LtE56XkcSRzHpsfg+AXzIJ+iQJQLrfmcZHlW9vynxYCsCsqPoS3+X59Y0m2jgQXqe05 R8dRXXsiCg129TirS38S94+71IS9n8t9xnTZPNbhRtqnRDH9tf7JOUIld04ICCnZquLl L7QbD08Zt3KuieFq3+UoC5qT6WEMKaNiUDSVEfdrQO+5I/BwklOdQr+WQO7gfTaJecCL 5Uekn4WlKrti7OUFXC5IH7+C5OtBFQfv7FWvmav3B3B5gI91qCebOLhZhcCQAiJ5m6o0 m6tQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id dd8si11490619ejb.36.2019.10.14.09.24.54; Mon, 14 Oct 2019 09:25:17 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729903AbfJNPtA (ORCPT + 99 others); Mon, 14 Oct 2019 11:49:00 -0400 Received: from mx1.redhat.com ([209.132.183.28]:33996 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727038AbfJNPtA (ORCPT ); Mon, 14 Oct 2019 11:49:00 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 282BB3079B77; Mon, 14 Oct 2019 15:49:00 +0000 (UTC) Received: from krava.redhat.com (unknown [10.40.205.218]) by smtp.corp.redhat.com (Postfix) with ESMTP id CF88D5D9C9; Mon, 14 Oct 2019 15:48:57 +0000 (UTC) From: Jiri Olsa To: Arnaldo Carvalho de Melo Cc: lkml , Ingo Molnar , Namhyung Kim , Alexander Shishkin , Peter Zijlstra , Michael Petlan , Andi Kleen Subject: [PATCH] perf jvmti: Link in tools/lib/ctype.o Date: Mon, 14 Oct 2019 17:48:56 +0200 Message-Id: <20191014154856.25306-1-jolsa@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.41]); Mon, 14 Oct 2019 15:49:00 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The libperf-jvmti.so links already with tools/lib/string.o to use strlcpy. However the string.o depends on ctype.o so we need to link it in as well. Fixes: 79743bc927f6 ("perf jvmti: Link against tools/lib/string.o to have weak strlcpy()") Link: http://lkml.kernel.org/n/tip-zitavtnkcu2guqwfgtp7n7bg@git.kernel.org Signed-off-by: Jiri Olsa --- tools/perf/jvmti/Build | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/tools/perf/jvmti/Build b/tools/perf/jvmti/Build index 1e148bbdf820..7de7f90bf3fb 100644 --- a/tools/perf/jvmti/Build +++ b/tools/perf/jvmti/Build @@ -3,6 +3,7 @@ jvmti-y += jvmti_agent.o # For strlcpy jvmti-y += libstring.o +jvmti-y += libctype.o CFLAGS_jvmti = -fPIC -DPIC -I$(JDIR)/include -I$(JDIR)/include/linux CFLAGS_REMOVE_jvmti = -Wmissing-declarations @@ -15,3 +16,7 @@ CFLAGS_libstring.o += -Wno-unused-parameter -DETC_PERFCONFIG="BUILD_STR($(ETC_PE $(OUTPUT)jvmti/libstring.o: ../lib/string.c FORCE $(call rule_mkdir) $(call if_changed_dep,cc_o_c) + +$(OUTPUT)jvmti/libctype.o: ../lib/ctype.c FORCE + $(call rule_mkdir) + $(call if_changed_dep,cc_o_c) -- 2.21.0