Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20191014125302.21479-1-anders.roxell@linaro.org>
In-Reply-To: <20191014125302.21479-1-anders.roxell@linaro.org>
From:   Sean Paul <sean@poorly.run>
Date:   Mon, 14 Oct 2019 13:24:14 -0400
Message-ID: <CAMavQKKYzj_jbP2UTMe1O6K5GYxxM1buB=iWC8vFZU5e0vTGGA@mail.gmail.com>
Subject: Re: [PATCH] drm/dp-mst: remove unused variable
To:     Anders Roxell <anders.roxell@linaro.org>,
        Manasi Navare <manasi.d.navare@intel.com>
Cc:     Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
        Maxime Ripard <mripard@kernel.org>,
        Dave Airlie <airlied@linux.ie>,
        Daniel Vetter <daniel.vetter@ffwll.ch>,
        dri-devel <dri-devel@lists.freedesktop.org>,
        LKML <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, Oct 14, 2019 at 8:53 AM Anders Roxell <anders.roxell@linaro.org> wr=
ote:
>
> The variable 'dev' is no longer used and the compiler rightly complains
> that it should be removed.
>
> ../drivers/gpu/drm/drm_dp_mst_topology.c: In function =E2=80=98drm_atomic=
_get_mst_topology_state=E2=80=99:
> ../drivers/gpu/drm/drm_dp_mst_topology.c:4187:21: warning: unused variabl=
e =E2=80=98dev=E2=80=99 [-Wunused-variable]
>   struct drm_device *dev =3D mgr->dev;
>                      ^~~
>
> Rework to remove the unused variable.
>
> Fixes: 83fa9842afe7 ("drm/dp-mst: Drop connection_mutex check")
> Signed-off-by: Anders Roxell <anders.roxell@linaro.org>

Hi Anders,
Thank you for your patch! Manasi has already posted a patch for this:
https://patchwork.freedesktop.org/patch/335358/

It's reviewed, so we're just waiting for it to land.

Sean


> ---
>  drivers/gpu/drm/drm_dp_mst_topology.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/drm_dp_mst_topology.c b/drivers/gpu/drm/drm_=
dp_mst_topology.c
> index 9364e4f42975..9cccc5e63309 100644
> --- a/drivers/gpu/drm/drm_dp_mst_topology.c
> +++ b/drivers/gpu/drm/drm_dp_mst_topology.c
> @@ -4184,8 +4184,6 @@ EXPORT_SYMBOL(drm_dp_mst_topology_state_funcs);
>  struct drm_dp_mst_topology_state *drm_atomic_get_mst_topology_state(stru=
ct drm_atomic_state *state,
>                                                                     struc=
t drm_dp_mst_topology_mgr *mgr)
>  {
> -       struct drm_device *dev =3D mgr->dev;
> -
>         return to_dp_mst_topology_state(drm_atomic_get_private_obj_state(=
state, &mgr->base));
>  }
>  EXPORT_SYMBOL(drm_atomic_get_mst_topology_state);
> --
> 2.20.1
>