Received: by 2002:a5b:505:0:0:0:0:0 with SMTP id o5csp5232839ybp; Mon, 14 Oct 2019 18:08:41 -0700 (PDT) X-Google-Smtp-Source: APXvYqwSxTOpunr0BVaCquA+UB5do6MFTuZNzLn0PCqgtwFM79+x4ytaXVqgf/+JAzGPkh6kCirs X-Received: by 2002:a17:906:7e17:: with SMTP id e23mr24289146ejr.205.1571101721677; Mon, 14 Oct 2019 18:08:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1571101721; cv=none; d=google.com; s=arc-20160816; b=Jjtvq2ZtbmKsWsPFGxCthqRdfw81cyDAc0OV8mT6D8Eu6NHFWBDYbu3hVZnf/K++Ce JfCULkTqpcJ5oNBFwwJGx9QiwA6BmgsZXPcmNQxLGbPozlIfyJpbNx7EL8l+D0jrRMA2 BZMBgWLDIJ+yvRCkBKzzympRBU1gfLONOhy7QF3ievgwpW4i8Lo0YRYbbDuiz1Lr9iSD dHHfpDfC6D8pM2KJ75hncu3i7zm83gUFQ9vyfGTLqUbeJihl0GdmQ1E2kkgtTKUxBBSD UPh/ApRhG6SW79wRYblaBK4aVlcqzmuojRDdQT3q9THOUWTZEvzmUXEy8Dwh92XLRFRt 8HJw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:cc:to:subject :message-id:date:from:in-reply-to:references:mime-version :dkim-signature; bh=3qwTHsJQXtLByGWGmkMogTYtmXYBCZ8p7g4dCDAH2Hc=; b=HT/E7p/x7A8VhtRZb5JrXUO7psT/GJUQsUPC4V6gc372P0wJeG4wm7NIrOZEn6L1qC 78ZzkOaOd091a0R+hiZoJJE4uFPwWOkxLEmPk44IyOJMmkl8c96RNN5G07MT/E3KuK7u ic7piyzeP2eaF26834BB3/IWZaTTxUyDbBPaaNCC0qKnkfAM9FPkkHWoCT53c0o985GS kQRS4PfHvEGUvYHt+eceu6cgMmZTb8JHihS0EbuVShxid2nCT2Yrmq4DfFBmsqLVYYm6 NWPskpi4e62nd9UTHexmgOufiA1ceNL0WJcaIvDLWiNE1Z9UJ8bi2lV56C+ZQcYiiOva 9EYA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=GkNSjhP0; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id fx14si12078781ejb.268.2019.10.14.18.08.17; Mon, 14 Oct 2019 18:08:41 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=GkNSjhP0; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730104AbfJNVnZ (ORCPT + 99 others); Mon, 14 Oct 2019 17:43:25 -0400 Received: from mail-lj1-f195.google.com ([209.85.208.195]:32897 "EHLO mail-lj1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729054AbfJNVnY (ORCPT ); Mon, 14 Oct 2019 17:43:24 -0400 Received: by mail-lj1-f195.google.com with SMTP id a22so18098432ljd.0; Mon, 14 Oct 2019 14:43:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=3qwTHsJQXtLByGWGmkMogTYtmXYBCZ8p7g4dCDAH2Hc=; b=GkNSjhP0eZ80orHn4cAARxiyTXcvb5pPD7FRVCWSFff5/lJaJh7m0Eym/uVAhlJAK3 aOHaHKdueqDalt+cb9568WOvHFiduwq/KtHwrU6C7RUEO0UvH+kOatOoFvjlusem7ElO 4+eiy/B13KWx8QhR4CT9z8n/JZzaCtNEUWW8qB6UdWJqss3SHN/4IMdo8S2dyTVnsMqF xwGi1bJhpw2ugWX5wToPEFZTe3kTp9fijpoJ039D1UCsXOR83LYsj6ftvPMB3vEpo9oE MAuZ+SddrdhSAp9zO46QStgTyDk2WaXu4jbmygCQohW7F1sk3FGynVd9IdaF/UXvAQ+l qplQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=3qwTHsJQXtLByGWGmkMogTYtmXYBCZ8p7g4dCDAH2Hc=; b=p/qd/PizWgxx65FLuAeC6FIELa6ulIclu/RTDT+OlvGQ76yq4D+AZ1lsMHjrrmt7U5 HZrdBN7XJ6PaYXvfxm1ujgZuFQSCXIyWVDOlsFCQ+KsxApYP/kbIKn6aXwHnSnnV9UK6 j6jk+l7+GN+S30k7mNQMWrfq0A5agqTl1ZTnCqrqI21S05w81dlbGmET2p+f9kRQBmLZ VdgNj3YOJMGQmYjP3PpWeNVHkhZqWdJvEm+KMFvmXTGOM6F9gu0+kNn/gCJGe/NJ0hx5 RRsVWI6RE1upv4TAspSI9n1zq885YV+s2gnJmA93oCkFhrrOzfFmWMpI6z/DQS08nFRo FhEg== X-Gm-Message-State: APjAAAVmJ0t+nqCjmqHqsL4bBQH4fGIM3g6IhoThYqsN9nq0SPeQkDC9 8jiLLrjbHA2Am7fG6qx5IaWqBwlA9Q9sCYCyZc320hA= X-Received: by 2002:a2e:5354:: with SMTP id t20mr20223113ljd.227.1571089402725; Mon, 14 Oct 2019 14:43:22 -0700 (PDT) MIME-Version: 1.0 References: <20191014071531.12790-1-hslester96@gmail.com> In-Reply-To: <20191014071531.12790-1-hslester96@gmail.com> From: Pavel Shilovsky Date: Mon, 14 Oct 2019 14:43:11 -0700 Message-ID: Subject: Re: [PATCH] cifs: Fix missed free operations To: Chuhong Yuan Cc: Steve French , linux-cifs , samba-technical , Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org =D0=BF=D0=BD, 14 =D0=BE=D0=BA=D1=82. 2019 =D0=B3. =D0=B2 00:18, Chuhong Yua= n : > > cifs_setattr_nounix has two paths which miss free operations > for xid and fullpath. > Use goto cifs_setattr_exit like other paths to fix them. > > Fixes: aa081859b10c ("cifs: flush before set-info if we have writeable ha= ndles") > Signed-off-by: Chuhong Yuan > --- > fs/cifs/inode.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/fs/cifs/inode.c b/fs/cifs/inode.c > index 5dcc95b38310..df9377828e2f 100644 > --- a/fs/cifs/inode.c > +++ b/fs/cifs/inode.c > @@ -2475,9 +2475,9 @@ cifs_setattr_nounix(struct dentry *direntry, struct= iattr *attrs) > rc =3D tcon->ses->server->ops->flush(xid, tcon, &= wfile->fid); > cifsFileInfo_put(wfile); > if (rc) > - return rc; > + goto cifs_setattr_exit; > } else if (rc !=3D -EBADF) > - return rc; > + goto cifs_setattr_exit; > else > rc =3D 0; > } > -- > 2.20.1 > Looks good, thanks. Reviewed-by: Pavel Shilovsky The original patch was tagged for stable, so, it seems that this one should be tagged too. -- Best regards, Pavel Shilovsky