Received: by 2002:a5b:505:0:0:0:0:0 with SMTP id o5csp5248752ybp; Mon, 14 Oct 2019 18:29:00 -0700 (PDT) X-Google-Smtp-Source: APXvYqzbe1tcJEt+91aAq02SIf8G+RJzO/2ekDpfl83pJbsYeQppkg5/wNb/JIYKoXI25s6sfMF9 X-Received: by 2002:a50:fe0f:: with SMTP id f15mr30449962edt.89.1571102940737; Mon, 14 Oct 2019 18:29:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1571102940; cv=none; d=google.com; s=arc-20160816; b=QpKDeOkcCQOOP4/ddcDPAtRrst2aPnY9jlVEBvkdSw7uswvUOeaSjC6iur87FS3GB2 /7L7fBerbJ6nB0uQVpKrNBcySfiXeIA5/21XYva2U94oaeTumCCagyMCKvH1D5eWxPEw p+N9Q7KHUED+GTfbzi3AIlfhsq6BFHtWtA6XBY9fr7Vq95OVauTaI0T3tr9xVMQwfL6H F8Zc+oTBLv5HIuQh3mg5HIWCAB9kkyCXziRSe0tV1PBHNTxwmIBUguNzNXjcuakbxIAV RRDxj67bpiwb6gSr91152FGDnBFRGeNbnpGUkgU+gbHOxNVYpr0gWHIC7xVUxjo0gwGu GOEA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=vYbnvNh0mADC8dOP0guk5ib7BsKIgCUSNj79wqRzvhw=; b=ZRVdwPgLVcsh+jRHB2ZUeJKAXKhTN/Tpm4vpXuuq7uYiXPAU1gakgF6F2SVx4jnMvd 4XfrlTB+S5LcCUeVbBEC1dbNJF13vGb708D7WV3qgARPOZYaMV6RpOp/MAjiOIjCQrmH Tdgm01O0eANDbW30FQOVqhatEZ1qU4tEOdMikIjRvf7qGTZXWIrP/MIIISV6vbxErIwx xlZakruS2kvQJiXSSSIzwG9JgZIdfS372HGdCwgbR4xZ5LwJskiurP3AfjTtR/yyBEfn vwM3hDQu1GcXHsjnEnpsGj37o1EaZa4yuP12NRXHanLNrEFTeKp2iyHrI+Sk5Cpybd9+ Kwkw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=Ce2ekGcU; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 8si13934023edz.299.2019.10.14.18.28.37; Mon, 14 Oct 2019 18:29:00 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=Ce2ekGcU; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726292AbfJNXBz (ORCPT + 99 others); Mon, 14 Oct 2019 19:01:55 -0400 Received: from mail.kernel.org ([198.145.29.99]:52022 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726170AbfJNXBy (ORCPT ); Mon, 14 Oct 2019 19:01:54 -0400 Received: from localhost (unknown [69.71.4.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 952BD2133F; Mon, 14 Oct 2019 23:01:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1571094113; bh=sLP8EMOf/N7TokrONFrqX6afHamtSzogwgMj4ILkroY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Ce2ekGcUwC93LWPca74oS7cC+ApQ3uMMfWKQEU3S9Em7A4huSffnsw525WfIgrY6W 6i412yWgRW/yhieR4PxzCet2fhnC3ZUBFIibZTq1z1kkDSWPrUal4H9x7Vgt9398tP a9YQahkdSNClqRUHf3CEDT2g749jdt3I12oCcm2Y= From: Bjorn Helgaas To: Dexuan Cui Cc: "Rafael J . Wysocki" , Lorenzo Pieralisi , Michael Kelley , Sasha Levin , Haiyang Zhang , KY Srinivasan , Stephen Hemminger , olaf@aepfle.de, apw@canonical.com, jasowang@redhat.com, vkuznets@redhat.com, marcelo.cerri@canonical.com, jackm@mellanox.com, linux-pci@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-kernel@vger.kernel.org, driverdev-devel@linuxdriverproject.org, Bjorn Helgaas Subject: [PATCH 2/7] PCI/PM: Correct pci_pm_thaw_noirq() documentation Date: Mon, 14 Oct 2019 18:00:11 -0500 Message-Id: <20191014230016.240912-3-helgaas@kernel.org> X-Mailer: git-send-email 2.23.0.700.g56cf767bdb-goog In-Reply-To: <20191014230016.240912-1-helgaas@kernel.org> References: <20191014230016.240912-1-helgaas@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Bjorn Helgaas According to the documentation, pci_pm_thaw_noirq() did not put the device into the full-power state and restore its standard configuration registers. This is incorrect, so update the documentation to match the code. Signed-off-by: Bjorn Helgaas --- Documentation/power/pci.rst | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/Documentation/power/pci.rst b/Documentation/power/pci.rst index 0e2ef7429304..1525c594d631 100644 --- a/Documentation/power/pci.rst +++ b/Documentation/power/pci.rst @@ -600,17 +600,17 @@ using the following PCI bus type's callbacks:: respectively. -The first of them, pci_pm_thaw_noirq(), is analogous to pci_pm_resume_noirq(), -but it doesn't put the device into the full power state and doesn't attempt to -restore its standard configuration registers. It also executes the device -driver's pm->thaw_noirq() callback, if defined, instead of pm->resume_noirq(). +The first of them, pci_pm_thaw_noirq(), is analogous to pci_pm_resume_noirq(). +It puts the device into the full power state and restores its standard +configuration registers. It also executes the device driver's pm->thaw_noirq() +callback, if defined, instead of pm->resume_noirq(). The pci_pm_thaw() routine is similar to pci_pm_resume(), but it runs the device driver's pm->thaw() callback instead of pm->resume(). It is executed asynchronously for different PCI devices that don't depend on each other in a known way. -The complete phase it the same as for system resume. +The complete phase is the same as for system resume. After saving the image, devices need to be powered down before the system can enter the target sleep state (ACPI S4 for ACPI-based systems). This is done in -- 2.23.0.700.g56cf767bdb-goog