Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932607AbWAFCu2 (ORCPT ); Thu, 5 Jan 2006 21:50:28 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932610AbWAFCu1 (ORCPT ); Thu, 5 Jan 2006 21:50:27 -0500 Received: from mail.kroah.org ([69.55.234.183]:14262 "EHLO perch.kroah.org") by vger.kernel.org with ESMTP id S932608AbWAFCu0 (ORCPT ); Thu, 5 Jan 2006 21:50:26 -0500 Date: Thu, 5 Jan 2006 16:38:06 -0800 From: Greg KH To: Dominik Brodowski , Pavel Machek , Patrick Mochel , Andrew Morton , Linux-pm mailing list , kernel list Subject: Re: [linux-pm] [patch] pm: fix runtime powermanagement's /sys interface Message-ID: <20060106003806.GA29182@kroah.com> References: <20051227213439.GA1884@elf.ucw.cz> <20051227220533.GA1914@elf.ucw.cz> <20060104213405.GC1761@elf.ucw.cz> <20060105215528.GF2095@elf.ucw.cz> <20060105221334.GA925@isilmar.linta.de> <20060105222338.GG2095@elf.ucw.cz> <20060105222705.GA12242@isilmar.linta.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20060105222705.GA12242@isilmar.linta.de> User-Agent: Mutt/1.5.11 Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1879 Lines: 53 On Thu, Jan 05, 2006 at 11:27:05PM +0100, Dominik Brodowski wrote: > On Thu, Jan 05, 2006 at 11:23:38PM +0100, Pavel Machek wrote: > > > In addition, your patch breaks pcmcia / pcmciautils which already uses > > > numbers (which I already had to change from "3" to "2" before...). > > > > pcmcia actually uses this? Ouch. Do you just read the power file, or > > do you write to it, too? > > Reading and writing. Replacement for "cardctl suspend" and "cardctl resume". > > > static int pccardctl_power_one(unsigned long socket_no, unsigned int device, > unsigned int power) > { > int ret; > char file[SYSFS_PATH_MAX]; > struct sysfs_attribute *attr; > > snprintf(file, SYSFS_PATH_MAX, > "/sys/bus/pcmcia/devices/%lu.%u/power/state", > socket_no, device); > > attr = sysfs_open_attribute(file); > if (!attr) > return -ENODEV; > > ret = sysfs_write_attribute(attr, power ? "2" : "0", 1); > > sysfs_close_attribute(attr); > > return (ret); > } > > > NB: it will break one day, one way or another, when gregkh makes the > /sys/class -> /sys/devices conversion. However, I'd want to try not to break > the new pcmciautils userspace too often... Why would the conversion that I'm working on break this userspace code? You are only using the device directory, which will not change at all. And my goal in the rework is to not break userspace code, although libsysfs does need a one line change to handle this, hopefully they have intregrated that already... thanks, greg k-h - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/