Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH] MIPS: Loongson: Make default kernel log buffer size as
 128KB for Loongson3
To:     Huacai Chen <chenhc@lemote.com>
References: <1571101656-871-1-git-send-email-yangtiezhu@loongson.cn>
 <CAAhV-H573fv+NVqBRgU38BRDDX=syj3gUqnJqRp4CdBx+QcdpQ@mail.gmail.com>
Cc:     Paul Burton <paul.burton@mips.com>,
        Ralf Baechle <ralf@linux-mips.org>,
        James Hogan <jhogan@kernel.org>,
        "open list:MIPS" <linux-mips@vger.kernel.org>,
        LKML <linux-kernel@vger.kernel.org>
From:   Tiezhu Yang <yangtiezhu@loongson.cn>
Message-ID: <d897527b-3c36-41a8-b878-64a099cbdfa0@loongson.cn>
Date:   Tue, 15 Oct 2019 12:00:25 +0800
User-Agent: Mozilla/5.0 (X11; Linux mips64; rv:45.0) Gecko/20100101
 Thunderbird/45.4.0
MIME-Version: 1.0
In-Reply-To: <CAAhV-H573fv+NVqBRgU38BRDDX=syj3gUqnJqRp4CdBx+QcdpQ@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 10/15/2019 11:36 AM, Huacai Chen wrote:
> On Tue, Oct 15, 2019 at 10:12 AM Tiezhu Yang <yangtiezhu@loongson.cn> wrote:
>> When I update kernel with loongson3_defconfig based on the Loongson 3A3000
>> platform, then using dmesg command to show kernel ring buffer, the initial
>> kernel messages have disappeared due to the log buffer is too small, it is
>> better to change the default kernel log buffer size from 16KB to 128KB.
>>
>> Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>
>> ---
>>   arch/mips/configs/loongson3_defconfig | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/mips/configs/loongson3_defconfig b/arch/mips/configs/loongson3_defconfig
>> index 90ee008..3aa2201 100644
>> --- a/arch/mips/configs/loongson3_defconfig
>> +++ b/arch/mips/configs/loongson3_defconfig
>> @@ -12,7 +12,7 @@ CONFIG_TASKSTATS=y
>>   CONFIG_TASK_DELAY_ACCT=y
>>   CONFIG_TASK_XACCT=y
>>   CONFIG_TASK_IO_ACCOUNTING=y
>> -CONFIG_LOG_BUF_SHIFT=14
>> +CONFIG_LOG_BUF_SHIFT=17
> Hi, Tiezhu,
>
> Why you choose 128KB but not 64KB or 256KB? I found 64KB is enough for
> our cases. And if you really need more, I think 256KB could be better
> because there are many platforms choose 256KB.

Hi Huacai,

Thanks for your reply and suggestion, I will send a v2 patch.

Thanks,

Tiezhu Yang

>
> Huacai
>
>>   CONFIG_MEMCG=y
>>   CONFIG_MEMCG_SWAP=y
>>   CONFIG_BLK_CGROUP=y
>> --
>> 2.1.0
>>
>>