Received: by 2002:a5b:505:0:0:0:0:0 with SMTP id o5csp5706204ybp; Tue, 15 Oct 2019 03:56:13 -0700 (PDT) X-Google-Smtp-Source: APXvYqz1N3zYN35OKPIHJyBCGut+LUMqiuMbjAKTO6wJAJ8wPsiIL2tXfmmtYc5SOGN2UjOBdH2e X-Received: by 2002:a17:906:1f44:: with SMTP id d4mr32897470ejk.16.1571136973828; Tue, 15 Oct 2019 03:56:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1571136973; cv=none; d=google.com; s=arc-20160816; b=qbIRQT3Fea1kPIx2wwu4TpLc2l9qEW+UGmrhz8rQsX7OrrS6shexLTNu2d1t44pNCe 7U3GTbIvxEgL3nPj3+nTaw4fYlYTYP/2lKERCvEiuxZE1z4wD2SccK6ezbQMISYV6/xI 8yxKG9UgimTH6NNg6n7475XtnZtSREpFrQ3Egn08y9h9/CBxNKYqAC4lu+0e2YaEFQY5 OOzWh7mbXBV+2VkE/0zjtZwClmn/rtX9eWvK541GWp3xt71x+DRwW1FjaZfWe1hm/IfE iQbi+TnK12/jKwImv2feF/Iic/cO0piY831mD8hlKYlJrRBelE93OGBgMaSOvrWcXMAW AXdg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=wnuAl5JtsHUOid65Qy+G3kdgjasueY+xYrNILl9pjkw=; b=MvdNc8v0MW363DzjbJvJ4iIisjTmvT1d3+up5yMUGHDwz0SCeic5Q94kHuBBERv1L9 dZS/yvkwvrz2/5SD7bHHWSyEVBMfONBmnaNQq2b/nb6Y6vAtp4icX2D2JbQ0jBK9zKzJ 0UCSvvK//Ht6GzeDqdY8mN01xSuCKlChMqODIZK+STfNxyaJo7wuAuzvza9LXTewLhc5 4yYJgrG1J4b+b2ecyI6DXMBrQQYSeVzriNdhUU70Sy5ge+UTni9MLlw8QcDtOdfny18h qd5QaIQhLSjQfTve3gpduPWvw5YtTUjIu4payPJX81Om/UCjyzDChdqDuTA98TMkQjpX tu5w== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=mU4Da2tW; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id rh9si12851211ejb.102.2019.10.15.03.55.50; Tue, 15 Oct 2019 03:56:13 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=mU4Da2tW; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728473AbfJOIID (ORCPT + 99 others); Tue, 15 Oct 2019 04:08:03 -0400 Received: from bombadil.infradead.org ([198.137.202.133]:38268 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728295AbfJOIIC (ORCPT ); Tue, 15 Oct 2019 04:08:02 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=wnuAl5JtsHUOid65Qy+G3kdgjasueY+xYrNILl9pjkw=; b=mU4Da2tWWcMEckNczgZ1z+WoI mRQ0tEYXnCz+1Ra7zuTZM7GKnu7rMWAKxtt84xsyg90LIA+pPbxXB+mFQqyAt2moMyX4NW/8zgNlU njYvPTLyTAG+3JUF7cvf09nFWET0miMV4HntSodqCG0xrAxJ4Ey1VTl5pgsgsbNfZ4m2PHCanA2Ck uCUg/F3CJF8ruBWG8C99DGa6QVVnEkmIk6gHPLoE01wUO+1QfpX0xpWNAxQhAsrq1HnmPigIBnzd3 56tykTjPAwk1ybJUCjWgnOSaPY2Z8plGtztzQ2TdrGfne9n4oHRdVh7DHFftEDgAha/nTgx9esFUp GK1x/FRrw==; Received: from hch by bombadil.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1iKHsA-0004Sx-7E; Tue, 15 Oct 2019 08:08:02 +0000 Date: Tue, 15 Oct 2019 01:08:02 -0700 From: Christoph Hellwig To: Daniel Colascione Cc: linux-api@vger.kernel.org, linux-kernel@vger.kernel.org, lokeshgidra@google.com, nnk@google.com, nosh@google.com, timmurray@google.com Subject: Re: [PATCH 1/7] Add a new flags-accepting interface for anonymous inodes Message-ID: <20191015080802.GA16814@infradead.org> References: <20191012191602.45649-1-dancol@google.com> <20191012191602.45649-2-dancol@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191012191602.45649-2-dancol@google.com> User-Agent: Mutt/1.12.1 (2019-06-15) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Oct 12, 2019 at 12:15:56PM -0700, Daniel Colascione wrote: > Add functions forwarding from the old names to the new ones so we > don't need to change any callers. Independent of the usefulness of the interface (I'll let other comment, but you defintively want to talk to Al Viro), adding a second interface for only 17 callers total is a bad idea. Just switch the existing interface to pass flags.