Received: by 2002:a5b:505:0:0:0:0:0 with SMTP id o5csp5710957ybp; Tue, 15 Oct 2019 04:01:23 -0700 (PDT) X-Google-Smtp-Source: APXvYqz0hOtsldI1wN4bRg4mtH4wdyQbzTGoNVtPoDJI5hZadQ2sEcKKo+VUr2r1+DC1RSXd8hPP X-Received: by 2002:a17:906:6a4f:: with SMTP id n15mr33584154ejs.19.1571137283276; Tue, 15 Oct 2019 04:01:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1571137283; cv=none; d=google.com; s=arc-20160816; b=WlXKlJueSDYdIHuLQzrDV/PrP8xDi5fCL5myUy1G6Pjfh4u0d27yriSHYO/4921kjD HksR3K9f+vKaQHrfyh9H7YXnk3JQAbDqQYMMBEUX+RVSP5bnCH01VCF4TEI6P+xPDd8q wvmII5EPKiRiwZmqVVsoFZuNlN0Ub2QqzLckxuFjxbO8enIB1ySLtz9F/KkJ80XNrQ8C sRUGrwn2c1vXJft5JRnifrryNU0d8a1DzBTgsMlQVUkqDvqycd0hVVFjWa8l8DyhxWoA V/e4+u4lKFc3pQM+dED88lbjicxIwpHGdSeMnkZsNY8NSQKYff2Pq11giEI883PDbWkj b+iw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=Z7zb8hwdUvM4gWBjniUrfCCpeZFbxnEJV1qTM/lkvII=; b=kb8EjuKB+7pufC6XDY2EaRXKdHyOkqjNmkbWo4EGiIa2NFSuu1noMsSI0xvSIee3jH mxt3hJVcA2a+Z23WdlvohOa3Wsn6f3BDdOeBVjlv8QwMJr3XBwIiJWiBNxMlHd32Lv0A quhzopQx6Tj+1vQs50CnkyvxP4E9bin7oQQHLHC0zvLV7LWkaKIhHNciNGt1ZR0zE9VL IXHO8yePWg5zluJCUh1qZGmER2EL8EZdMHeXsXSYy204KUiALHitQyTFRwIcv03GUfyv chgkggc1Wg7zP9McSpuJ3ebFZKfljHXSgWNtowsBDvYEWoOAq03i2Gw0d+S5WFyhCbw+ dFyQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=OHDKau5y; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id jo19si12898664ejb.271.2019.10.15.04.00.59; Tue, 15 Oct 2019 04:01:23 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=OHDKau5y; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728627AbfJOIQV (ORCPT + 99 others); Tue, 15 Oct 2019 04:16:21 -0400 Received: from bombadil.infradead.org ([198.137.202.133]:40152 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727962AbfJOIQV (ORCPT ); Tue, 15 Oct 2019 04:16:21 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=Z7zb8hwdUvM4gWBjniUrfCCpeZFbxnEJV1qTM/lkvII=; b=OHDKau5y8c7YAepQgJhwyx+OE 1DX8y2NcUjlALU49vt3s8qRfvOIBXlOoJDHvviOemYJWZjHFpN6gd6wHraUIlTmxiUe9c+roa67fc /ADANaqg0mE3kerF5EQlvhA2WO+oU6UNW0kEoiCSJQ0ByKsskbr79cWZXsN5/TVUcJ4e1MymZO3FV 1rnOfv4BLf5QfiirP5zYm+8gM3B8JftOBHIlj6l92646m4LpBJy2bqMHHo6cV+hYOyUPbUnT7p4UL YWYbRiVQaZwnjg9q1SP/5anlZ5lte5BkOF+bFoYR9p/SSD5U7psBI6K1Pa1gezOIzATHJOR2rxAoy J++tB0Pvw==; Received: from hch by bombadil.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1iKI0C-0007wo-62; Tue, 15 Oct 2019 08:16:20 +0000 Date: Tue, 15 Oct 2019 01:16:20 -0700 From: Christoph Hellwig To: Pankaj Dubey Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, bhelgaas@google.com, andrew.murray@arm.com, lorenzo.pieralisi@arm.com, gustavo.pimentel@synopsys.com, jingoohan1@gmail.com, vidyas@nvidia.com, Anvesh Salveru Subject: Re: [PATCH v3] PCI: dwc: Add support to add GEN3 related equalization quirks Message-ID: <20191015081620.GA28204@infradead.org> References: <1571108362-25962-1-git-send-email-pankaj.dubey@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1571108362-25962-1-git-send-email-pankaj.dubey@samsung.com> User-Agent: Mutt/1.12.1 (2019-06-15) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Oct 15, 2019 at 08:29:22AM +0530, Pankaj Dubey wrote: > From: Anvesh Salveru > > In some platforms, PCIe PHY may have issues which will prevent linkup > to happen in GEN3 or higher speed. In case equalization fails, link will > fallback to GEN1. > > DesignWare controller gives flexibility to disable GEN3 equalization > completely or only phase 2 and 3 of equalization. > > This patch enables the DesignWare driver to disable the PCIe GEN3 > equalization by enabling one of the following quirks: > - DWC_EQUALIZATION_DISABLE: To disable GEN3 equalization all phases > - DWC_EQ_PHASE_2_3_DISABLE: To disable GEN3 equalization phase 2 & 3 > > Platform drivers can set these quirks via "quirk" variable of "dw_pcie" > struct. Please submit this together with the changes to the dwc frontend driver that actually wants to set these quirks.