Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Tue, 15 Oct 2019 15:47:34 +0530
From:   Vinod Koul <vkoul@kernel.org>
To:     Baolin Wang <baolin.wang@linaro.org>
Cc:     orsonzhai@gmail.com, zhang.lyra@gmail.com,
        dan.j.williams@intel.com, linux-kernel@vger.kernel.org,
        dmaengine@vger.kernel.org, eric.long@unisoc.com,
        zhenfang.wang@unisoc.com
Subject: Re: [PATCH] dmaengine: sprd: Fix the possible memory leak issue
Message-ID: <20191015101734.GS2654@vkoul-mobl>
References: <170dbbc6d5366b6fa974ce2d366652e23a334251.1570609788.git.baolin.wang@linaro.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <170dbbc6d5366b6fa974ce2d366652e23a334251.1570609788.git.baolin.wang@linaro.org>
User-Agent: Mutt/1.12.1 (2019-06-15)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 09-10-19, 17:11, Baolin Wang wrote:
> If we terminate the channel to free all descriptors associated with this
> channel, we will leak the memory of current descriptor if the current
> descriptor is not completed, since it had been deteled from the desc_issued
> list and have not been added into the desc_completed list.
> 
> Thus we should check if current descriptor is completed or not, when freeing
> the descriptors associated with one channel, if not, we should free it to
> avoid this issue.

Applied, thanks

-- 
~Vinod