Received: by 2002:a5b:505:0:0:0:0:0 with SMTP id o5csp5785084ybp; Tue, 15 Oct 2019 05:07:55 -0700 (PDT) X-Google-Smtp-Source: APXvYqx3xjaxhgCsQWr+oEx8dCLIutcemPZ+DUvoIbLch7Uv31I6N7M86xhJGcYI6LdOACfPrCoD X-Received: by 2002:a05:6402:13c9:: with SMTP id a9mr32484858edx.141.1571141275802; Tue, 15 Oct 2019 05:07:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1571141275; cv=none; d=google.com; s=arc-20160816; b=pk2IA88B4p+w8CMIoGqpubfL2T883zI4jo3WIyKuhc/Bs5Aopi6PYCgYG35faJ744L gIUu4WeaMz0KywsZCTXX3QLoh1YvpbspQeI0nOAU9bASyEcLl7vHNYDuFSH5lHG/JDZO PPGJ0nGrLs7g4y6Gsxufr+Z8MxPDXnXDmuYP0qPdr+X8QDfXFKbavZ6S48edZEAuDcum TV1i5DvHz8+8YfEBcOB5+xrFyqMCnGPxaTkMkkNKBSboBlvVlXWsdZSEJ/zFZXaB6E3p XPuHB17IaHOheKenmMEB4Pb17H8lN2bMVnGXROOD0FsZqGd6Lts64q+WbitSUij9VYw0 dWIw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=15cArHNdUyym5F38KoGKkxS7rj4jZrDm8izOQc3OK3g=; b=eNBr92hAkJQB91B4OPnN/2vQ8O2+EN2E9qgywe9JBFeaQHnQa2zNitUVcvtjgqLWLb wLZ+WtQF1Thi9X59IaWWEJac6A3Z6Vco/t/rSPFUCGTKs44qfCsYiizAQpxzbFsKEtEj +8NQehHyClzxq2ULU8qpbPucmbsAqbUxjjIHNAH8nT4QoWTu6PVtn5yIyphS5R9byjDW jmX18nnz6Gt8s5/yTs3rt1SLGNLgR6x3QkBOFhBtwvaisXOYaPCD71nP2gd4rRr1f9W4 BlTLsEo2xBfDMXkKmrP2nMb6ALGp1wzhuC8+xRBQ56wC5ppdA5qHfXKT0gKz5Y5FbVsN 6KHA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=8bytes.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id oz25si12502287ejb.175.2019.10.15.05.07.31; Tue, 15 Oct 2019 05:07:55 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=8bytes.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731591AbfJOLCG (ORCPT + 99 others); Tue, 15 Oct 2019 07:02:06 -0400 Received: from 8bytes.org ([81.169.241.247]:47426 "EHLO theia.8bytes.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726054AbfJOLCF (ORCPT ); Tue, 15 Oct 2019 07:02:05 -0400 Received: by theia.8bytes.org (Postfix, from userid 1000) id BED4D2D9; Tue, 15 Oct 2019 13:02:03 +0200 (CEST) Date: Tue, 15 Oct 2019 13:02:02 +0200 From: Joerg Roedel To: Geert Uytterhoeven Cc: Stephen Boyd , Greg Kroah-Hartman , linux-renesas-soc@vger.kernel.org, iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] iommu/ipmmu-vmsa: Only call platform_get_irq() when interrupt is mandatory Message-ID: <20191015110202.GF14518@8bytes.org> References: <20191001180622.806-1-geert+renesas@glider.be> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191001180622.806-1-geert+renesas@glider.be> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Oct 01, 2019 at 08:06:22PM +0200, Geert Uytterhoeven wrote: > As platform_get_irq() now prints an error when the interrupt does not > exist, calling it gratuitously causes scary messages like: > > ipmmu-vmsa e6740000.mmu: IRQ index 0 not found > > Fix this by moving the call to platform_get_irq() down, where the > existence of the interrupt is mandatory. > > Fixes: 7723f4c5ecdb8d83 ("driver core: platform: Add an error message to platform_get_irq*()") > Signed-off-by: Geert Uytterhoeven > --- > This is a fix for v5.4-rc1. > --- > drivers/iommu/ipmmu-vmsa.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) Applied for v5.4