Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   "Pankaj Dubey" <pankaj.dubey@samsung.com>
To:     "'Christoph Hellwig'" <hch@infradead.org>
Cc:     <linux-pci@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <bhelgaas@google.com>, <andrew.murray@arm.com>,
        <lorenzo.pieralisi@arm.com>, <gustavo.pimentel@synopsys.com>,
        <jingoohan1@gmail.com>, <vidyas@nvidia.com>,
        "'Anvesh Salveru'" <anvesh.s@samsung.com>
In-Reply-To: <20191015090547.GA7199@infradead.org>
Subject: RE: [PATCH v3] PCI: dwc: Add support to add GEN3 related
 equalization quirks
Date:   Tue, 15 Oct 2019 20:47:32 +0530
Message-ID: <000e01d5836b$ac871190$059534b0$@samsung.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Thread-Index: AQI32j4iOCLbX1pxMrCw4/raoiQM8gHGBYnvAqR4VLEBamEVbwI4vguWplZSofA=
Content-Language: en-us
Content-Type: text/plain; charset="utf-8"
CMS-TYPE: 105P
References: <CGME20191015025933epcas5p1f0891dacc13648559ed8e037e49ee5b1@epcas5p1.samsung.com>
        <1571108362-25962-1-git-send-email-pankaj.dubey@samsung.com>
        <20191015081620.GA28204@infradead.org>
        <068001d58336$a76ed970$f64c8c50$@samsung.com>
        <20191015090547.GA7199@infradead.org>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


> -----Original Message-----
> From: 'Christoph Hellwig' <hch@infradead.org>
> Sent: Tuesday, October 15, 2019 2:36 PM
> To: Pankaj Dubey <pankaj.dubey@samsung.com>
> Cc: 'Christoph Hellwig' <hch@infradead.org>; linux-pci@vger.kernel.org;
linux-
> kernel@vger.kernel.org; bhelgaas@google.com; andrew.murray@arm.com;
> lorenzo.pieralisi@arm.com; gustavo.pimentel@synopsys.com;
> jingoohan1@gmail.com; vidyas@nvidia.com; 'Anvesh Salveru'
> <anvesh.s@samsung.com>
> Subject: Re: [PATCH v3] PCI: dwc: Add support to add GEN3 related
equalization
> quirks
> 
> On Tue, Oct 15, 2019 at 02:28:00PM +0530, Pankaj Dubey wrote:
> > Is this something mandatory?
> >
> > As we discussed during first patch-set here [1] with Andrew, we have
> > need of this patch (along with some other stuffs, which will be sent
> > soon), to clean up our internal driver and make it ready for upstream.
> > As of today we have some internal restrictions where we can't make it
> > to upstream along with this patch.
> 
> We don't add code to the kernel without actual users.

OK, but do we think the current driver has only code which is being used by
some user?
At least I can see current driver has some features which is not being used
by any current driver.  

I will leave this call up-to the maintainers.
IMO, This being an DWC H/W IP feature, for me it makes sense to have it in
DWC controller driver as long as it does not break any existing
functionality, irrespective of actual user is present or not.