Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752438AbWAFIuH (ORCPT ); Fri, 6 Jan 2006 03:50:07 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752435AbWAFIuH (ORCPT ); Fri, 6 Jan 2006 03:50:07 -0500 Received: from ns.ustc.edu.cn ([202.38.64.1]:4510 "EHLO mx1.ustc.edu.cn") by vger.kernel.org with ESMTP id S1752438AbWAFIuF (ORCPT ); Fri, 6 Jan 2006 03:50:05 -0500 Date: Fri, 6 Jan 2006 16:58:59 +0800 From: Wu Fengguang To: Marcelo Tosatti Cc: linux-kernel@vger.kernel.org, Andrew Morton , Christoph Lameter , Rik van Riel , Peter Zijlstra , Magnus Damm , Nick Piggin , Andrea Arcangeli Subject: Re: [PATCH 09/16] mm: remove unnecessary variable and loop Message-ID: <20060106085859.GD5297@mail.ustc.edu.cn> Mail-Followup-To: Wu Fengguang , Marcelo Tosatti , linux-kernel@vger.kernel.org, Andrew Morton , Christoph Lameter , Rik van Riel , Peter Zijlstra , Magnus Damm , Nick Piggin , Andrea Arcangeli References: <20051207104755.177435000@localhost.localdomain> <20051207105106.887005000@localhost.localdomain> <20060105192156.GA12589@dmt.cnet> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20060105192156.GA12589@dmt.cnet> User-Agent: Mutt/1.5.11 Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 730 Lines: 23 On Thu, Jan 05, 2006 at 05:21:56PM -0200, Marcelo Tosatti wrote: > On Wed, Dec 07, 2005 at 06:48:04PM +0800, Wu Fengguang wrote: > > shrink_cache() and refill_inactive_zone() do not need loops. > > > > Simplify them to scan one chunk at a time. > > Hi Wu, Hi Marcelo, > What is the purpose of scanning large chunks at a time? But I did not say or mean 'large' chunks :) With the patch the chunk size is _always_ set to SWAP_CLUSTER_MAX=32 - the good old default value. Thanks. Wu - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/