Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
IronPort-SDR: 3ePImYSncZep9v3pR30lroA5RXfe5pFyjBJFTmn0Cv9AMDg0zZ1qcixjdbC+cFpKLVuR6QnT/w
 iTFPeN0avoaYlabzVX/e9SsQKlk0Vvqi8+xak7s7LtsI+WNiscC5x5Zm4LVOyNLUde16sy6wr+
 DWjnfqKdsOPBnQ9a7TH0eoiE+b/bKNQr601SkkZT3+pc0e5Ci0jFlqbwiTKPyMJtz0/B4a5bJj
 IWOaahT4dkuN0rDudPp0B6wHsseNhdKumOmkEhZuVf4rLH+chibKJLr9D2Q+CB1gECizttNZz4
 u14=
IronPort-PHdr: =?us-ascii?q?9a23=3AqI1agxKpoMXm1jAfqtmcpTZWNBhigK39O0sv0r?=
 =?us-ascii?q?FitYgRI/jxwZ3uMQTl6Ol3ixeRBMOHsqkC1LGd6vi9EUU7or+5+EgYd5JNUx?=
 =?us-ascii?q?JXwe43pCcHRPC/NEvgMfTxZDY7FskRHHVs/nW8LFQHUJ2mPw6arXK99yMdFQ?=
 =?us-ascii?q?viPgRpOOv1BpTSj8Oq3Oyu5pHfeQpFiCezbL9oLhi7owrdutQKjYZiN6081g?=
 =?us-ascii?q?bHrnxUdupM2GhmP0iTnxHy5sex+J5s7SFdsO8/+sBDTKv3Yb02QaRXAzo6PW?=
 =?us-ascii?q?814tbrtQTYQguU+nQcSGQWnQFWDAXD8Rr3Q43+sir+tup6xSmaIcj7Rq06VD?=
 =?us-ascii?q?i+86tmTgLjhTwZPDAl7m7Yls1wjLpaoB2/oRx/35XUa5yROPZnY6/RYc8WSW?=
 =?us-ascii?q?9HU8ZUVixBGZi8b4oJD+oOIO1WsZDzrEYArRu/GwasAP7gwSJMinL4waE21u?=
 =?us-ascii?q?IsGhzE0gM9BdIDqHTaosvoOqkcUu67y7LFwSnfY/5MxTvw8pTEfgwnrPqRXb?=
 =?us-ascii?q?xwa83RyUw3GgzHj1WRqIzlPy6S1u8QtGWa7+thVeK1hG4mtw19vjaiy9wxio?=
 =?us-ascii?q?bVnIIZ0E7L+jhkwIssI9CzVU11Yca8HZdOqy2XM5F6T8AiTm1ypio216EKtY?=
 =?us-ascii?q?SlcCQW1Jgr3wPTZv2DfoSS/B7uWuacLS1miH9kYr6yhRm//E69wePmTMa0yk?=
 =?us-ascii?q?xFri9dn9nJsXACygLc59CcSvt44kehwTGP1x3P6u1cIUA7i67bK5k5z741jJ?=
 =?us-ascii?q?UTsEDDEjbumEX4kaOab0sk9va05+j7eLnmqZicN4h7igH6LKsigNCwAeM9Mg?=
 =?us-ascii?q?QWXmib//qz1KH78EHnXLlHiuc6n6rZvZzAO8gXu7K1DxVL3oo/9xqzFzKm38?=
 =?us-ascii?q?4ZnXkDIlJFYhWHj43xNlDOIfH4De2wg1WwnDt3yf3LJaDhDYnXLnTZjrjuYK?=
 =?us-ascii?q?t951ZGyAUv1dBf+45UCrYZLfL3W0/xssHYDxAgPwy33ennEtN92Z0aWW+UHK?=
 =?us-ascii?q?+ZP73dsUWS6uIsPeaMfokVtyj5K/Q/4P7ul3A5yhczZ66siKoWenClGbwyMl?=
 =?us-ascii?q?eZaHu02owpDGwQ+AcyUbq52xW5TTdPaiPqDOoH7TYhBdfjUt/O?=
From:   Yizhuo <yzhai003@ucr.edu>
Cc:     zhiyunq@cs.ucr.edu, csong@cs.ucr.edu, Yizhuo <yzhai003@ucr.edu>,
        Sebastian Reichel <sre@kernel.org>, linux-pm@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: [PATCH] power: supply: rt5033_battery: Fix the usage of potential uninitialized variable
Date:   Tue, 15 Oct 2019 09:57:37 -0700
Message-Id: <20191015165737.658-1-yzhai003@ucr.edu>
To:     unlisted-recipients:; (no To-header on input)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

In function rt5033_battery_get_present(), variable "val" could be
uninitialized if regmap_read() returns -EINVAL. However, "val" is
used to decide the return value, which is potentially unsafe.

Signed-off-by: Yizhuo <yzhai003@ucr.edu>
---
 drivers/power/supply/rt5033_battery.c | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/drivers/power/supply/rt5033_battery.c b/drivers/power/supply/rt5033_battery.c
index d8667a9fc49b..6a617531698c 100644
--- a/drivers/power/supply/rt5033_battery.c
+++ b/drivers/power/supply/rt5033_battery.c
@@ -26,8 +26,14 @@ static int rt5033_battery_get_present(struct i2c_client *client)
 {
 	struct rt5033_battery *battery = i2c_get_clientdata(client);
 	u32 val;
+	int ret;
 
-	regmap_read(battery->regmap, RT5033_FUEL_REG_CONFIG_L, &val);
+	ret = regmap_read(battery->regmap, RT5033_FUEL_REG_CONFIG_L, &val);
+	if (ret) {
+		dev_err(&client->dev,
+			"Failed to read RT5033_FUEL_REG_CONFIG_L.\n");
+		return false;
+	}
 
 	return (val & RT5033_FUEL_BAT_PRESENT) ? true : false;
 }
-- 
2.17.1