Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Jes Sorensen <jes.sorensen@gmail.com>
Subject: Re: [PATCH] rtl8xxxu: fix RTL8723BU connection failure issue after
 warm reboot
To:     Chris Chiu <chiu@endlessm.com>, kvalo@codeaurora.org,
        davem@davemloft.net
Cc:     linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux@endlessm.com
References: <20191015101909.4640-1-chiu@endlessm.com>
Message-ID: <30809d50-a9ba-881b-1d3b-f3582c14cf79@gmail.com>
Date:   Tue, 15 Oct 2019 13:47:32 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.1.1
MIME-Version: 1.0
In-Reply-To: <20191015101909.4640-1-chiu@endlessm.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 10/15/19 6:19 AM, Chris Chiu wrote:
> The RTL8723BU has problems connecting to AP after each warm reboot.
> Sometimes it returns no scan result, and in most cases, it fails
> the authentication for unknown reason. However, it works totally
> fine after cold reboot.
> 
> Compare the value of register SYS_CR and SYS_CLK_MAC_CLK_ENABLE
> for cold reboot and warm reboot, the registers imply that the MAC
> is already powered and thus some procedures are skipped during
> driver initialization. Double checked the vendor driver, it reads
> the SYS_CR and SYS_CLK_MAC_CLK_ENABLE also but doesn't skip any
> during initialization based on them. This commit only tells the
> RTL8723BU to do full initilization without checking MAC status.
> 
> Signed-off-by: Chris Chiu <chiu@endlessm.com>
> ---
>   drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu.h       | 1 +
>   drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_8723b.c | 1 +
>   drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c  | 3 +++
>   3 files changed, 5 insertions(+)

Looks good to me! If this takes care of the warm boot problem, that's 
pretty awesome.

Signed-off-by: Jes Sorensen <Jes.Sorensen@gmail.com>

Jes