Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset=UTF-8
In-Reply-To: <20191015165531.27469-1-ckellner@redhat.com>
Date:   Tue, 15 Oct 2019 21:38:59 +0200
Cc:     "Christian Kellner" <christian@kellner.me>,
        "Christian Brauner" <christian@brauner.io>,
        "Shuah Khan" <shuah@kernel.org>, <linux-kselftest@vger.kernel.org>
Subject: Re: [PATCH v2] pidfd: avoid linux/wait.h and sys/wait.h name
 clashes
From:   "Christian Brauner" <christian.brauner@ubuntu.com>
To:     "Christian Kellner" <ckellner@redhat.com>,
        <linux-kernel@vger.kernel.org>
Message-Id: <BXQCOYS7J0NU.363NAWEEPN3GH@wittgenstein>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue Oct 15, 2019 at 6:55 PM Christian Kellner wrote:
> From: Christian Kellner <christian@kellner.me>
>=20
> Both linux/wait.h and sys/wait.h contain values for the first argument
> of 'waitid' (P_ALL, P_PID, ...).  While the former uses defines the
> latter uses an enum. When linux/wait.h is included before sys/wait.h
> this will lead to an error, because P_ALL, P_PID, ... will already
> have been substituted to 0, 1, ... respectively and this the resulting
> code will be 'typedef enum {0, 1, ...'.
> Remove 'linux/wait.h' and rename P_PIDFD to avoid a future clash, in
> case P_PIDFD gets added to the idtype_t enum in sys/wait.h.
>=20
> Signed-off-by: Christian Kellner <christian@kellner.me>

Reviewed-by: Christian Brauner <christian.brauner@ubuntu.com>