Received: by 2002:a5b:505:0:0:0:0:0 with SMTP id o5csp6663380ybp; Tue, 15 Oct 2019 19:23:55 -0700 (PDT) X-Google-Smtp-Source: APXvYqxMONaYfwq4eDAM0h/sFpEb3KdU7aLCG1AeKYecyBTqJNJZBEI9/UQvCV9UIwBjFovywrhc X-Received: by 2002:aa7:d045:: with SMTP id n5mr36743954edo.24.1571192635881; Tue, 15 Oct 2019 19:23:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1571192635; cv=none; d=google.com; s=arc-20160816; b=M5wgaiU74fvdAYS0kNe4DZFeyEKmxzbD1jgUGkxxR2FHAJejlkTB5GsrNpFtvzJRN4 iZPxBI58Isgmz9kda9UrZzCRMxl63iwVqm+btI5aqe0ttAio2CPgrMb3GDFxIsxmJeKf +IkLaTXU7MfjLZdDG3XOGghPRoHrAE17CRmxDKODlgrtToWmvJxt+mkW016g33aFH1QF wV/wu7BCU9Mo+WkQy/jxuEAFYl2OcNlLEOVtcSZLa+kd3KWOBPOdOX4DN08iTJFpXabr gdpXqSdTq4Nq8seRUc1yH66Sw2IQMZxU9YyN1bcBctfpyHP0tynE6SG21tEWhA82DaUe gxOg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=dYr5YHDW3PpOfxrfTITzHIyYd4WqoilUYd2hAnALyj4=; b=opICi7IBB488QzUqZgARYj5sQ9EB0MW9QV/W83K+/jPxl/os2EMGfc7y+dkQn72PcJ +m4My5FXNlGuTQGHd/T2EaoxljqOzcBdNKEvLMAykTW4gxYxOO5MEMEf9jxaFqI6ILz2 wUPNqv5Ek7WmARjBoe0GAdQ2sN0oNfezpouuZ54eON+Wd1wzX4vYPiUDc+mJFINbII0e t6qE3eCt0IoEiWfXg/PNzToTpv7G5MRVbwqkASeF/ZGxBo2/G//Kwfg72+lYdlYS9FJb jj1Qx//Uk5zR64QEPWAd9cpsen38CXH32TQHd5fQIEUhWJyBKwC4fghDYq1E59FhYo/+ ME8A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id o14si13932297ejc.433.2019.10.15.19.23.32; Tue, 15 Oct 2019 19:23:55 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732446AbfJOTlI (ORCPT + 99 others); Tue, 15 Oct 2019 15:41:08 -0400 Received: from mail-oi1-f193.google.com ([209.85.167.193]:42186 "EHLO mail-oi1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727856AbfJOTlH (ORCPT ); Tue, 15 Oct 2019 15:41:07 -0400 Received: by mail-oi1-f193.google.com with SMTP id i185so17860309oif.9; Tue, 15 Oct 2019 12:41:07 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=dYr5YHDW3PpOfxrfTITzHIyYd4WqoilUYd2hAnALyj4=; b=LSZqEUWCFmaepVOFhBNPPE6MG7nAb5rAcPPSF3ZfroRIovkq2FfdRFq7OQW2/9UtaB HpytoOT7x1ts79e779/Vqsp/TUz9XeRwCzl/B+iymSSuAjyK+tooID1+XMebEuiTEsRN qGKaunqcBaTRi0hCWpdzz/r7nMO0X60EfwLIua5WnpECjIi4Pt/rbdwktFg85EchJBVb OsthpsT8Zqt5uKwZ1c1q94r/7aSc7c20Y3nVoNj/q+5tGjJVp3QA5549gPgg34bFxZH5 6Lk2Ux3gZ5O/w7psHUf3zJtOwufBQyz/mCTLVkFS/5g6GtoYbGLVOpslLgFUIkaGqLju SSqg== X-Gm-Message-State: APjAAAXQ5rzuYPeIS9Gr3P/6mWW/oJQapyCOb4ZUEIx9oeuRkeeBmsNb 21hNSBAZuR1tJcarcUOjo3rhiU8= X-Received: by 2002:a05:6808:689:: with SMTP id k9mr220151oig.58.1571168466497; Tue, 15 Oct 2019 12:41:06 -0700 (PDT) Received: from localhost (24-155-109-49.dyn.grandenetworks.net. [24.155.109.49]) by smtp.gmail.com with ESMTPSA id t17sm6633499otk.14.2019.10.15.12.41.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Oct 2019 12:41:05 -0700 (PDT) Date: Tue, 15 Oct 2019 14:41:05 -0500 From: Rob Herring To: Navid Emamdoost Cc: emamd001@umn.edu, kjlu@umn.edu, smccaman@umn.edu, Navid Emamdoost , Frank Rowand , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] of: unittest: fix memory leak in unittest_data_add Message-ID: <20191015194105.GA24758@bogus> References: <20191004185847.14074-1-navid.emamdoost@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191004185847.14074-1-navid.emamdoost@gmail.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 4 Oct 2019 13:58:43 -0500, Navid Emamdoost wrote: > In unittest_data_add, a copy buffer is created via kmemdup. This buffer > is leaked if of_fdt_unflatten_tree fails. The release for the > unittest_data buffer is added. > > Fixes: b951f9dc7f25 ("Enabling OF selftest to run without machine's devicetree") > Signed-off-by: Navid Emamdoost > --- > drivers/of/unittest.c | 1 + > 1 file changed, 1 insertion(+) > Applied, thanks. Rob