Received: by 2002:a5b:505:0:0:0:0:0 with SMTP id o5csp6905932ybp; Wed, 16 Oct 2019 00:23:09 -0700 (PDT) X-Google-Smtp-Source: APXvYqwUjofo9NT9K3bvBxWm1JlSwse3RTpfI8Q9gcViZ3MNx9v2uxYsw03ddWHw9JKfEGDWPUEL X-Received: by 2002:a50:ed0b:: with SMTP id j11mr38032664eds.50.1571210589324; Wed, 16 Oct 2019 00:23:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1571210589; cv=none; d=google.com; s=arc-20160816; b=Dnyi3QtifSE126lS9NYKSNG8KSi6fHJUUd42EvwwBu/Mk4h7U1I4KvVjhNCFO+RflB /oBu569IiIkgry9JnApilnFV7KOpgto0tzDF8RJ+wrSBXdPJI6nv6PrWjgI80RvBpCaC nq9IskMpWU0C7TrJQzz4wvZQNg81avXkTqB+UkggAA61jekxOQMUaXpM0e07SD76Z4TC zejqdecyTUSF9eaHu9UCBIyR0hEEduTHFRrbujRUSqj1nfRB+qm3CVq+wTKbJlM+9c9W B36kwrIC7ee6vq6N5rAk8OfLkDIWawA5TH7yuhIE4Dr2+XDr1fCTaGTsDzFMJrBH6K01 /IeQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=TnLlq/mha9LOZ/kgFMd4TsIE4qGpBhaWPQVIA5yqjR4=; b=PlAmVNPmfdCX/ralqs/mk8IASWC2AtPv3b73AUR8keHDynD7GvodfAi7LKHDIBOU1W gEyyDTcJViU6pUNMMqITEVxw6g4siISsj79LBhxlV8MIi/Q6qVH8WGLxoSKrHm5q48j+ xi9U6jD9ofFYwg8tcji0ymk6YVhWp8AQcyt2dDoyhzgV5fAthOVubuZOim1K0HnzHJ6Y D+3N4mk2XH9+sv7IzdK+pehAyHhWrfJdnxA1/VNpWJrVhUW7qDGuhtho3O1S4YxPU32k 7MakAWW32oSQokLxAhRA3NXj/UA/dD3KPMr5KKyk/e4D4sK422aqZL8fIwEllK6+ckGp 9WAQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id p39si16062451eda.416.2019.10.16.00.22.46; Wed, 16 Oct 2019 00:23:09 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731670AbfJOV7P (ORCPT + 99 others); Tue, 15 Oct 2019 17:59:15 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:40758 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728723AbfJOV7P (ORCPT ); Tue, 15 Oct 2019 17:59:15 -0400 Received: from localhost (unknown [IPv6:2601:601:9f00:1e2::d71]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 0CBAC1265C1F1; Tue, 15 Oct 2019 14:59:15 -0700 (PDT) Date: Tue, 15 Oct 2019 14:59:11 -0700 (PDT) Message-Id: <20191015.145911.716932933579995114.davem@davemloft.net> To: vcaputo@pengaru.com Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] net: core: datagram: tidy up copy functions a bit From: David Miller In-Reply-To: <20191012115509.jrqe43yozs7kknv5@shells.gnugeneration.com> References: <20191012115509.jrqe43yozs7kknv5@shells.gnugeneration.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 15 Oct 2019 14:59:15 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Vito Caputo Date: Sat, 12 Oct 2019 04:55:09 -0700 > + if ((copy = min(start - offset, len)) > 0) { As Eric said, we try to avoid this very construct these days. I'm not applying this patch. Thank you.