Received: by 2002:a5b:505:0:0:0:0:0 with SMTP id o5csp6907930ybp; Wed, 16 Oct 2019 00:25:34 -0700 (PDT) X-Google-Smtp-Source: APXvYqw8fLngE19ni3tfnsJVOxgaIaU8cw0gX7d4nGZKyeYDYWG1UjX5/AeFZmFxBJBMctyujZm2 X-Received: by 2002:aa7:d358:: with SMTP id m24mr37836369edr.204.1571210734364; Wed, 16 Oct 2019 00:25:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1571210734; cv=none; d=google.com; s=arc-20160816; b=W977OzkAcnx01RSQDh4Vqu/L+gTmz7zkn3Jqr1Fr43HuIyX79iCFb0+a++mNMpxDzO q1lNQ8wdR9u8ci6FLEgR50cEr3nVlXmJTD9vlNHWy32S2PK2DNDc1FD9TUlPvxg+9B0J HAO+xtLaTuDRTpng/CqeiAqN4tA8KWZJUiiuVbTSWCfmRQvT4Y11/mU0JMFiJWPyI1Wd 79oUA92z4k+SLMpeA6q2exImA1UgXo51C550oYmpQAIwK5VvYrUxauuSYCtqnzhjDkSq mB5X+ufvTMiBmkMFwaFTcwWHFkjs6m2/F9ya09opRdN/YO644xdTzIcNqNwMUQuV+uWH k9pg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=H/NZjtjYkUNGEEQ1ySt6vwkDfIwAf98zaC6+S2CMSuM=; b=uTAsIb/3pHq2cyQDSViBomcLvfP/DSOdLtpBjlxJbyVqX2E3nIrcAwZFRHtw3jX/Pv FG0+vDgmNINjqrhlzBqdCiFYxJh3phfp1e1X2WLoPjPRgW704FR/XPTWeaAV/Flg8jJX tLx5H+7uqiCzmY10BRkUfd6V49gruEfzjpKxRtvscwv6iSU+B7VFbUC297JS2EPUvNlY uHPM9tzEhdtSnK70vHt8P055EX0I3P7bgDFXAMTkUJm1IUswuv+3/pSBAfJX568cOKPS TlFlBqEI+6XyziVbvATnTeX6eIBFK50IgkrxJkuW5mQn8esAq9lBoTFhOqWf0QDl8Eob yBaA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a29si17322912eda.246.2019.10.16.00.25.10; Wed, 16 Oct 2019 00:25:34 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389154AbfJOWK3 (ORCPT + 99 others); Tue, 15 Oct 2019 18:10:29 -0400 Received: from mail104.syd.optusnet.com.au ([211.29.132.246]:50614 "EHLO mail104.syd.optusnet.com.au" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726231AbfJOWK2 (ORCPT ); Tue, 15 Oct 2019 18:10:28 -0400 Received: from dread.disaster.area (pa49-181-198-88.pa.nsw.optusnet.com.au [49.181.198.88]) by mail104.syd.optusnet.com.au (Postfix) with ESMTPS id 76A1243E690; Wed, 16 Oct 2019 09:10:25 +1100 (AEDT) Received: from dave by dread.disaster.area with local (Exim 4.92.2) (envelope-from ) id 1iKV1N-00013I-1N; Wed, 16 Oct 2019 09:10:25 +1100 Date: Wed, 16 Oct 2019 09:10:25 +1100 From: Dave Chinner To: Christoph Hellwig Cc: "Darrick J . Wong" , Damien Le Moal , Andreas Gruenbacher , linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 12/12] iomap: cleanup iomap_ioend_compare Message-ID: <20191015221025.GF16973@dread.disaster.area> References: <20191015154345.13052-1-hch@lst.de> <20191015154345.13052-13-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191015154345.13052-13-hch@lst.de> User-Agent: Mutt/1.10.1 (2018-07-13) X-Optus-CM-Score: 0 X-Optus-CM-Analysis: v=2.2 cv=D+Q3ErZj c=1 sm=1 tr=0 a=ocld+OpnWJCUTqzFQA3oTA==:117 a=ocld+OpnWJCUTqzFQA3oTA==:17 a=jpOVt7BSZ2e4Z31A5e1TngXxSK0=:19 a=kj9zAlcOel0A:10 a=XobE76Q3jBoA:10 a=20KFwNOVAAAA:8 a=7-415B0cAAAA:8 a=JuDxSlhT3OO6blO4plAA:9 a=CjuIK1q_8ugA:10 a=DBeEp3iAzaEA:10 a=biEYGPWJfzWAr4FL6Ov7:22 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Oct 15, 2019 at 05:43:45PM +0200, Christoph Hellwig wrote: > Move the initialization of ia and ib to the declaration line and remove > a superflous else. > > Signed-off-by: Christoph Hellwig nice little cleanup. Reviewed-by: Dave Chinner -- Dave Chinner david@fromorbit.com