Received: by 2002:a5b:505:0:0:0:0:0 with SMTP id o5csp6910474ybp; Wed, 16 Oct 2019 00:28:50 -0700 (PDT) X-Google-Smtp-Source: APXvYqzznYXs82EYjAJiL2PZteT4jajKA/87viX89FhXadLDAD1CqWbg0lBVUp0k7+EETSXCP2o+ X-Received: by 2002:a17:907:393:: with SMTP id ss19mr37884983ejb.62.1571210930393; Wed, 16 Oct 2019 00:28:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1571210930; cv=none; d=google.com; s=arc-20160816; b=ASBQFuNjBx5F1D4rJJqe79lrcdO2GTlkBm2Piau/lvud/7y7xgyz9UxNu+Gs1mUGQn 2rgHaOHL8r3w9dedcIRoHTY+ixB3jNrcacEWLK3IFFB7D2w2I/vMp1nS5YaJGZaIxchw JcwYAIzryolgY124Z46d+raBRMMvfIrQJcMEq56gB4r82KeQS72DUmdr+EcBGS93oEqF gRoBFDG52m7NQgbyvemsYy1pKcey6QBV9mnHCAWlardlQS6NCt6dhIiOLEbtKPZL6nTC PFJF55ttQsthPmr5C6Y6YtFYidgfQpE28Y5UehKbR3qBfnJU1l/OwabovHIy5/rDEkNc Y+4g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=igJfeABa6M5mmcDSZ9XAWyfxDlpeT34TBKS5Vu4WYQ8=; b=eLmsVQhZM/eAPuNz+og9lw705ZcZZxQu+lvYcz7b7cCjwo2p/tg7lnAyYj1DFPQalF KJBGa8zQnwXYZuFUy5qIdGH6kya13Wy0oGmRwk+XEhsrA2LHeq9zVYPFACQWRj43kBh6 4aldONJSTKZGAwIhPL+hc8yjFnkPYEAsWgAxmFRstenlTFkLEYqtE+C+dmO6S/mDn9lk 8GqeZ7gszOa2GzS+T0qc/+LKWESn/eMaM9oaG+N8sVIlE63QNZ9q4eNz4xehd9OLJJRg PSefRsV1kYfId296/eq8OuCACHiK2rKslfWn9sCzfV0JQUJvDZUJFW0DKI0t7o9Yqe1O 0Ndw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=google header.b="LIYdbK/W"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d58si15419570eda.62.2019.10.16.00.28.27; Wed, 16 Oct 2019 00:28:50 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=google header.b="LIYdbK/W"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389237AbfJOWVJ (ORCPT + 99 others); Tue, 15 Oct 2019 18:21:09 -0400 Received: from mail-lj1-f194.google.com ([209.85.208.194]:41427 "EHLO mail-lj1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731275AbfJOWVI (ORCPT ); Tue, 15 Oct 2019 18:21:08 -0400 Received: by mail-lj1-f194.google.com with SMTP id f5so21891503ljg.8 for ; Tue, 15 Oct 2019 15:21:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=igJfeABa6M5mmcDSZ9XAWyfxDlpeT34TBKS5Vu4WYQ8=; b=LIYdbK/WEFGMNdD+uIGw2BasCdPDikOSk/1C31c/6KJAoWeweWvBbkEnJF4PHN8TkH BgZdUCf/ZYXj115hlOqd/koyMkdZG6Il9yGalmukOiV4kTIOYCVZSlLQpLqR2NWtyVYg nGZ/n1OZmV0DBw+aQ4pzCSwYlzFEdDM+SUZEQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=igJfeABa6M5mmcDSZ9XAWyfxDlpeT34TBKS5Vu4WYQ8=; b=CeT2bHSszxNJED9uxFPE1JjgKycdhcAdzH0qncRq/a0tTAc/O05rrKTJzf7etZujUn AC/JAt58LtjEm+CrnN2qgUVZAUizBF+6M4ijJVbfhV2dDKx4JLAPj+5YLZfzvAOtGKNK 12cKqVyXGB3hA3+Zk46H8Y6pOtA5i7fp6msckQFvHxhsA5ez5GRoAtX8rhFz+bUClmiD 3goe1y2Ys1a8bClS9BBd26dv1iDczK20H31I1m4hQYEXasVCvTu8nEHIflEicZhp6TXy cpIFaH52iDDc2kUBV2vk+LXxmtulvx4mpjZfdsfobv08ERIsqu+IVVJXJpsTeAi5e8Rs HIWA== X-Gm-Message-State: APjAAAWTDccluyVd3dgvzR6+leSCN2KmB0MFyD/WCTUQH0rJp6JXupeS EaYHNGKM+BdUJGocvYqwiNXct+O9EpE= X-Received: by 2002:a2e:91c3:: with SMTP id u3mr23005194ljg.177.1571178065100; Tue, 15 Oct 2019 15:21:05 -0700 (PDT) Received: from mail-lf1-f45.google.com (mail-lf1-f45.google.com. [209.85.167.45]) by smtp.gmail.com with ESMTPSA id v7sm5381896lfd.55.2019.10.15.15.21.03 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 15 Oct 2019 15:21:03 -0700 (PDT) Received: by mail-lf1-f45.google.com with SMTP id q12so15700882lfc.11 for ; Tue, 15 Oct 2019 15:21:03 -0700 (PDT) X-Received: by 2002:ac2:43a8:: with SMTP id t8mr22573654lfl.134.1571178063150; Tue, 15 Oct 2019 15:21:03 -0700 (PDT) MIME-Version: 1.0 References: <157117606853.15019.15459271147790470307.stgit@warthog.procyon.org.uk> <157117614109.15019.15677943675625422728.stgit@warthog.procyon.org.uk> In-Reply-To: <157117614109.15019.15677943675625422728.stgit@warthog.procyon.org.uk> From: Linus Torvalds Date: Tue, 15 Oct 2019 15:20:47 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [RFC PATCH 08/21] pipe: Check for ring full inside of the spinlock in pipe_write() To: David Howells Cc: Casey Schaufler , Stephen Smalley , Greg Kroah-Hartman , Nicolas Dichtel , raven@themaw.net, Christian Brauner , keyrings@vger.kernel.org, linux-usb@vger.kernel.org, linux-block , LSM List , linux-fsdevel , Linux API , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Oct 15, 2019 at 2:49 PM David Howells wrote: > > + if (head - pipe->tail == buffers) { Can we just have helper inline functions for these things? You describe them in the commit message of 03/21 (good), but it would be even better if the code was just self-describing.. Linus