Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Tue, 15 Oct 2019 15:39:55 -0700
From:   Jakub Kicinski <jakub.kicinski@netronome.com>
To:     Scott Branden <scott.branden@broadcom.com>
Cc:     Florian Fainelli <f.fainelli@gmail.com>, netdev@vger.kernel.org,
        phil@raspberrypi.org, jonathan@raspberrypi.org,
        matthias.bgg@kernel.org, linux-rpi-kernel@lists.infradead.org,
        wahrenst@gmx.net, nsaenzjulienne@suse.de,
        Doug Berger <opendmb@gmail.com>,
        "David S. Miller" <davem@davemloft.net>,
        bcm-kernel-feedback-list@broadcom.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v2] net: bcmgenet: Generate a random MAC if
 none is valid
Message-ID: <20191015153955.2e602903@cakuba.netronome.com>
In-Reply-To: <dda8587a-0734-d294-5b50-0f5f35c27918@broadcom.com>
References: <20191014212000.27712-1-f.fainelli@gmail.com>
        <dda8587a-0734-d294-5b50-0f5f35c27918@broadcom.com>
Organization: Netronome Systems, Ltd.
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, 15 Oct 2019 15:32:28 -0700, Scott Branden wrote:
> > @@ -3482,7 +3476,12 @@ static int bcmgenet_probe(struct platform_device=
 *pdev)
> >  =20
> >   	SET_NETDEV_DEV(dev, &pdev->dev);
> >   	dev_set_drvdata(&pdev->dev, dev);
> > -	ether_addr_copy(dev->dev_addr, macaddr);
> > +	if (IS_ERR_OR_NULL(macaddr) || !is_valid_ether_addr(macaddr)) {
> > +		dev_warn(&pdev->dev, "using random Ethernet MAC\n"); =20
>=20
> I would still consider this warrants a dev_err as you should not be=20
> using the device with a random MAC address assigned to it.=C2=A0 But I'll=
=20
> leave it to the "experts" to decide on the print level here.

FWIW I'd stick to warn for this message since this is no longer a hard
failure.