Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Tue, 15 Oct 2019 17:04:59 -0700 (PDT)
Message-Id: <20191015.170459.2090609203514838368.davem@davemloft.net>
To:     jakub.kicinski@netronome.com
Cc:     scott.branden@broadcom.com, f.fainelli@gmail.com,
        netdev@vger.kernel.org, phil@raspberrypi.org,
        jonathan@raspberrypi.org, matthias.bgg@kernel.org,
        linux-rpi-kernel@lists.infradead.org, wahrenst@gmx.net,
        nsaenzjulienne@suse.de, opendmb@gmail.com,
        bcm-kernel-feedback-list@broadcom.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v2] net: bcmgenet: Generate a random MAC if
 none is valid
From:   David Miller <davem@davemloft.net>
In-Reply-To: <20191015153955.2e602903@cakuba.netronome.com>
References: <20191014212000.27712-1-f.fainelli@gmail.com>
        <dda8587a-0734-d294-5b50-0f5f35c27918@broadcom.com>
        <20191015153955.2e602903@cakuba.netronome.com>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=iso-8859-1
Content-Transfer-Encoding: 8BIT
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

From: Jakub Kicinski <jakub.kicinski@netronome.com>
Date: Tue, 15 Oct 2019 15:39:55 -0700

> On Tue, 15 Oct 2019 15:32:28 -0700, Scott Branden wrote:
>> > @@ -3482,7 +3476,12 @@ static int bcmgenet_probe(struct platform_device *pdev)
>> >   
>> >   	SET_NETDEV_DEV(dev, &pdev->dev);
>> >   	dev_set_drvdata(&pdev->dev, dev);
>> > -	ether_addr_copy(dev->dev_addr, macaddr);
>> > +	if (IS_ERR_OR_NULL(macaddr) || !is_valid_ether_addr(macaddr)) {
>> > +		dev_warn(&pdev->dev, "using random Ethernet MAC\n");  
>> 
>> I would still consider this warrants a dev_err as you should not be 
>> using the device with a random MAC address assigned to it.? But I'll 
>> leave it to the "experts" to decide on the print level here.
> 
> FWIW I'd stick to warn for this message since this is no longer a hard
> failure.

Agreed.