Received: by 2002:a5b:505:0:0:0:0:0 with SMTP id o5csp7070203ybp; Wed, 16 Oct 2019 03:23:37 -0700 (PDT) X-Google-Smtp-Source: APXvYqzYkWnaGl4kckRqqy1kZSv6+2O4bZdgxo8wwh5F2H0crl2LeGDZR9bwqhhagFDxrtRQtI2m X-Received: by 2002:a17:906:b314:: with SMTP id n20mr40458862ejz.11.1571221417110; Wed, 16 Oct 2019 03:23:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1571221417; cv=none; d=google.com; s=arc-20160816; b=fEwo5bArITWGA4D9r8JXWbnz5HQ29hGPB1+vtEuGaU+Bu+W5XOq7Hibo1beVy6vVVi SvSLG415VCZmwItyy3khBpT316sBT7vFvHHygEFXju8TfN5D2xOZC9fFLQ9onCfAzlv6 Qr3Xfu+zPeA71Z1NUs8SBJCgBPr0z+QEu14U6zEHL2caB2Z4zb90UOZvlGm5Zd9H1e/2 0kE2ciwY+1wtisgwIqsoxVdh1FQ5/zMf8NsZ5itRJaZ2sPMPyu2RTDbX2bkJ4HnzdPD5 FrSUsZ0pfBdej82/tOz20ADZ663ASlEatuuRfZAVZUGABytPs9gt1/rsdD88/O/H7FAy oGWg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=QC3gEZR1hPeoV9cErrVTRBwhQgxMJw1kOt/RcyP6C6w=; b=b/vBQzH8fUi17LXCaTjTTvRsrvhnByp2li6+so24SVJ6g+qkRxOJaX5XatowwC46mo yF2vw6ewDG7dR8ZkRMFhevwnZf0sJP2MEnYouEdgNIiJMWmdWSvb0QG6WICGT+u7i84G kw1J+CWXt8SySrAkLhqM5tpgHM6eLA+8QTTId2vBXtB5alRoaYWhwlZ2D3+67oIedfLr 1a6VQeUVH2/yG/tsVN12GqwU3X2yC+5kg2Qqh0pvg05m9osMo45fPrWJIWVM9fQ2nmX9 bPRZd1ZQU83itgKjzn6v4++AmvzTh5jr+h6hZaKxCVbWfYiKK2mhkR6HCzFtTfEGVHPD pfXg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@networkplumber-org.20150623.gappssmtp.com header.s=20150623 header.b=1w0IOtYf; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id v14si19022132ede.424.2019.10.16.03.23.13; Wed, 16 Oct 2019 03:23:36 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@networkplumber-org.20150623.gappssmtp.com header.s=20150623 header.b=1w0IOtYf; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729894AbfJPCFE (ORCPT + 99 others); Tue, 15 Oct 2019 22:05:04 -0400 Received: from mail-pf1-f196.google.com ([209.85.210.196]:37145 "EHLO mail-pf1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726534AbfJPCFD (ORCPT ); Tue, 15 Oct 2019 22:05:03 -0400 Received: by mail-pf1-f196.google.com with SMTP id y5so13675195pfo.4 for ; Tue, 15 Oct 2019 19:05:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=QC3gEZR1hPeoV9cErrVTRBwhQgxMJw1kOt/RcyP6C6w=; b=1w0IOtYfvSoz2t35HiCfmWEBG/6NZWQDRGyT9mxsztX6Py9Chwl0498ydNjJh0c//p /pUv8LxQNVibIrycGvKocjulsnsWN/vrTMaIcY1fIUvc31ZU4qCJbyuLdDBntXMOE97d CyZP6VcCp7aR21Vyf109i5U2fhry6UYaMZg/lPZnzoxThrZk2aILiB6YLGoeDlXfwUCp WZ55aOfZvtWNYwrk3OErtEE+rJS+BVioCM6nZOf2QnanyzFj9ftGRv/hZAkzpU6ZzsaG hnJoKhQL2U4Vq2icAfQqb45uaJqw1uM7uoNVkHL4LUEWI48WHdO77tRksqhZaU97DX4U 8dTA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=QC3gEZR1hPeoV9cErrVTRBwhQgxMJw1kOt/RcyP6C6w=; b=sCh7mD5y+yXNBpsydq3sm83qyoVxaa+U8lmehKwyTyNA9xfoggRrKDdnvyV4/XqPlq kyIt49966pihPJyqpqd6xI1YfkQ46RZy1G8TDpA8yzcQb0rkLo8XAEmY9tSAGwA4sX3m XqHx2s+KVFfQB/TS4PzJkUO5OzFeBMiF2hBEf4n47dXzRuJ8qHZv0teFm+B5ZRAqp/D4 uB4bWiMvhwZPL3WSbe/+2JxSSeUIAOwvjy9KuT8Pd9U3pBCb5nY5YnDMDVoSQpXkge5L q1RVczfvmIvNMEolrkeIlfKLQCbtQ2KJgb0lYwxLItZ+xxWqT1mM7IVvN10C1WaIpVEw qeiw== X-Gm-Message-State: APjAAAXfGZ+56Z4/i25Irv0Ziq78s6jN1/I9jAxIN7CtRJ7GBh5cjYqq AL9/yPyM5E5QeT92N/Vz/Av9mw== X-Received: by 2002:a63:3c3:: with SMTP id 186mr22567709pgd.285.1571191502725; Tue, 15 Oct 2019 19:05:02 -0700 (PDT) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id 16sm21264196pfn.35.2019.10.15.19.05.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Oct 2019 19:05:02 -0700 (PDT) Date: Tue, 15 Oct 2019 19:04:55 -0700 From: Stephen Hemminger To: Zhu Lingshan Cc: mst@redhat.com, jasowang@redhat.com, alex.williamson@redhat.com, linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, netdev@vger.kernel.org, dan.daly@intel.com, cunming.liang@intel.com, tiwei.bie@intel.com, jason.zeng@intel.com, zhiyuan.lv@intel.com Subject: Re: [RFC 1/2] vhost: IFC VF hardware operation layer Message-ID: <20191015190455.0d79b836@hermes.lan> In-Reply-To: <20191016010318.3199-2-lingshan.zhu@intel.com> References: <20191016010318.3199-1-lingshan.zhu@intel.com> <20191016010318.3199-2-lingshan.zhu@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 16 Oct 2019 09:03:17 +0800 Zhu Lingshan wrote: > +int ifcvf_init_hw(struct ifcvf_hw *hw, struct pci_dev *dev) > +{ > + int ret; > + u8 pos; > + struct virtio_pci_cap cap; > + u32 i; > + u16 notify_off; For network code, the preferred declaration style is reverse christmas tree.