Received: by 2002:a5b:505:0:0:0:0:0 with SMTP id o5csp7070606ybp; Wed, 16 Oct 2019 03:24:07 -0700 (PDT) X-Google-Smtp-Source: APXvYqy8zha7Y+1zYVgJOXMg2bV5qVaw96+cW0AwvMwKj2uICyKARtiE4CmI3iIqIldgHeoahz2n X-Received: by 2002:a17:906:4448:: with SMTP id i8mr3869860ejp.298.1571221447797; Wed, 16 Oct 2019 03:24:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1571221447; cv=none; d=google.com; s=arc-20160816; b=JTTeHHW4+OziOmCTmZ2TVR/NRMIJ2Eg6vSfxTcxG3fpHO4lmOKuRVS+NRLYfkdLj8W xDzcruMMNa9KvPSrlrvEZlzkYlfdUHgoEpy92b27Ouo8j7aX6VnFzMm4qUoPPPerGUa/ V+qyOgg/9lrlcX4TZX8GIvnWCzlu3f4LoixSsiN62ztNJRw7eiHov2sVgX4L2twJuCV8 WgIx1O5ZoFOSAZVVjfMMTEncuNuyHTUkW8zEKs/OgbYPbGPyW45faYssUEpLLMZl0awB HzkKDivo19SqLcVDe7rceisBBTMqCmKJ6jVX6Q9PyKGDTvHMrUjXlnnWpX2j3x3DnmfN tfSw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=UUyOL2RIItCROatK1a3xuyc4JsvfPMONoizipcHDbl0=; b=hVPtl0SdNSRPev8Bu6EbF4jQxYo2wqRmBSqshkPUMxLyj9O81d6t1Mg2wGSJKBbGNA sDw8YiVAexST43BmO6OpMh+W998hqpwCv32365cj/SmCo1TBBPzphvALQN859K6zccHj D9F0uq3/hZECvw6i0VoDWEUo9O7R/aidjPAVo6A9ZwfXMRKad36UZcBGOMdFs2uqxt/r COXXGLrQJvxrZ/7H7MQAaYCVKHa0NLVbSxji54MT3UZQtwO9BVe35JrTyIFJLeF/DAOs NGif00KnWmsMCkOUjyR9fp+mwEQXbv9LHC0u+0RMN67aOUg9sXkTlSCcNMcNhOkOgFi2 wfDg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@networkplumber-org.20150623.gappssmtp.com header.s=20150623 header.b=SeWXto8T; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id c9si14396099eds.211.2019.10.16.03.23.44; Wed, 16 Oct 2019 03:24:07 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@networkplumber-org.20150623.gappssmtp.com header.s=20150623 header.b=SeWXto8T; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388966AbfJPCGx (ORCPT + 99 others); Tue, 15 Oct 2019 22:06:53 -0400 Received: from mail-pg1-f194.google.com ([209.85.215.194]:33857 "EHLO mail-pg1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726534AbfJPCGw (ORCPT ); Tue, 15 Oct 2019 22:06:52 -0400 Received: by mail-pg1-f194.google.com with SMTP id k20so5934294pgi.1 for ; Tue, 15 Oct 2019 19:06:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=UUyOL2RIItCROatK1a3xuyc4JsvfPMONoizipcHDbl0=; b=SeWXto8TKxbAR5Gk7e3/sNJ93alMjzCClvODSG30bXgpV//NkHjE/CrxFes/2PuIrm 1ZaQoszX9l1cAIP0YZMAAg5IL5/aO/IYZYBwvSGvB8Ed7iN6v4mpuy8jvNosThAVKik3 xrlKdq3W/y91a7mk7btm2RdUK9Kj2pweOZnt0KNfktRKvuLLPpuoffdYEqWQeTXFeM9H XRe11OkLfpHKgnnaJeIiX4MRA3hTvwECaamHV2EBqsDpjsDtYmdpTaf/mgzaAwlX8mhV GDnn7eaZ8tFe2FaLPpRBUYzBxEiSvp7VWuxu1IsKoiM5LJUYQLwaUNzAhg14u1/Uutok niFQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=UUyOL2RIItCROatK1a3xuyc4JsvfPMONoizipcHDbl0=; b=SWqHGgUAeCHmO8l/LCzJWnUjVLi2QszOVIELhojSxFnWZKXZPoG5qqA9LiBKQhx+2E xhpmH9YT/TJtSTMXW7zxfyCB11Nep3sdC1lClb7JV7rnKTYbVQPIQgiFYAeGxRrwSnaX 1LvizKZ2WeTHRIX8ekJg8hXwtV/bQt2GWvv5i7ZQdrW+7ePBavuhV7Sx3R4btKJf3+Q9 gQ6ukD6NvvraDxTLOdoeooIIVpNx1lwLKMqDJyYtjf8Cezl93txrPBnvmzHbtR4YYpKt iGjmUs4x2xQe0mfDp7ciUTgwX4PAkJ6LEZZhfddVst70iJOA/g1yN71rUVzK+vrQ1zOK zQJw== X-Gm-Message-State: APjAAAUEjpyvamOjeOCqIEcxKJn1Gt3+/O1Ore8Q5H0ZAuYES6ol5STb He5FVx0BSob2pxBYY8QQH6xiKA== X-Received: by 2002:a17:90a:ff0f:: with SMTP id ce15mr1971060pjb.14.1571191611965; Tue, 15 Oct 2019 19:06:51 -0700 (PDT) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id e16sm11583122pgt.68.2019.10.15.19.06.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Oct 2019 19:06:51 -0700 (PDT) Date: Tue, 15 Oct 2019 19:06:49 -0700 From: Stephen Hemminger To: Zhu Lingshan Cc: mst@redhat.com, jasowang@redhat.com, alex.williamson@redhat.com, linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, netdev@vger.kernel.org, dan.daly@intel.com, cunming.liang@intel.com, tiwei.bie@intel.com, jason.zeng@intel.com, zhiyuan.lv@intel.com Subject: Re: [RFC 1/2] vhost: IFC VF hardware operation layer Message-ID: <20191015190649.54ddc91c@hermes.lan> In-Reply-To: <20191016010318.3199-2-lingshan.zhu@intel.com> References: <20191016010318.3199-1-lingshan.zhu@intel.com> <20191016010318.3199-2-lingshan.zhu@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 16 Oct 2019 09:03:17 +0800 Zhu Lingshan wrote: > + IFC_INFO(&dev->dev, "PCI capability mapping:\n" > + "common cfg: %p\n" > + "notify base: %p\n" > + "isr cfg: %p\n" > + "device cfg: %p\n" > + "multiplier: %u\n", > + hw->common_cfg, > + hw->notify_base, > + hw->isr, > + hw->dev_cfg, > + hw->notify_off_multiplier); Since kernel messages go to syslog, syslog does not handle multi-line messages very well. This should be a single line. Also, this is the kind of message that should be at the debug level; something that is useful to the driver developers but not something that needs to be filling up every end users log.