Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
To:     "Ben Dooks (Codethink)" <ben.dooks@codethink.co.uk>,
        "linux-kernel@lists.codethink.co.uk" 
        <linux-kernel@lists.codethink.co.uk>
CC:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Simon Horman <horms+renesas@verge.net.au>,
        Geert Uytterhoeven <geert+renesas@glider.be>,
        "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] usb: renesas_usbhs: fix __le16 warnings
Thread-Topic: [PATCH] usb: renesas_usbhs: fix __le16 warnings
Thread-Index: AQHVg3BX7WaejZzh5Uuo1PfP1tSBgKdcjXRg
Date:   Wed, 16 Oct 2019 02:35:07 +0000
Message-ID: <TYAPR01MB4544032F002C7B28E2ED5A19D8920@TYAPR01MB4544.jpnprd01.prod.outlook.com>
References: <20191015155044.11858-1-ben.dooks@codethink.co.uk>
In-Reply-To: <20191015155044.11858-1-ben.dooks@codethink.co.uk>
Accept-Language: ja-JP, en-US
Content-Language: ja-JP
received-spf: None (protection.outlook.com: renesas.com does not designate
 permitted sender hosts)
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 7b6baa9f-f557-426b-86c4-08d751e17598
X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Oct 2019 02:35:07.5977
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 53d82571-da19-47e4-9cb4-625a166a4a2a
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 6IzPw/gTRXSYVMH1zh+wy2JM/ofVCRDwIYOXeiJhCkVfdCmyRv7sB6OFuThgOPU5JIubcTiPfitVTm/IULwglS6WW4jbEUnhrcjsc5t5vl5c7XNhScyf96nytGn/lfOg
X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYAPR01MB2767
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Ben,

> From: Ben Dooks (Codethink), Sent: Wednesday, October 16, 2019 12:51 AM
>=20
> Fix the warnings generated by casting to/from __le16 without
> using the correct functions.
>=20
> Fixes the following sparse warnings:
>=20
> drivers/usb/renesas_usbhs/common.c:165:25: warning: incorrect type in ass=
ignment (different base types)
> drivers/usb/renesas_usbhs/common.c:165:25:    expected restricted __le16 =
[usertype] wValue
> drivers/usb/renesas_usbhs/common.c:165:25:    got unsigned short
> drivers/usb/renesas_usbhs/common.c:166:25: warning: incorrect type in ass=
ignment (different base types)
> drivers/usb/renesas_usbhs/common.c:166:25:    expected restricted __le16 =
[usertype] wIndex
> drivers/usb/renesas_usbhs/common.c:166:25:    got unsigned short
> drivers/usb/renesas_usbhs/common.c:167:25: warning: incorrect type in ass=
ignment (different base types)
> drivers/usb/renesas_usbhs/common.c:167:25:    expected restricted __le16 =
[usertype] wLength
> drivers/usb/renesas_usbhs/common.c:167:25:    got unsigned short
> drivers/usb/renesas_usbhs/common.c:173:39: warning: incorrect type in arg=
ument 3 (different base types)
> drivers/usb/renesas_usbhs/common.c:173:39:    expected unsigned short [us=
ertype] data
> drivers/usb/renesas_usbhs/common.c:173:39:    got restricted __le16 [user=
type] wValue
> drivers/usb/renesas_usbhs/common.c:174:39: warning: incorrect type in arg=
ument 3 (different base types)
> drivers/usb/renesas_usbhs/common.c:174:39:    expected unsigned short [us=
ertype] data
> drivers/usb/renesas_usbhs/common.c:174:39:    got restricted __le16 [user=
type] wIndex
> drivers/usb/renesas_usbhs/common.c:175:39: warning: incorrect type in arg=
ument 3 (different base types)
> drivers/usb/renesas_usbhs/common.c:175:39:    expected unsigned short [us=
ertype] data
>=20
> Note. I belive this to be correct, and should be a no-op on arm.
>=20
> Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>

Thank you for the patch!

Reviewed-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>

Best regards,
Yoshihiro Shimoda