Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Received-SPF: TempError (protection.outlook.com: error in processing during
 lookup of arm.com: DNS Timeout)
From:   "Jianyong Wu (Arm Technology China)" <Jianyong.Wu@arm.com>
To:     Mark Rutland <Mark.Rutland@arm.com>
CC:     "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "yangbo.lu@nxp.com" <yangbo.lu@nxp.com>,
        "john.stultz@linaro.org" <john.stultz@linaro.org>,
        "tglx@linutronix.de" <tglx@linutronix.de>,
        "pbonzini@redhat.com" <pbonzini@redhat.com>,
        "sean.j.christopherson@intel.com" <sean.j.christopherson@intel.com>,
        "maz@kernel.org" <maz@kernel.org>,
        "richardcochran@gmail.com" <richardcochran@gmail.com>,
        "will@kernel.org" <will@kernel.org>,
        Suzuki Poulose <Suzuki.Poulose@arm.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "kvmarm@lists.cs.columbia.edu" <kvmarm@lists.cs.columbia.edu>,
        "kvm@vger.kernel.org" <kvm@vger.kernel.org>,
        Steve Capper <Steve.Capper@arm.com>,
        "Kaly Xin (Arm Technology China)" <Kaly.Xin@arm.com>,
        "Justin He (Arm Technology China)" <Justin.He@arm.com>,
        nd <nd@arm.com>
Subject: RE: [PATCH v5 1/6] psci: Export psci_ops.conduit symbol as modules
 will use it.
Thread-Topic: [PATCH v5 1/6] psci: Export psci_ops.conduit symbol as modules
 will use it.
Thread-Index: AQHVg0YvYzzWm5D4UkuNpSkRp5s31Kdb9F2AgACvT8A=
Date:   Wed, 16 Oct 2019 03:54:11 +0000
Message-ID: <HE1PR0801MB1676A17D66AE91F7E0792877F4920@HE1PR0801MB1676.eurprd08.prod.outlook.com>
References: <20191015104822.13890-1-jianyong.wu@arm.com>
 <20191015104822.13890-2-jianyong.wu@arm.com>
 <20191015172453.GE24604@lakrids.cambridge.arm.com>
In-Reply-To: <20191015172453.GE24604@lakrids.cambridge.arm.com>
Accept-Language: en-US
Content-Language: en-US
Authentication-Results-Original: spf=none (sender IP is )
 smtp.mailfrom=Jianyong.Wu@arm.com; 
received-spf: None (protection.outlook.com: arm.com does not designate
 permitted sender hosts)
X-Microsoft-Antispam-Message-Info-Original: gZc36TzA4pOPtQ/n+KbDvf/sYvv2PdXcXgjX5d4rztmaSTkhTw/Y3u/UtztCrMGqCoLRk9ue5AwlZODp15z8+81BaTWY4P0USBUKDEcbWZDLX8mdVeCrS7wuHxt6JhrgPxBzqiJIkKdCWKRfKu6Mel+iYN6Yj4l2w5axevVROn45EL+2AeW1+26NaK5M6IAZKp6B7rWSOm++Ci45LfOlSqYaDb3Y+u4Gk5qg/oWVsHEomU/ePYZvuwGssKgRE/f6l62BDAEczEQYzyFsKXTLcJi3Jnc2LSY73TgI6kl0A/MJYVo4dWYz/dQU3IEphRFu34uhINWxTbbUCU5OQ5qDIS/klfibsC4ytjdabTINVO/ovNCrZqWVt0nvztpeETJclIprszrF5/vQUC8NlmpcO/Uhi0Bj56I7BpwTA8de5KhY8nVXv9TqPAf6x7WkF8sCRz+d+hp/Ml7K91CZ4IFyBA==
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0801MB1945
Original-Authentication-Results: spf=none (sender IP is )
 smtp.mailfrom=Jianyong.Wu@arm.com; 
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT040.eop-EUR03.prod.protection.outlook.com
X-Forefront-Antispam-Report: CIP:63.35.35.123;IPV:CAL;SCL:-1;CTRY:IE;EFV:NLI;SFV:NSPM;SFS:(10009020)(4636009)(396003)(39860400002)(376002)(346002)(136003)(13464003)(189003)(199004)(102836004)(22756006)(53546011)(76176011)(450100002)(46406003)(86362001)(9686003)(33656002)(97756001)(316002)(63350400001)(446003)(229853002)(36906005)(6506007)(99286004)(8746002)(54906003)(66066001)(5660300002)(26005)(26826003)(478600001)(7696005)(8936002)(47776003)(186003)(23726003)(81166006)(81156014)(55016002)(6636002)(6116002)(6246003)(76130400001)(6306002)(476003)(14444005)(966005)(3846002)(52536014)(14454004)(8676002)(486006)(356004)(336012)(2906002)(70586007)(4326008)(25786009)(74316002)(50466002)(11346002)(126002)(6862004)(305945005)(70206006)(7736002);DIR:OUT;SFP:1101;SCL:1;SRVR:DBBPR08MB4871;H:64aa7808-outbound-1.mta.getcheckrecipient.com;FPR:;SPF:TempError;LANG:en;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;MX:1;A:1;
X-MS-Office365-Filtering-Correlation-Id-Prvs: b96f3795-012e-474d-870d-08d751ec814b
NoDisclaimer: True
X-Forefront-PRVS: 0192E812EC
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: cxWWC8UiwXyvwJ5MS9bAAqM4BFFpVx9IX4dR/srS3vXfwt1GdI25B2vjU8iysKddiKfLNnlcoVN+IsAqv1GDGodvLFXzEXnFuDJUktVahJviMXGVDzrxXVZTRBCOs7aEaTJT41LYJo7F4Lgr9pe4ZQRZyiqdTLWB3t47LQELVr79rZXy86pAzH6FsyQbzWiHuebxWf1RIBwparKNqITZwj3U/1aEKyFuCMt6ppzKrNLMY3hrFelJU7wKhZDSkJVi9y7ROVxE5heE/ke2PGW9+2XsDE+RLtpP0Kg2Z+VHCM1T4yQBvv57pYGmBMTNqxjw98HwiHPB7OICEHC2ddMd6+oaTS53i2wgOjPBD5EuoKczkgQaR1yQntmlNFgOdGUlxnQSix9SmlABinPIKLGAln9Ef8dEWFm6+ol2ufJ1G+cBKDzvjka/fb6sLw2djDK4fSdV6Ryin5n13QMwDfG55Q==
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Oct 2019 03:54:24.4866
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 4d3fe8a3-477b-4ffd-056c-08d751ec88de
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR08MB4871
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Mark,

> -----Original Message-----
> From: Mark Rutland <mark.rutland@arm.com>
> Sent: Wednesday, October 16, 2019 1:25 AM
> To: Jianyong Wu (Arm Technology China) <Jianyong.Wu@arm.com>
> Cc: netdev@vger.kernel.org; yangbo.lu@nxp.com; john.stultz@linaro.org;
> tglx@linutronix.de; pbonzini@redhat.com; sean.j.christopherson@intel.com;
> maz@kernel.org; richardcochran@gmail.com; will@kernel.org; Suzuki
> Poulose <Suzuki.Poulose@arm.com>; linux-kernel@vger.kernel.org; linux-
> arm-kernel@lists.infradead.org; kvmarm@lists.cs.columbia.edu;
> kvm@vger.kernel.org; Steve Capper <Steve.Capper@arm.com>; Kaly Xin
> (Arm Technology China) <Kaly.Xin@arm.com>; Justin He (Arm Technology
> China) <Justin.He@arm.com>; nd <nd@arm.com>
> Subject: Re: [PATCH v5 1/6] psci: Export psci_ops.conduit symbol as modul=
es
> will use it.
>=20
> On Tue, Oct 15, 2019 at 06:48:17PM +0800, Jianyong Wu wrote:
> > If arm_smccc_1_1_invoke used in modules, psci_ops.conduit should be
> > export.
> >
> > Signed-off-by: Jianyong Wu <jianyong.wu@arm.com>
>=20
> I have a patch queued [1] in the arm64 tree which adds
> arm_smccc_1_1_get_conduit() for this purpose.
>=20
> Please use that, adding an EXPORT_SYMBOL() if necessary.
>=20

Great, I will apply it next version.

Thanks
Jianyong Wu

> Thanks,
> Mark.
>=20
> [1]
> https://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git/commit/?h=
=3D
> for-next/smccc-conduit-
> cleanup&id=3D6b7fe77c334ae59fed9500140e08f4f896b36871
>=20
> > ---
> >  drivers/firmware/psci/psci.c | 6 ++++++
> >  include/linux/arm-smccc.h    | 2 +-
> >  include/linux/psci.h         | 1 +
> >  3 files changed, 8 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/firmware/psci/psci.c
> > b/drivers/firmware/psci/psci.c index f82ccd39a913..35c4eaab1451 100644
> > --- a/drivers/firmware/psci/psci.c
> > +++ b/drivers/firmware/psci/psci.c
> > @@ -212,6 +212,12 @@ static unsigned long
> psci_migrate_info_up_cpu(void)
> >  			      0, 0, 0);
> >  }
> >
> > +enum psci_conduit psci_get_conduit(void) {
> > +	return psci_ops.conduit;
> > +}
> > +EXPORT_SYMBOL(psci_get_conduit);
> > +
> >  static void set_conduit(enum psci_conduit conduit)  {
> >  	switch (conduit) {
> > diff --git a/include/linux/arm-smccc.h b/include/linux/arm-smccc.h
> > index 552cbd49abe8..a6e4d3e3d10a 100644
> > --- a/include/linux/arm-smccc.h
> > +++ b/include/linux/arm-smccc.h
> > @@ -357,7 +357,7 @@ asmlinkage void __arm_smccc_hvc(unsigned long
> a0, unsigned long a1,
> >   * The return value also provides the conduit that was used.
> >   */
> >  #define arm_smccc_1_1_invoke(...) ({
> 	\
> > -		int method =3D psci_ops.conduit;				\
> > +		int method =3D psci_get_conduit();			\
> >  		switch (method) {					\
> >  		case PSCI_CONDUIT_HVC:
> 	\
> >  			arm_smccc_1_1_hvc(__VA_ARGS__);
> 	\
> > diff --git a/include/linux/psci.h b/include/linux/psci.h index
> > a8a15613c157..e5cedc986049 100644
> > --- a/include/linux/psci.h
> > +++ b/include/linux/psci.h
> > @@ -42,6 +42,7 @@ struct psci_operations {
> >  	enum smccc_version smccc_version;
> >  };
> >
> > +extern enum psci_conduit psci_get_conduit(void);
> >  extern struct psci_operations psci_ops;
> >
> >  #if defined(CONFIG_ARM_PSCI_FW)
> > --
> > 2.17.1
> >