Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Reply-To: hs@denx.de
Subject: Re: [PATCH 2/2] misc: add support for the cc1101 RF transceiver chip
 from TI
To:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc:     linux-kernel@vger.kernel.org, Arnd Bergmann <arnd@arndb.de>,
        Derek Kiernan <derek.kiernan@xilinx.com>,
        Dragan Cvetic <dragan.cvetic@xilinx.com>,
        Jonathan Corbet <corbet@lwn.net>, linux-doc@vger.kernel.org
References: <20190922060356.58763-1-hs@denx.de>
 <20190922060356.58763-3-hs@denx.de> <20191011064342.GA1045420@kroah.com>
From:   Heiko Schocher <hs@denx.de>
Message-ID: <da8890e0-e727-ba2b-bc5e-faad327de4d8@denx.de>
Date:   Wed, 16 Oct 2019 06:44:37 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.5.2
MIME-Version: 1.0
In-Reply-To: <20191011064342.GA1045420@kroah.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hello Greg,

Am 11.10.2019 um 08:43 schrieb Greg Kroah-Hartman:
> On Sun, Sep 22, 2019 at 08:03:56AM +0200, Heiko Schocher wrote:
>> +struct __attribute__ ((packed)) msg_queue_user {
>> +	int	type; /* CC1101_MSG_SET_ */
>> +};
>> +
>> +/* CC1101_MSG_DEFINE_CONFIG */
>> +struct __attribute__ ((packed)) config_param {
>> +	char addr;
>> +	char val;
>> +};
> 
> {sigh}

Sorry for that ...

> None of these structures are valid ones to be passing to/from
> userspace/kernel at all.  Please fix them up to work properly (i.e. use
> the correct types and such).  I think there's a "how to write a correct
> ioctl" document in the documentation directory somewhere, you might want
> to search for that.

Ok, the driver does not use ioctl only read/write, but the overall
question is, has this driver at all a chance to go into mainline?

I searched for "write a correct" in Documentation but get:

$ grep -lr "write a correct" Documentation/
$

May "Documentation/ioctl/botching-up-ioctls.rst" helps, so I convert
to use the __u* types, thanks!

bye,
Heiko
-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-52   Fax: +49-8142-66989-80   Email: hs@denx.de