Received: by 2002:a5b:505:0:0:0:0:0 with SMTP id o5csp7162792ybp; Wed, 16 Oct 2019 04:51:42 -0700 (PDT) X-Google-Smtp-Source: APXvYqzI/4+1n6HzdUqexr+taSi17t3Kxf2AH3uTIYC9EfpubDlE+WzwVIBoxP+GUazJaBmwVqaz X-Received: by 2002:a17:906:cc87:: with SMTP id oq7mr39992659ejb.123.1571226702521; Wed, 16 Oct 2019 04:51:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1571226702; cv=none; d=google.com; s=arc-20160816; b=rQPsykBTp2dqaNNbj8mx/joZMXZiygNYBdVfRWx8cFilE9BUfViNTOkVvMvE0Cm34L p24TkksNjMJOhP5v7ffaCWWwDOTxbFTZPR+a8Xu508r2rEKfx1P1bGReucEY/ARbolC/ LzuLenncOKrCWoGCqFmkfrCg6Y4lJ9QGTjnX06+vgkxEXMgyYHwI/97BZPlaJxpXve+m vhn/4DoPFjZrLyjlbvQ4rl3ucHH4Y97hU6cGvwk8+XMs3dIFmYFHWejo8fHXrPzdhXVI b61p2GMqDwoqRzyo6SeXkc8VYTxcngGSNNrzDBahZwQFonAAKA8MFe8DiHplKjszhOsr vVTg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-transfer-encoding:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=YRhrTB62D4V/UFoC3f7Dy9VxNzwea0kYw4JJIDyNnSU=; b=Zq/w7g7pcaRSs4XTWspJRaVq3YO9aKqPEb76OaosiIW621b1hNqWymjgzTtF1ERqS4 71JlhaLcQ6rQTLRQ5HVkZiOxaEeSppVPueWFOUQRY3MwfdcCyppYzHuWR7qJciqDcTQb jX7e3+AWgpBBl0X+KOELyLdURR6s/YjtjR0sUqW14p785zORwPwE3DNLqU5lF5GyKatq uhcX3BsPmq9kyMaOj9MwNQ4zPt0Go9ZWqOtj8ffUS9e1qAAU4f/xnCpVwv3Dns/zphgc yjAP9VIaQ3cVYHOzp2LfWSr1ycBnXBfHEo7TvzCIOpau8BevbnpvfnvuTwHH1lADxtdc LV3Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=gffNxPX5; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u8si17169853edb.57.2019.10.16.04.51.19; Wed, 16 Oct 2019 04:51:42 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=gffNxPX5; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387801AbfJPGTB (ORCPT + 99 others); Wed, 16 Oct 2019 02:19:01 -0400 Received: from mail-wr1-f68.google.com ([209.85.221.68]:43193 "EHLO mail-wr1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728313AbfJPGTB (ORCPT ); Wed, 16 Oct 2019 02:19:01 -0400 Received: by mail-wr1-f68.google.com with SMTP id j18so26484760wrq.10 for ; Tue, 15 Oct 2019 23:18:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=YRhrTB62D4V/UFoC3f7Dy9VxNzwea0kYw4JJIDyNnSU=; b=gffNxPX59uLp8d/gUW5M7E6+ht3fLmLfSJgrgYUe1tI7Afeyq6CzJQ+74I6+AmU/z/ LCxua/tgSJOllX2PjdMVZeJvnP0ag9dr/fxDqwqp/VddGOOGCVTOTcUt0EU2EnzWOTqU RxXnz4wgoSk81+fFaU14kCZSCs3zePHw0unCHMU0JPUBY5lIPVNvqiZnZ04YBtvQKgDQ HpdVT8WRcKE9oDhNiAVcKWTT0LS3Yqc1Ultg55vUfNYknQMR/m9KWI0GKJlDKkLdc9rj OdjIf4UnX2hBqQMJACFydhYY7OgZIs841Bu3TJXMwsNzfUGHuD6/H97Ls+FNG+P7MyTQ zYKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=YRhrTB62D4V/UFoC3f7Dy9VxNzwea0kYw4JJIDyNnSU=; b=SNkVaGzRQTlfL6Uf4AtebtGTlLfxiCBnMIknowBGO8V2NQcypfkPUGDiCJ1vsrm3l9 Bynk/OKusOC2vouzvqUrejbiiGYYMADu4SqccDGBmy4ED75iuL2fAQi2oXyRjOCBqNjs 3jtW4kw+HoFj2LonKQ8u/I/xvEQRjcaRSEzU8xCr8dBMT5iYsMPaPRSANga2guel31Bm FHfk2yZs2KeA3ttPKMCFxhg1l7a8Lgt2gcLN/gLyHXcjlaT0cZEZ9m7UlhA/6JMp1Qf/ fXVzUJ2/MB+3E5+nPYpScYeY89XHaXthynVSTY05/0TkR3kO1oprtnACq/i0nGsDLkYi nxIg== X-Gm-Message-State: APjAAAW6V8A5GIP+3HvC3LLBmCnMlSpdEQDqWxrVMisncMnUUSOqPDA2 TGvVfZmANmxygoEIM3CgAhCWpw== X-Received: by 2002:adf:c98b:: with SMTP id f11mr1155362wrh.274.1571206738605; Tue, 15 Oct 2019 23:18:58 -0700 (PDT) Received: from dell ([95.149.164.86]) by smtp.gmail.com with ESMTPSA id a3sm3004392wmc.3.2019.10.15.23.18.57 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 15 Oct 2019 23:18:57 -0700 (PDT) Date: Wed, 16 Oct 2019 07:18:56 +0100 From: Lee Jones To: Jakub Kicinski Cc: Thomas Bogendoerfer , Jonathan Corbet , Ralf Baechle , Paul Burton , James Hogan , "David S. Miller" , Srinivas Kandagatla , Alessandro Zummo , Alexandre Belloni , Greg Kroah-Hartman , Jiri Slaby , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org, netdev@vger.kernel.org, linux-rtc@vger.kernel.org, linux-serial@vger.kernel.org Subject: Re: [PATCH v10 4/6] mfd: ioc3: Add driver for SGI IOC3 chip Message-ID: <20191016061856.GA4365@dell> References: <20191015120953.2597-1-tbogendoerfer@suse.de> <20191015120953.2597-5-tbogendoerfer@suse.de> <20191015122349.612a230b@cakuba.netronome.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20191015122349.612a230b@cakuba.netronome.com> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 15 Oct 2019, Jakub Kicinski wrote: > On Tue, 15 Oct 2019 14:09:49 +0200, Thomas Bogendoerfer wrote: > > SGI IOC3 chip has integrated ethernet, keyboard and mouse interface. > > It also supports connecting a SuperIO chip for serial and parallel > > interfaces. IOC3 is used inside various SGI systemboards and add-on > > cards with different equipped external interfaces. > > > > Support for ethernet and serial interfaces were implemented inside > > the network driver. This patchset moves out the not network related > > parts to a new MFD driver, which takes care of card detection, > > setup of platform devices and interrupt distribution for the subdevices. > > > > Serial portion: Acked-by: Greg Kroah-Hartman > > Acked-for-MFD-by: Lee Jones > > > > Signed-off-by: Thomas Bogendoerfer > > Looks good, I think. Is that a Reviewed-by? If so, it doesn't sound like a very convincing one? If not, it's probably not worth replying at all. -- Lee Jones [李琼斯] Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog