Received: by 2002:a5b:505:0:0:0:0:0 with SMTP id o5csp7194693ybp; Wed, 16 Oct 2019 05:18:43 -0700 (PDT) X-Google-Smtp-Source: APXvYqywauzZfoWWU/X9DWab0wk49Vy3oP9bnrIdcT5qBFYg4z+nKE2dt5HDqQ75od3y5jG0zhVX X-Received: by 2002:a17:906:f15:: with SMTP id z21mr16551864eji.119.1571228322987; Wed, 16 Oct 2019 05:18:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1571228322; cv=none; d=google.com; s=arc-20160816; b=DY7ZJ8qg++lPtNi6HLd4pW5bfCaeKqp5JsLzMmntiJQ3adY2rnXdDcaVJFbrM0ZQGY nrsQ7KxY+7ekZaWbXGQ33KEsx3kWeXRjYGCou9iIlYpdSnjLKBZ/azHVK7FQ8t+T82wk cE3NldwJAWGh67lj9WUcLKQgBQ4QcaRnJqWAuh5Za2IVjZvG5W5N0CZFk7QsS/pNiKQG 3V3ru7hd0wk/W94DlNeNZnfmUgz9daTO/qpHJuzcvabJNYBTNhMza2BeuYXgJvVHijYD chXH5Dh/5e8GrC+H3Q4Cs4D1BaB9qkHi3N1gwlOhyL4yWtEE0Qhs+dsdFpStE5DiDFrj Kl/A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:references :in-reply-to:message-id:date:subject:cc:to:from:dkim-signature; bh=BcKGfqptsJMIyqg8m+kdv7mwKKvvYfua8/fbCWYYrS8=; b=PmgWpPsgr+GshtTlUmNKh9feiX7qd3NYSAVbS5xfZahdHad9D36zaHzOqV98Pef4TN Yls99SUame16+Vbi0Y/VE5ysfVoLOLyvKyxfa5ofWLJSg1c6Yv9kSNMbzCGCDYNvLRd1 +3/MPdnCu9j/vIO2+6fPQjshBjjJF8TxG9WTk+DfsP/SwVFJ+VkdH/ylGZNyyhw50mrl Qejlnc+3SyRmNeuDw54hY4G5CEgyT2Pr6nZL04BYYc8ZvhGMU4WhCmFn48YtcWCko/Mp 7xwjSUu5PD6gu912XUSLKOBE/pc130vru0rY0PHJGc9dc71jOJbLAL/0zrG3CSEPVA8Z sJhQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=zr8Jj6FL; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id o17si15118472ejm.261.2019.10.16.05.18.19; Wed, 16 Oct 2019 05:18:42 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=zr8Jj6FL; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732373AbfJPHed (ORCPT + 99 others); Wed, 16 Oct 2019 03:34:33 -0400 Received: from mail-pg1-f195.google.com ([209.85.215.195]:33802 "EHLO mail-pg1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732040AbfJPHeb (ORCPT ); Wed, 16 Oct 2019 03:34:31 -0400 Received: by mail-pg1-f195.google.com with SMTP id k20so6407511pgi.1 for ; Wed, 16 Oct 2019 00:34:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :in-reply-to:references; bh=BcKGfqptsJMIyqg8m+kdv7mwKKvvYfua8/fbCWYYrS8=; b=zr8Jj6FLnbAxHmN67Iiq1ZcLMchv+Ks/Xp8pWezcbvbe+OApPGXcik/g3TNk3LpCdn WqiMviPLfH4XpdhwwAjIO0HcaT+jzOcX1q19E/1nhHn4RLP03eszEg5BwAv95ODScHzl JZmDR3UbqSJzvqzT8KUI1AEZZgg+FUOEvnXpRfbq1Z+6/U7JBZLYCt1cwitQd0wmLkEA AKngyASWhgcLKrJNFfYpZfi9yZSyBTJX6NCr2Xyk6ck1mmcSjHH1UqHvZ3Cubx0wclSo /yJy0+zURpm9IagVQz5jHEmUPlKj0gbgX2093XrBsL3LVGxRTuvRHwsgexb+USPuV9WW fdwg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:in-reply-to:references; bh=BcKGfqptsJMIyqg8m+kdv7mwKKvvYfua8/fbCWYYrS8=; b=cZwC+Nq7rT8NBwYDjvXbzvOuTZJvCwjHsisS5YQ1jVeMJtzUi3dx02bp2awIy3ekeo +eooQPtLGDBKtH7BpCNPZleTvoPuJizjEev5c+KWPSOv8RX5i4gHo20r+HDirKqs9YuG Qi01bzp/8GQoFKIkwLDIXY6VygmO+UV6Av4ebESDSKygUCq3SoI5RttSxxAXwHX4L6KA L0Jtt15vXyAh0BdHy2d9YeCcT8FcLaRzEZlfX7MyEJ4POw6SLvp/QHbMkQNZB17fsLdp TEhvZ1Ppjf+gY2IPoLi/XjuYJDnQU6J6qpwamOZQm7THSKfL/vre6SGzlv8zm6d0ikkA 5Xvw== X-Gm-Message-State: APjAAAX1w05Df5f47hpWw9TOR02fDFqI5RumFycEBBKuFCQBiWtTJOxH 3gWhCi9cccuyDLjVgP4giTiX/XwdeXrSQQ== X-Received: by 2002:a63:1423:: with SMTP id u35mr5608555pgl.122.1571211270181; Wed, 16 Oct 2019 00:34:30 -0700 (PDT) Received: from localhost ([49.248.175.127]) by smtp.gmail.com with ESMTPSA id h186sm31611631pfb.63.2019.10.16.00.34.29 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 16 Oct 2019 00:34:29 -0700 (PDT) From: Amit Kucheria To: linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, bjorn.andersson@linaro.org, edubezval@gmail.com, agross@kernel.org, masneyb@onstation.org, swboyd@chromium.org, Amit Kucheria , Daniel Lezcano , Mark Rutland , Rob Herring , Zhang Rui Cc: linux-pm@vger.kernel.org Subject: [PATCH 02/15] drivers: thermal: tsens: Simplify code flow in tsens_probe Date: Wed, 16 Oct 2019 13:04:01 +0530 Message-Id: <184422dcc1c12553e71a58c62e01425fd7d1172a.1571210269.git.amit.kucheria@linaro.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: References: In-Reply-To: References: Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Move platform_set_drvdata up to avoid an extra 'if (ret)' check after the call to tsens_register. Signed-off-by: Amit Kucheria Reviewed-by: Stephen Boyd Reviewed-by: Daniel Lezcano --- drivers/thermal/qcom/tsens.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/thermal/qcom/tsens.c b/drivers/thermal/qcom/tsens.c index 6ed687a6e53c..542a7f8c3d96 100644 --- a/drivers/thermal/qcom/tsens.c +++ b/drivers/thermal/qcom/tsens.c @@ -149,6 +149,8 @@ static int tsens_probe(struct platform_device *pdev) priv->feat = data->feat; priv->fields = data->fields; + platform_set_drvdata(pdev, priv); + if (!priv->ops || !priv->ops->init || !priv->ops->get_temp) return -EINVAL; @@ -167,11 +169,7 @@ static int tsens_probe(struct platform_device *pdev) } } - ret = tsens_register(priv); - - platform_set_drvdata(pdev, priv); - - return ret; + return tsens_register(priv); } static int tsens_remove(struct platform_device *pdev) -- 2.17.1