Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Received-SPF: TempError (protection.outlook.com: error in processing during
 lookup of arm.com: DNS Timeout)
From:   "james qian wang (Arm Technology China)" <james.qian.wang@arm.com>
To:     Mihail Atanassov <Mihail.Atanassov@arm.com>
CC:     "dri-devel@lists.freedesktop.org" <dri-devel@lists.freedesktop.org>,
        David Airlie <airlied@linux.ie>,
        Liviu Dudau <Liviu.Dudau@arm.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        nd <nd@arm.com>
Subject: Re: drm/komeda: Don't flush inactive pipes
Thread-Topic: drm/komeda: Don't flush inactive pipes
Thread-Index: AQHVg/qy9vCXt00JukKh3lKp5LBlUg==
Date:   Wed, 16 Oct 2019 08:21:24 +0000
Message-ID: <20191016082117.GA18601@jamwan02-TSP300>
References: <20191010102950.56253-1-mihail.atanassov@arm.com>
In-Reply-To: <20191010102950.56253-1-mihail.atanassov@arm.com>
Accept-Language: en-US
Content-Language: en-US
user-agent: Mutt/1.10.1 (2018-07-13)
Authentication-Results-Original: spf=none (sender IP is )
 smtp.mailfrom=james.qian.wang@arm.com; 
x-ms-exchange-messagesentrepresentingtype: 1
x-ms-publictraffictype: Email
X-MS-Office365-Filtering-Correlation-Id: 57a6e671-78f4-4101-aa6c-08d75211dccf
X-MS-Office365-Filtering-HT: Tenant
X-MS-TrafficTypeDiagnostic: VE1PR08MB5088:|VE1PR08MB5088:|AM4PR08MB2675:
x-ms-exchange-transport-forked: True
X-Microsoft-Antispam-PRVS: <AM4PR08MB2675F9DD602D758DD95E59EFB3920@AM4PR08MB2675.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
x-ms-oob-tlc-oobclassifiers: OLM:147;OLM:147;
x-forefront-prvs: 0192E812EC
X-Forefront-Antispam-Report-Untrusted: SFV:NSPM;SFS:(10009020)(4636009)(7916004)(39860400002)(136003)(396003)(346002)(376002)(366004)(199004)(189003)(64756008)(386003)(55236004)(66446008)(102836004)(66066001)(6506007)(33716001)(26005)(14444005)(71190400001)(25786009)(256004)(14454004)(186003)(71200400001)(11346002)(446003)(476003)(33656002)(5660300002)(486006)(2906002)(66946007)(66476007)(66556008)(229853002)(9686003)(86362001)(1076003)(6246003)(478600001)(4326008)(6486002)(7736002)(54906003)(58126008)(316002)(8676002)(305945005)(6862004)(81156014)(52116002)(76176011)(6512007)(8936002)(3846002)(6116002)(6636002)(99286004)(6436002)(81166006);DIR:OUT;SFP:1101;SCL:1;SRVR:VE1PR08MB5088;H:VE1PR08MB5006.eurprd08.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1;MX:1;
received-spf: None (protection.outlook.com: arm.com does not designate
 permitted sender hosts)
X-MS-Exchange-SenderADCheck: 1
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original: 3PaNHNE67Y+NHeSc1/clKHzj+U6HpvpQLovV+Xiepv9KmJZpUAgl0Nd7a9qjKKJ23DT1kWljq8f7PTlbwxMFgEnt5uPqHnRDLWjY0cOi0t4v7BcsUFC8r3NOPhZnn5Tx/X/nP2JcUrVLqzg7aiYosHn1Ute0gW7LVo8Lwpmxq33PQVAtnO4ha7CTeIovxBiXfg4ASGZOg7Wwn/poD0/t62E42nNv7IeKrXCyO5/ZFsFz6eRaxhLtf323Rt992IUxGuhxiok87e8aIQrqRd6wOy7JVPEaiyqvB8whEkYO2iTGmbZdLmQu1PbnrDndvtwKQhNIB8RY4KRAsWz0JZTJ49Zh1JfVL8qgWh3BNWSDJTekAFtMwu5ZVi9tWCUHcE7pL66lZ7poHcSJumt1/LfRda2fSDWGFdrPkMSINVISZTI=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <7A1DD0FEC62ADD4882EA118DD1D6989E@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR08MB5088
Original-Authentication-Results: spf=none (sender IP is )
 smtp.mailfrom=james.qian.wang@arm.com; 
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT056.eop-EUR03.prod.protection.outlook.com
X-Forefront-Antispam-Report: CIP:63.35.35.123;IPV:CAL;SCL:-1;CTRY:IE;EFV:NLI;SFV:NSPM;SFS:(10009020)(7916004)(4636009)(346002)(136003)(396003)(376002)(39860400002)(199004)(189003)(33716001)(6636002)(47776003)(5660300002)(476003)(6246003)(22756006)(6862004)(446003)(126002)(11346002)(14444005)(33656002)(46406003)(63350400001)(486006)(1076003)(4326008)(336012)(6486002)(58126008)(70586007)(99286004)(102836004)(2906002)(36906005)(86362001)(316002)(8746002)(478600001)(81166006)(305945005)(26826003)(6512007)(81156014)(8936002)(8676002)(186003)(70206006)(229853002)(66066001)(23726003)(54906003)(76176011)(76130400001)(14454004)(26005)(9686003)(6116002)(3846002)(386003)(7736002)(6506007)(50466002)(25786009)(97756001)(356004);DIR:OUT;SFP:1101;SCL:1;SRVR:AM4PR08MB2675;H:64aa7808-outbound-1.mta.getcheckrecipient.com;FPR:;SPF:TempError;LANG:en;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;A:1;MX:1;
X-MS-Office365-Filtering-Correlation-Id-Prvs: 652180b1-cfef-4c71-b29b-08d75211d554
NoDisclaimer: True
X-Forefront-PRVS: 0192E812EC
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: +wyBcC8OsPSHLvzt/L1cIB+7hqJBeANCzenOewIrymNTMQq3bzHky/QNKyIhGSNHV1TCl2Hfez6doRKEfZoTWdz0kK3tWkaA4KSf6E/qfF0YMyKz4LOKe+8U5641nLxjBZjX/U413cwbDFU2VhMOi0dNceHpc/si1TJPp5E1BpolPriOxH3RWfTi+NVULrQa+rj9+sbfh66j/Q8dOBj92RsFzElA4X2G0NHU7pS3x7GnPJ24smsOzu+T2bIh2BRreySc9ZHE2SfJ3Qf7uOoRLr/uRn9cglYs6sYhvdyVucfID+DU4VF46IOyT0MH9aq17cfvJvckmWeYnJX+vlv4qYB88g987OlB0iTr/9SOCESYbiqoq2c2Zf6BqIsyrf9bqEmYwLamSYww/TXeyJ7cr8ocB4/I6garl+hpVnUiSSU=
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Oct 2019 08:21:36.8172
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 57a6e671-78f4-4101-aa6c-08d75211dccf
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR08MB2675
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Oct 10, 2019 at 10:30:07AM +0000, Mihail Atanassov wrote:
> HW doesn't allow flushing inactive pipes and raises an MERR interrupt
> if you try to do so. Stop triggering the MERR interrupt in the
> middle of a commit by calling drm_atomic_helper_commit_planes
> with the ACTIVE_ONLY flag.
>=20
> Signed-off-by: Mihail Atanassov <mihail.atanassov@arm.com>
> ---
>  drivers/gpu/drm/arm/display/komeda/komeda_kms.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>=20
> diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_kms.c b/drivers/gp=
u/drm/arm/display/komeda/komeda_kms.c
> index 8820ce15ce37..ae274902ff92 100644
> --- a/drivers/gpu/drm/arm/display/komeda/komeda_kms.c
> +++ b/drivers/gpu/drm/arm/display/komeda/komeda_kms.c
> @@ -82,7 +82,8 @@ static void komeda_kms_commit_tail(struct drm_atomic_st=
ate *old_state)
> =20
>  	drm_atomic_helper_commit_modeset_disables(dev, old_state);
> =20
> -	drm_atomic_helper_commit_planes(dev, old_state, 0);
> +	drm_atomic_helper_commit_planes(dev, old_state,
> +					DRM_PLANE_COMMIT_ACTIVE_ONLY);
>

Looks good to me.
Reviewed-by: James Qian Wang (Arm Technology China) <james.qian.wang@arm.co=
m>

>  	drm_atomic_helper_commit_modeset_enables(dev, old_state);
> =20