Received: by 2002:a5b:505:0:0:0:0:0 with SMTP id o5csp7299745ybp; Wed, 16 Oct 2019 06:50:23 -0700 (PDT) X-Google-Smtp-Source: APXvYqw4KrfjHhS4BMF2MR+PX45dJX5FRxUc7oezYZzz3Qfm6+pPCdlJyQQHeIna3IKXmFMJmum6 X-Received: by 2002:a05:6402:21e8:: with SMTP id ce8mr39606233edb.32.1571233822962; Wed, 16 Oct 2019 06:50:22 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1571233822; cv=none; d=google.com; s=arc-20160816; b=q+WKE7CCkB+uSrwvbqfBNVy1vULiUYSyFDsED7LhzyAPuIyuVRI59qVLM9Mbua7Tge aGSmsej+gQDKQ+OmX7+Kkr8E8DZS6YsIIanjWPV+HERZ38VKG39jidfByaYg/QPGNRVn CA30lXfa5fCB6+p47bg8C+yK8luMzzq5Ef3u+14OvJBqNuFjNm3NGU3Yfxs2aZ99bmuW 6fsV/1ACl5/dTrTX21WGp1azjAmzqf9p4Vokpj+9OF/ov5GFuSNyLO8CS62GWVdcDao2 AinZQ373KZZlzr96QyaKj71VWJMnYXlZj7uN64iDL7W/rVrYr2/GrtR3ypMWTFx4WgEi VUCw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:organization:references:cc:to:from:subject; bh=eMEYJuq2SlypHGVS2uCvKkxIUo7JHSc4VVtndzZAr2M=; b=lSIRPzgXn7g4tmhUchqGI1DfKaqMCdXU5Wye99NbuLYYL/A5oLrqFKmOgIOOHOKhtZ etMdBB97FTp+p8XwZaN4VNnV8L/r9ufNF0DIvbBxQmOyRuoV+M7EHwKy8RG9qCOBH791 CpExN2JLzI5GVljzQX2akVMwP+ZikYRVV8qnRKPw8K2NOtVOHJwOotWrFEfb5AzUuPr3 mkhVDNACTHwdQ326Ha+4KrlvKnleY4BMvl4y3JOBaGOLCrCinUSylm1cUESqlE7bl0NJ eUyboiBylyw0cEAVzUHwc7pnJNn2+S67bKRKeuuZxcwJ78JXqNX211kcPD4uCnrlcqwA g3Fg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id p3si15627848ejj.347.2019.10.16.06.49.59; Wed, 16 Oct 2019 06:50:22 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2392086AbfJPJuf (ORCPT + 99 others); Wed, 16 Oct 2019 05:50:35 -0400 Received: from mga04.intel.com ([192.55.52.120]:10412 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727434AbfJPJuf (ORCPT ); Wed, 16 Oct 2019 05:50:35 -0400 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 16 Oct 2019 02:50:35 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.67,303,1566889200"; d="scan'208";a="279478460" Received: from linux.intel.com ([10.54.29.200]) by orsmga001.jf.intel.com with ESMTP; 16 Oct 2019 02:50:35 -0700 Received: from [10.125.252.157] (abudanko-mobl.ccr.corp.intel.com [10.125.252.157]) by linux.intel.com (Postfix) with ESMTP id 6752D5803C5; Wed, 16 Oct 2019 02:50:32 -0700 (PDT) Subject: [PATCH v2 3/4] perf/x86/intel: implement LBR callstacks context synchronization From: Alexey Budankov To: Peter Zijlstra Cc: Arnaldo Carvalho de Melo , Ingo Molnar , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Andi Kleen , Kan Liang , Stephane Eranian , Ian Rogers , Song Liu , linux-kernel References: <5964c7e9-ab6f-c0d0-3dca-31196606e337@linux.intel.com> Organization: Intel Corp. Message-ID: <79b0e201-479e-0e35-4ef4-3f6410ee28e4@linux.intel.com> Date: Wed, 16 Oct 2019 12:50:31 +0300 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <5964c7e9-ab6f-c0d0-3dca-31196606e337@linux.intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Implement intel_pmu_lbr_sync_task_ctx() method that updates counter of the events that requested LBR callstack data on a sample. The counter can be zero for the case when task context belongs to a thread that has just come from a block on a futex and the context contains saved (lbr_stack_state == LBR_VALID) LBR register values. For the values to be restored at LBR registers on the next thread's switch-in event it copies the counter value that is expected to be non zero from the previous equivalent task perf event context. Signed-off-by: Alexey Budankov --- arch/x86/events/intel/lbr.c | 9 +++++++++ arch/x86/events/perf_event.h | 3 +++ 2 files changed, 12 insertions(+) diff --git a/arch/x86/events/intel/lbr.c b/arch/x86/events/intel/lbr.c index ea54634eabf3..152a3f8b516a 100644 --- a/arch/x86/events/intel/lbr.c +++ b/arch/x86/events/intel/lbr.c @@ -417,6 +417,15 @@ static void __intel_pmu_lbr_save(struct x86_perf_task_context *task_ctx) cpuc->last_log_id = ++task_ctx->log_id; } +void intel_pmu_lbr_sync_task_ctx(struct x86_perf_task_context *one, + struct x86_perf_task_context *another) +{ + if (!one || !another) + return; + + one->lbr_callstack_users = another->lbr_callstack_users; +} + void intel_pmu_lbr_sched_task(struct perf_event_context *ctx, bool sched_in) { struct cpu_hw_events *cpuc = this_cpu_ptr(&cpu_hw_events); diff --git a/arch/x86/events/perf_event.h b/arch/x86/events/perf_event.h index a25e6d7eb87b..3e0087c06fc9 100644 --- a/arch/x86/events/perf_event.h +++ b/arch/x86/events/perf_event.h @@ -1024,6 +1024,9 @@ void intel_pmu_store_pebs_lbrs(struct pebs_lbr *lbr); void intel_ds_init(void); +void intel_pmu_lbr_sync_task_ctx(struct x86_perf_task_context *one, + struct x86_perf_task_context *another); + void intel_pmu_lbr_sched_task(struct perf_event_context *ctx, bool sched_in); u64 lbr_from_signext_quirk_wr(u64 val); -- 2.20.1