Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Arnaldo Carvalho de Melo <arnaldo.melo@gmail.com>
Date:   Wed, 16 Oct 2019 10:09:21 -0300
To:     Yunfeng Ye <yeyunfeng@huawei.com>
Cc:     peterz@infradead.org, mingo@redhat.com, mark.rutland@arm.com,
        alexander.shishkin@linux.intel.com, jolsa@redhat.com,
        namhyung@kernel.org, linux-kernel@vger.kernel.org,
        hushiyuan@huawei.com, linfeilong@huawei.com
Subject: Re: [PATCH] perf kmem: Fix memory leak in compact_gfp_flags()
Message-ID: <20191016130921.GC22835@kernel.org>
References: <f9e9f458-96f3-4a97-a1d5-9feec2420e07@huawei.com>
 <20191016130403.GA22835@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20191016130403.GA22835@kernel.org>
User-Agent: Mutt/1.12.1 (2019-06-15)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Em Wed, Oct 16, 2019 at 10:04:03AM -0300, Arnaldo Carvalho de Melo escreveu:
> Em Wed, Oct 16, 2019 at 04:38:45PM +0800, Yunfeng Ye escreveu:
> > The memory @orig_flags is allocated by strdup(), it is freed on the
> > normal path, but leak to free on the error path.
> 
> Are you using some tool to find out these problems? Or is it just visual
> inspection?

Anyway, applied after adding this to the commit log message:

Fixes: 0e11115644b3 ("perf kmem: Print gfp flags in human readable string")

- Arnaldo
 
> - Arnaldo
>  
> > Fix this by adding free(orig_flags) on the error path.
> > 
> > Signed-off-by: Yunfeng Ye <yeyunfeng@huawei.com>
> > ---
> >  tools/perf/builtin-kmem.c | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/tools/perf/builtin-kmem.c b/tools/perf/builtin-kmem.c
> > index 1e61e353f579..9661671cc26e 100644
> > --- a/tools/perf/builtin-kmem.c
> > +++ b/tools/perf/builtin-kmem.c
> > @@ -691,6 +691,7 @@ static char *compact_gfp_flags(char *gfp_flags)
> >  			new = realloc(new_flags, len + strlen(cpt) + 2);
> >  			if (new == NULL) {
> >  				free(new_flags);
> > +				free(orig_flags);
> >  				return NULL;
> >  			}
> > 
> > -- 
> > 2.7.4.3
> 
> -- 
> 
> - Arnaldo

-- 

- Arnaldo