Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Wed, 16 Oct 2019 16:50:02 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     Bjorn Helgaas <helgaas@kernel.org>
Cc:     Dexuan Cui <decui@microsoft.com>,
        driverdev-devel@linuxdriverproject.org, olaf@aepfle.de,
        Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
        Stephen Hemminger <sthemmin@microsoft.com>, jackm@mellanox.com,
        Haiyang Zhang <haiyangz@microsoft.com>,
        "Rafael J . Wysocki" <rafael.j.wysocki@intel.com>,
        linux-hyperv@vger.kernel.org,
        Michael Kelley <mikelley@microsoft.com>,
        Sasha Levin <Alexander.Levin@microsoft.com>,
        marcelo.cerri@canonical.com, linux-pci@vger.kernel.org,
        apw@canonical.com, vkuznets@redhat.com,
        Bjorn Helgaas <bhelgaas@google.com>, jasowang@redhat.com,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH 5/7] PCI/PM: Make power management op coding style
 consistent
Message-ID: <20191016135002.GA24678@kadam>
References: <20191014230016.240912-1-helgaas@kernel.org>
 <20191014230016.240912-6-helgaas@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20191014230016.240912-6-helgaas@kernel.org>
User-Agent: Mutt/1.9.4 (2018-02-28)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, Oct 14, 2019 at 06:00:14PM -0500, Bjorn Helgaas wrote:
> From: Bjorn Helgaas <bhelgaas@google.com>
> 
> Some of the power management ops use this style:
> 
>   struct device_driver *drv = dev->driver;
>   if (drv && drv->pm && drv->pm->prepare(dev))
>     drv->pm->prepare(dev);
> 
> while others use this:
> 
>   const struct dev_pm_ops *pm = dev->driver ? dev->driver->pm : NULL;

I like this patch a lot, especially the direct returns.  But it
occurs to me that in the future this conditional would look better as

	const struct dev_pm_ops *pm = driver_to_pm(dev->driver);

or something.

regards,
dan carpenter